You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Mark Phippard <ma...@softlanding.com> on 2005/10/27 17:56:03 UTC

[PATCH] New JavaHL methods for SVN_ASP_DOT_NET_HACK not implemented correctly

The way the new methods for isAdminDirectory() and getAdminDirectoryName() 

were added to the JavaHL SVNClientSynchrnonized class does not follow the 
normal convention of that class and how it implements methods.  Actually, 
I do not think they will even work, because there is no "native" C++ class 

that backs this class.

Subclipse uses this version of the class, so this needs to be resolved 
prior to 1.3.

Thanks

Mark



Patch attached.

Index: org/tigris/subversion/javahl/SVNClientSynchronized.java
===================================================================
--- org/tigris/subversion/javahl/SVNClientSynchronized.java     (revision 
17058)
+++ org/tigris/subversion/javahl/SVNClientSynchronized.java     (working 
copy)
@@ -59,7 +59,13 @@
      * on Windows.
      * @since 1.3
      */
-    public native String getAdminDirectoryName();
+    public String getAdminDirectoryName()
+    {
+        synchronized(clazz)
+        {
+            return worker.getAdminDirectoryName();
+        }
+    }
 
     /**
      * @param name The name of the directory to compare.
@@ -67,7 +73,13 @@
      * administrative directory.
      * @since 1.3
      */
-    public native boolean isAdminDirectory(String name);
+    public boolean isAdminDirectory(String name)
+    {
+        synchronized(clazz)
+        {
+            return worker.isAdminDirectory(name);
+        }
+    }
 
     /**
      * Returns the last destination path submitted.

_____________________________________________________________________________
Scanned for SoftLanding Systems, Inc. and SoftLanding Europe Plc by IBM Email Security Management Services powered by MessageLabs. 
_____________________________________________________________________________

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: [PATCH] New JavaHL methods for SVN_ASP_DOT_NET_HACK not implemented correctly

Posted by Daniel Rall <dl...@collab.net>.
On Thu, 27 Oct 2005, Mark Phippard wrote:

> The way the new methods for isAdminDirectory() and getAdminDirectoryName() 
> were added to the JavaHL SVNClientSynchrnonized class does not follow the 
> normal convention of that class and how it implements methods.
...
> Subclipse uses this version of the class, so this needs to be resolved 
> prior to 1.3.

This has been fixed in trunk and backported to the 1.3.x branch.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org