You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "hartmannathan (via GitHub)" <gi...@apache.org> on 2023/05/01 01:34:38 UTC

[GitHub] [nuttx-apps] hartmannathan commented on pull request #1711: testing/ostest: add test case for task priority change with locked scheduler

hartmannathan commented on PR #1711:
URL: https://github.com/apache/nuttx-apps/pull/1711#issuecomment-1529234799

   Continuing what @davids5 was saying, I think a comment in the code that explains the purpose of the test and what we expect from it will help people reading the code later.
   
   Separately, another idea:
   
   Since the test is expected to fail due to a bug, I think we should modify the ostest program to tally five possible results from each test, like some other test suites do: pass, fail, expected fail, unexpected pass, skipped.
   
   Explanation:
   
   - pass: the test passed as expected 
   
   - fail: the test should have passed but it failed
   
   - expected fail: the test failed and it was expected to fail because of a known bug; that is the situation with the test in this PR. We should tally such failures separately from above-mentioned fail because they are caused by known bugs
   
   - unexpected pass: we expected the test to fail with "expected fail" because of a known bug, but to our surprise, it passed unexpectedly 
   
   - skipped: the test is not being run because the hardware or build doesn't support it; e.g., the priority inheritance tests will be skipped in a non-priority-inheritance build


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org