You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@falcon.apache.org by Deepak Barr <de...@gmail.com> on 2016/01/18 15:14:32 UTC
Review Request 42459: FALCON - 1644 : Add Postgres support for native
scheduler
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42459/
-----------------------------------------------------------
Review request for Falcon.
Bugs: FALCON-1664
https://issues.apache.org/jira/browse/FALCON-1664
Repository: falcon-git
Description
-------
Added postgres support.
Diffs
-----
common/src/main/resources/statestore.properties a67a871
docs/src/site/twiki/FalconNativeScheduler.twiki 6f0679e
pom.xml 39ee9ac
scheduler/pom.xml 6392e98
scheduler/src/main/java/org/apache/falcon/state/store/jdbc/InstanceBean.java 7f7b966
scheduler/src/main/java/org/apache/falcon/tools/FalconStateStoreDBCLI.java 7f22b0e
scheduler/src/main/resources/META-INF/persistence.xml 99e116c
src/conf/statestore.properties 0c912ad
Diff: https://reviews.apache.org/r/42459/diff/
Testing
-------
Yes. Tested with PostgreSQL 9.5.
Ran the following command and got no errors -
mvn clean install -Ptest-patch,hadoop-2
Thanks,
Deepak Barr
Re: Review Request 42459: FALCON - 1644 : Add Postgres support for
native scheduler
Posted by Deepak Barr <de...@gmail.com>.
> On Jan. 20, 2016, 8:49 a.m., Praveen Adlakha wrote:
> > src/conf/statestore.properties, line 24
> > <https://reviews.apache.org/r/42459/diff/1/?file=1200470#file1200470line24>
> >
> > I was wondering what was the testing done?
Table creations was tested.
Process scheduling was tested. The entries were reflected in the postgreSQL DB.
- Deepak
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42459/#review115384
-----------------------------------------------------------
On Jan. 18, 2016, 2:14 p.m., Deepak Barr wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42459/
> -----------------------------------------------------------
>
> (Updated Jan. 18, 2016, 2:14 p.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1664
> https://issues.apache.org/jira/browse/FALCON-1664
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Added postgres support.
>
>
> Diffs
> -----
>
> common/src/main/resources/statestore.properties a67a871
> docs/src/site/twiki/FalconNativeScheduler.twiki 6f0679e
> pom.xml 39ee9ac
> scheduler/pom.xml 6392e98
> scheduler/src/main/java/org/apache/falcon/state/store/jdbc/InstanceBean.java 7f7b966
> scheduler/src/main/java/org/apache/falcon/tools/FalconStateStoreDBCLI.java 7f22b0e
> scheduler/src/main/resources/META-INF/persistence.xml 99e116c
> src/conf/statestore.properties 0c912ad
>
> Diff: https://reviews.apache.org/r/42459/diff/
>
>
> Testing
> -------
>
> Yes. Tested with PostgreSQL 9.5.
> Ran the following command and got no errors -
> mvn clean install -Ptest-patch,hadoop-2
>
>
> Thanks,
>
> Deepak Barr
>
>
Re: Review Request 42459: FALCON - 1644 : Add Postgres support for
native scheduler
Posted by Deepak Barr <de...@gmail.com>.
> On Jan. 20, 2016, 8:49 a.m., Praveen Adlakha wrote:
> > docs/src/site/twiki/FalconNativeScheduler.twiki, line 116
> > <https://reviews.apache.org/r/42459/diff/1/?file=1200464#file1200464line116>
> >
> > Should we add documentation how and when to use postgres ?
Should be OK. how to use postgreSQL/MySQL is very intuitive and standard. The user just need to update the Driver class and jdbc connection string.
- Deepak
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42459/#review115384
-----------------------------------------------------------
On Jan. 18, 2016, 2:14 p.m., Deepak Barr wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42459/
> -----------------------------------------------------------
>
> (Updated Jan. 18, 2016, 2:14 p.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1664
> https://issues.apache.org/jira/browse/FALCON-1664
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Added postgres support.
>
>
> Diffs
> -----
>
> common/src/main/resources/statestore.properties a67a871
> docs/src/site/twiki/FalconNativeScheduler.twiki 6f0679e
> pom.xml 39ee9ac
> scheduler/pom.xml 6392e98
> scheduler/src/main/java/org/apache/falcon/state/store/jdbc/InstanceBean.java 7f7b966
> scheduler/src/main/java/org/apache/falcon/tools/FalconStateStoreDBCLI.java 7f22b0e
> scheduler/src/main/resources/META-INF/persistence.xml 99e116c
> src/conf/statestore.properties 0c912ad
>
> Diff: https://reviews.apache.org/r/42459/diff/
>
>
> Testing
> -------
>
> Yes. Tested with PostgreSQL 9.5.
> Ran the following command and got no errors -
> mvn clean install -Ptest-patch,hadoop-2
>
>
> Thanks,
>
> Deepak Barr
>
>
Re: Review Request 42459: FALCON - 1644 : Add Postgres support for
native scheduler
Posted by Praveen Adlakha <ad...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42459/#review115384
-----------------------------------------------------------
docs/src/site/twiki/FalconNativeScheduler.twiki (line 116)
<https://reviews.apache.org/r/42459/#comment176371>
Should we add documentation how and when to use postgres ?
src/conf/statestore.properties (line 24)
<https://reviews.apache.org/r/42459/#comment176370>
I was wondering what was the testing done?
- Praveen Adlakha
On Jan. 18, 2016, 2:14 p.m., Deepak Barr wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42459/
> -----------------------------------------------------------
>
> (Updated Jan. 18, 2016, 2:14 p.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1664
> https://issues.apache.org/jira/browse/FALCON-1664
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Added postgres support.
>
>
> Diffs
> -----
>
> common/src/main/resources/statestore.properties a67a871
> docs/src/site/twiki/FalconNativeScheduler.twiki 6f0679e
> pom.xml 39ee9ac
> scheduler/pom.xml 6392e98
> scheduler/src/main/java/org/apache/falcon/state/store/jdbc/InstanceBean.java 7f7b966
> scheduler/src/main/java/org/apache/falcon/tools/FalconStateStoreDBCLI.java 7f22b0e
> scheduler/src/main/resources/META-INF/persistence.xml 99e116c
> src/conf/statestore.properties 0c912ad
>
> Diff: https://reviews.apache.org/r/42459/diff/
>
>
> Testing
> -------
>
> Yes. Tested with PostgreSQL 9.5.
> Ran the following command and got no errors -
> mvn clean install -Ptest-patch,hadoop-2
>
>
> Thanks,
>
> Deepak Barr
>
>
Re: Review Request 42459: FALCON - 1644 : Add Postgres support for
native scheduler
Posted by PRAGYA MITTAL <mi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42459/#review115613
-----------------------------------------------------------
Ship it!
Ship It!
- PRAGYA MITTAL
On Jan. 21, 2016, 11:56 a.m., Deepak Barr wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42459/
> -----------------------------------------------------------
>
> (Updated Jan. 21, 2016, 11:56 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1664
> https://issues.apache.org/jira/browse/FALCON-1664
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Added postgres support.
>
>
> Diffs
> -----
>
> common/src/main/resources/statestore.properties a67a871
> docs/src/site/twiki/FalconNativeScheduler.twiki 6f0679e
> pom.xml 39ee9ac
> scheduler/pom.xml 6392e98
> scheduler/src/main/java/org/apache/falcon/state/store/jdbc/InstanceBean.java 5ed3ccd
> scheduler/src/main/java/org/apache/falcon/tools/FalconStateStoreDBCLI.java 7f22b0e
> scheduler/src/main/resources/META-INF/persistence.xml 99e116c
> src/conf/statestore.properties 0c912ad
>
> Diff: https://reviews.apache.org/r/42459/diff/
>
>
> Testing
> -------
>
> Yes. Tested with PostgreSQL 9.5.
> Ran the following command and got no errors -
> mvn clean install -Ptest-patch,hadoop-2
>
>
> Thanks,
>
> Deepak Barr
>
>
Re: Review Request 42459: FALCON - 1644 : Add Postgres support for
native scheduler
Posted by Deepak Barr <de...@gmail.com>.
> On Jan. 21, 2016, 12:04 p.m., pavan kumar kolamuri wrote:
> > scheduler/src/main/java/org/apache/falcon/state/store/jdbc/InstanceBean.java, line 116
> > <https://reviews.apache.org/r/42459/diff/2/?file=1204356#file1204356line116>
> >
> > Are you sure this change wont affect with derby ? If testcases run mostly it should be fine.
Yes. Testcases are passing.
- Deepak
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42459/#review115608
-----------------------------------------------------------
On Jan. 21, 2016, 11:56 a.m., Deepak Barr wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42459/
> -----------------------------------------------------------
>
> (Updated Jan. 21, 2016, 11:56 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1664
> https://issues.apache.org/jira/browse/FALCON-1664
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Added postgres support.
>
>
> Diffs
> -----
>
> common/src/main/resources/statestore.properties a67a871
> docs/src/site/twiki/FalconNativeScheduler.twiki 6f0679e
> pom.xml 39ee9ac
> scheduler/pom.xml 6392e98
> scheduler/src/main/java/org/apache/falcon/state/store/jdbc/InstanceBean.java 5ed3ccd
> scheduler/src/main/java/org/apache/falcon/tools/FalconStateStoreDBCLI.java 7f22b0e
> scheduler/src/main/resources/META-INF/persistence.xml 99e116c
> src/conf/statestore.properties 0c912ad
>
> Diff: https://reviews.apache.org/r/42459/diff/
>
>
> Testing
> -------
>
> Yes. Tested with PostgreSQL 9.5.
> Ran the following command and got no errors -
> mvn clean install -Ptest-patch,hadoop-2
>
>
> Thanks,
>
> Deepak Barr
>
>
Re: Review Request 42459: FALCON - 1644 : Add Postgres support for
native scheduler
Posted by pavan kumar kolamuri <pa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42459/#review115608
-----------------------------------------------------------
scheduler/src/main/java/org/apache/falcon/state/store/jdbc/InstanceBean.java (line 116)
<https://reviews.apache.org/r/42459/#comment176597>
Are you sure this change wont affect with derby ? If testcases run mostly it should be fine.
- pavan kumar kolamuri
On Jan. 21, 2016, 11:56 a.m., Deepak Barr wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42459/
> -----------------------------------------------------------
>
> (Updated Jan. 21, 2016, 11:56 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1664
> https://issues.apache.org/jira/browse/FALCON-1664
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Added postgres support.
>
>
> Diffs
> -----
>
> common/src/main/resources/statestore.properties a67a871
> docs/src/site/twiki/FalconNativeScheduler.twiki 6f0679e
> pom.xml 39ee9ac
> scheduler/pom.xml 6392e98
> scheduler/src/main/java/org/apache/falcon/state/store/jdbc/InstanceBean.java 5ed3ccd
> scheduler/src/main/java/org/apache/falcon/tools/FalconStateStoreDBCLI.java 7f22b0e
> scheduler/src/main/resources/META-INF/persistence.xml 99e116c
> src/conf/statestore.properties 0c912ad
>
> Diff: https://reviews.apache.org/r/42459/diff/
>
>
> Testing
> -------
>
> Yes. Tested with PostgreSQL 9.5.
> Ran the following command and got no errors -
> mvn clean install -Ptest-patch,hadoop-2
>
>
> Thanks,
>
> Deepak Barr
>
>
Re: Review Request 42459: FALCON - 1644 : Add Postgres support for
native scheduler
Posted by Deepak Barr <de...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42459/
-----------------------------------------------------------
(Updated Jan. 21, 2016, 11:56 a.m.)
Review request for Falcon.
Changes
-------
added postgres version against which the changes were tested.
Bugs: FALCON-1664
https://issues.apache.org/jira/browse/FALCON-1664
Repository: falcon-git
Description
-------
Added postgres support.
Diffs (updated)
-----
common/src/main/resources/statestore.properties a67a871
docs/src/site/twiki/FalconNativeScheduler.twiki 6f0679e
pom.xml 39ee9ac
scheduler/pom.xml 6392e98
scheduler/src/main/java/org/apache/falcon/state/store/jdbc/InstanceBean.java 5ed3ccd
scheduler/src/main/java/org/apache/falcon/tools/FalconStateStoreDBCLI.java 7f22b0e
scheduler/src/main/resources/META-INF/persistence.xml 99e116c
src/conf/statestore.properties 0c912ad
Diff: https://reviews.apache.org/r/42459/diff/
Testing
-------
Yes. Tested with PostgreSQL 9.5.
Ran the following command and got no errors -
mvn clean install -Ptest-patch,hadoop-2
Thanks,
Deepak Barr
Re: Review Request 42459: FALCON - 1644 : Add Postgres support for
native scheduler
Posted by Deepak Barr <de...@gmail.com>.
> On Jan. 20, 2016, 9:06 a.m., Pallavi Rao wrote:
> > docs/src/site/twiki/FalconNativeScheduler.twiki, line 116
> > <https://reviews.apache.org/r/42459/diff/1/?file=1200464#file1200464line116>
> >
> > Nit: Please also add the version against which you ran the test for postgreSQL
Will fix this. Thank you.
- Deepak
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42459/#review115385
-----------------------------------------------------------
On Jan. 18, 2016, 2:14 p.m., Deepak Barr wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42459/
> -----------------------------------------------------------
>
> (Updated Jan. 18, 2016, 2:14 p.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1664
> https://issues.apache.org/jira/browse/FALCON-1664
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Added postgres support.
>
>
> Diffs
> -----
>
> common/src/main/resources/statestore.properties a67a871
> docs/src/site/twiki/FalconNativeScheduler.twiki 6f0679e
> pom.xml 39ee9ac
> scheduler/pom.xml 6392e98
> scheduler/src/main/java/org/apache/falcon/state/store/jdbc/InstanceBean.java 7f7b966
> scheduler/src/main/java/org/apache/falcon/tools/FalconStateStoreDBCLI.java 7f22b0e
> scheduler/src/main/resources/META-INF/persistence.xml 99e116c
> src/conf/statestore.properties 0c912ad
>
> Diff: https://reviews.apache.org/r/42459/diff/
>
>
> Testing
> -------
>
> Yes. Tested with PostgreSQL 9.5.
> Ran the following command and got no errors -
> mvn clean install -Ptest-patch,hadoop-2
>
>
> Thanks,
>
> Deepak Barr
>
>
Re: Review Request 42459: FALCON - 1644 : Add Postgres support for
native scheduler
Posted by Pallavi Rao <pa...@inmobi.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42459/#review115385
-----------------------------------------------------------
Ship it!
docs/src/site/twiki/FalconNativeScheduler.twiki (line 116)
<https://reviews.apache.org/r/42459/#comment176374>
Nit: Please also add the version against which you ran the test for postgreSQL
Go to go once you address the minor comment.
- Pallavi Rao
On Jan. 18, 2016, 2:14 p.m., Deepak Barr wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42459/
> -----------------------------------------------------------
>
> (Updated Jan. 18, 2016, 2:14 p.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1664
> https://issues.apache.org/jira/browse/FALCON-1664
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Added postgres support.
>
>
> Diffs
> -----
>
> common/src/main/resources/statestore.properties a67a871
> docs/src/site/twiki/FalconNativeScheduler.twiki 6f0679e
> pom.xml 39ee9ac
> scheduler/pom.xml 6392e98
> scheduler/src/main/java/org/apache/falcon/state/store/jdbc/InstanceBean.java 7f7b966
> scheduler/src/main/java/org/apache/falcon/tools/FalconStateStoreDBCLI.java 7f22b0e
> scheduler/src/main/resources/META-INF/persistence.xml 99e116c
> src/conf/statestore.properties 0c912ad
>
> Diff: https://reviews.apache.org/r/42459/diff/
>
>
> Testing
> -------
>
> Yes. Tested with PostgreSQL 9.5.
> Ran the following command and got no errors -
> mvn clean install -Ptest-patch,hadoop-2
>
>
> Thanks,
>
> Deepak Barr
>
>