You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@qpid.apache.org by GitBox <gi...@apache.org> on 2020/11/12 11:25:49 UTC

[GitHub] [qpid-proton] gemmellr commented on pull request #276: PROTON-2295 avoid broken Go 1.15.3 on macOS CI

gemmellr commented on pull request #276:
URL: https://github.com/apache/qpid-proton/pull/276#issuecomment-726018835


   Great. Seems to have worked.
   
   Stylistic nit, I think Its nicer if the if is the first element of a step, it makes it easier to discern if the step is relevant or not when reading the config...admittedly it is clear from the output/status details for the job that a given step has run or not though.
   
   Could perhaps also rename the step to "Setup go (Mac OS)" to distinguish it?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org