You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Ramesh Mani <rm...@hortonworks.com> on 2018/04/24 20:23:50 UTC
Review Request 66783: ATLAS-2317:[Docs] Add HBase Bridge Documents
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66783/
-----------------------------------------------------------
Review request for atlas, Apoorv Naik, Madhan Neethiraj, and Sarath Subramanian.
Repository: atlas
Description
-------
ATLAS-2317:[Docs] Add HBase Bridge Documents
Diffs
-----
docs/src/site/twiki/Bridge-HBase.twiki PRE-CREATION
Diff: https://reviews.apache.org/r/66783/diff/1/
Testing
-------
Thanks,
Ramesh Mani
Re: Review Request 66783: ATLAS-2317:[Docs] Add HBase Bridge Documents
Posted by Ramesh Mani <rm...@hortonworks.com>.
> On April 24, 2018, 8:36 p.m., Madhan Neethiraj wrote:
> > docs/src/site/twiki/Bridge-HBase.twiki
> > Lines 7 (patched)
> > <https://reviews.apache.org/r/66783/diff/1/?file=2011190#file2011190line7>
> >
> > Similar to hive_db, hbase_namespace should be an Asset not a DataSet. Please review and update (the code).
I shall take care of the code update in separate JIRA.
- Ramesh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66783/#review201857
-----------------------------------------------------------
On April 24, 2018, 9:04 p.m., Ramesh Mani wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66783/
> -----------------------------------------------------------
>
> (Updated April 24, 2018, 9:04 p.m.)
>
>
> Review request for atlas, Apoorv Naik, Madhan Neethiraj, and Sarath Subramanian.
>
>
> Repository: atlas
>
>
> Description
> -------
>
> ATLAS-2317:[Docs] Add HBase Bridge Documents
>
>
> Diffs
> -----
>
> docs/src/site/twiki/Bridge-HBase.twiki PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/66783/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ramesh Mani
>
>
Re: Review Request 66783: ATLAS-2317:[Docs] Add HBase Bridge Documents
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66783/#review201857
-----------------------------------------------------------
docs/src/site/twiki/Bridge-HBase.twiki
Lines 7 (patched)
<https://reviews.apache.org/r/66783/#comment283468>
Similar to hive_db, hbase_namespace should be an Asset not a DataSet. Please review and update (the code).
docs/src/site/twiki/Bridge-HBase.twiki
Lines 22 (patched)
<https://reviews.apache.org/r/66783/#comment283469>
<namespace>.<tableName> ==> <namespace>:<tableName>
- Madhan Neethiraj
On April 24, 2018, 8:23 p.m., Ramesh Mani wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66783/
> -----------------------------------------------------------
>
> (Updated April 24, 2018, 8:23 p.m.)
>
>
> Review request for atlas, Apoorv Naik, Madhan Neethiraj, and Sarath Subramanian.
>
>
> Repository: atlas
>
>
> Description
> -------
>
> ATLAS-2317:[Docs] Add HBase Bridge Documents
>
>
> Diffs
> -----
>
> docs/src/site/twiki/Bridge-HBase.twiki PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/66783/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ramesh Mani
>
>
Re: Review Request 66783: ATLAS-2317:[Docs] Add HBase Bridge Documents
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66783/#review201870
-----------------------------------------------------------
Ship it!
Ship It!
- Madhan Neethiraj
On April 24, 2018, 9:04 p.m., Ramesh Mani wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66783/
> -----------------------------------------------------------
>
> (Updated April 24, 2018, 9:04 p.m.)
>
>
> Review request for atlas, Apoorv Naik, Madhan Neethiraj, and Sarath Subramanian.
>
>
> Repository: atlas
>
>
> Description
> -------
>
> ATLAS-2317:[Docs] Add HBase Bridge Documents
>
>
> Diffs
> -----
>
> docs/src/site/twiki/Bridge-HBase.twiki PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/66783/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ramesh Mani
>
>
Re: Review Request 66783: ATLAS-2317:[Docs] Add HBase Bridge Documents
Posted by Ramesh Mani <rm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66783/
-----------------------------------------------------------
(Updated April 24, 2018, 9:04 p.m.)
Review request for atlas, Apoorv Naik, Madhan Neethiraj, and Sarath Subramanian.
Changes
-------
Fixed review comments
Repository: atlas
Description
-------
ATLAS-2317:[Docs] Add HBase Bridge Documents
Diffs (updated)
-----
docs/src/site/twiki/Bridge-HBase.twiki PRE-CREATION
Diff: https://reviews.apache.org/r/66783/diff/3/
Changes: https://reviews.apache.org/r/66783/diff/2-3/
Testing
-------
Thanks,
Ramesh Mani
Re: Review Request 66783: ATLAS-2317:[Docs] Add HBase Bridge Documents
Posted by Ramesh Mani <rm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66783/
-----------------------------------------------------------
(Updated April 24, 2018, 8:36 p.m.)
Review request for atlas, Apoorv Naik, Madhan Neethiraj, and Sarath Subramanian.
Changes
-------
Made a minor modification.
Repository: atlas
Description
-------
ATLAS-2317:[Docs] Add HBase Bridge Documents
Diffs (updated)
-----
docs/src/site/twiki/Bridge-HBase.twiki PRE-CREATION
Diff: https://reviews.apache.org/r/66783/diff/2/
Changes: https://reviews.apache.org/r/66783/diff/1-2/
Testing
-------
Thanks,
Ramesh Mani