[GitHub] [incubator-devlake] e2corporation commented on pull request #2995: feat(config-ui): added prettier to help format code

[GitBox <gi...@apache.org>]

e2corporation commented on PR #2995:
URL: https://github.com/apache/incubator-devlake/pull/2995#issuecomment-1239320980

   @mintsweet **Prettier** will cause conflicts with ESLint, especially with regard to single quotes use and JSX files. There is a method to have ESLint working together with prettier but it requires more configuration. When Prettier auto-formats JSX it will replace all single quotes with double quotes, ignoring the single quote rule altogether making it a requirement to run eslint again to backfix the double quotes.
   
   While prettier can be used locally for now, I don't want prettier formally checked into the codebase auto-formatting files until it has been properly tested & configured to operate with ESLint & JSX. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org