You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/11/29 11:16:45 UTC
[GitHub] [airflow] ashb commented on a change in pull request #19858: Skip masking airflow password for tests
ashb commented on a change in pull request #19858:
URL: https://github.com/apache/airflow/pull/19858#discussion_r758264489
##########
File path: airflow/utils/log/secrets_masker.py
##########
@@ -232,11 +235,12 @@ def redact(self, item: "RedactableItem", name: Optional[str] = None) -> "Redacta
def add_mask(self, secret: Union[str, dict, Iterable], name: str = None):
"""Add a new secret to be masked to this filter instance."""
+ test_mode = os.environ.get("AIRFLOW__CORE__UNIT_TEST_MODE")
Review comment:
```suggestion
from airflow.configuration import conf
test_mode: bool = conf.getboolean('core', 'unit_test_mode')
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org