[GitHub] [apisix] tokers commented on a change in pull request #4164: feat: add 50x html for error page

[GitBox <gi...@apache.org>]

tokers commented on a change in pull request #4164:
URL: https://github.com/apache/apisix/pull/4164#discussion_r629056200



##########
File path: apisix/cli/ngx_tpl.lua
##########
@@ -367,6 +381,17 @@ http {
                 apisix.http_admin()
             }
         }
+
+        location = /50x.html {

Review comment:
       Ditto.

##########
File path: apisix/init.lua
##########
@@ -476,13 +476,12 @@ function _M.http_access_phase()
     set_upstream_host(api_ctx)
 
     local up_scheme = api_ctx.upstream_scheme
+    ngx_var.ctx_ref = ctxdump.stash_ngx_ctx()

Review comment:
       Swap these two lines.

##########
File path: apisix/cli/ngx_tpl.lua
##########
@@ -290,6 +293,17 @@ http {
                 apisix.http_control()
             }
         }
+
+        location = /50x.html {

Review comment:
       This should be a named location or internal location.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org