[GitHub] spark pull request: [SPARK-14636] Add minimum memory checks for dr...

[srowen <gi...@git.apache.org>]

Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/12395#discussion_r59742463
  
    --- Diff: core/src/main/scala/org/apache/spark/memory/StaticMemoryManager.scala ---
    @@ -104,6 +104,8 @@ private[spark] class StaticMemoryManager(
     
     private[spark] object StaticMemoryManager {
     
    +  private val MIN_MEMORY_BYTES = 450 * 1024 * 1024
    --- End diff --
    
    Should this not be connected to some common constant somewhere? Is 450MB a fixed value checked elsewhere? Failing more clearly is fine of course.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org