You are viewing a plain text version of this content. The canonical link for it is here.
Posted to codereview@trafodion.apache.org by amandamoran <gi...@git.apache.org> on 2015/08/08 00:15:36 UTC
[GitHub] incubator-trafodion pull request: [Trafodion-1433] [Trafodion-39] ...
GitHub user amandamoran opened a pull request:
https://github.com/apache/incubator-trafodion/pull/50
[Trafodion-1433] [Trafodion-39] [Trafodion -24] SUSE support, pdsh, scanenr
SUSE Support
Fixed pdsh errors for SUSE and when systems have banner messages
Scanner not called by default
Trafodion installation on nodes other than all Hadoop nodes
Bug fixes
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/amandamoran/incubator-trafodion suseInstaller
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-trafodion/pull/50.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #50
----
commit e0aa449f7068bde253883d60e4b86dae92f7ca63
Author: Amanda Moran <am...@apache.com>
Date: 2015-08-07T22:11:46Z
Larger changes to installer. TRAFODION 1433 39 24
SUSE Support
Installation on none Hadoop nodes
PDSH fixes
Bug fixes
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request: [Trafodion-1433] [Trafodion-39] ...
Posted by amandamoran <gi...@git.apache.org>.
Github user amandamoran commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/50#discussion_r36668287
--- Diff: install/installer/tools/ambari_setup ---
@@ -62,6 +65,9 @@ done
#Info for log file
sudo mkdir -p /var/log/trafodion
sudo chmod 777 /var/log/trafodion
+
+linuxInstalled=$(grep -cr SUSE /proc/version)
--- End diff --
Actually the grep -c returns a number value. So if SUSE is not installed, it will return a 0 not an empty string. I had to go test this out to make sure if does that (as I couldn't recall) and it does. I did change the variable name to be more clear/.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request: [Trafodion-1433] [Trafodion-39] ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-trafodion/pull/50
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request: [Trafodion-1433] [Trafodion-39] ...
Posted by arvind-narain <gi...@git.apache.org>.
Github user arvind-narain commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/50#discussion_r36902901
--- Diff: install/installer/trafodion_install ---
@@ -696,29 +625,30 @@ reservedTrafodionPorts="net.ipv4.ip_local_reserved_ports = ${trafodion_ports}"
for node in $NODE_LIST
do
- redhatSystem=$(ssh $node -n '/sbin/sysctl net.ipv4.ip_local_reserved_ports | wc -l')
+ redhatSystem=$(ssh -q -n $node '/sbin/sysctl net.ipv4.ip_local_reserved_ports | wc -l')
if [[ "$redhatSystem" -ge "1" ]]; then
- reserved_ports=$(ssh $node -n '/sbin/sysctl net.ipv4.ip_local_reserved_ports' | awk -F'=' '{print $2;}' | sed 's/^ //')
- ssh $node -n 'sudo chmod 777 /etc/sysctl.conf'
- ssh $node -n 'sudo sed -i '/net.ipv4.ip_local_reserved_ports""\=*/d' /etc/sysctl.conf'
+ reserved_ports=$(ssh -q -n $node '/sbin/sysctl net.ipv4.ip_local_reserved_ports' | awk -F'=' '{print $2;}' | sed 's/^ //')
+ ssh -q -n $node 'sudo chmod 777 /etc/sysctl.conf'
+ ssh -q -n $node 'sudo sed -i '/net.ipv4.ip_local_reserved_ports""\=*/d' /etc/sysctl.conf'
if [[ -z "${reserved_ports}" ]]; then
- ssh $node -n 'sudo echo "$reservedTrafodionPorts" >> /etc/sysctl.conf'
+ ssh -q -n $node "sudo echo "$reservedTrafodionPorts" >> /etc/sysctl.conf"
else
- ssh $node -n "sudo echo "$reservedTrafodionPorts","$reserved_ports" >> /etc/sysctl.conf"
+ ssh -q -n $node "sudo echo "$reservedTrafodionPorts","$reserved_ports" >> /etc/sysctl.conf"
fi
- ssh $node -n 'sudo chmod 644 /etc/sysctl.conf'
- ssh $node -n 'sudo /sbin/sysctl -p'
+ ssh -q -n $node 'sudo chmod 644 /etc/sysctl.conf'
+ ssh -q -n $node 'sudo /sbin/sysctl -p' 2>&1 > /dev/null
else
- echo "***ERROR: Unable to reserve DCS ports (${trafodion_ports})."
+ echo "***ERROR: Unable to reserve DCS ports (37800 and 40010)."
--- End diff --
Since the default ports changed (line 623) could you revert this change to utilize the trafodion_ports var ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request: [Trafodion-1433] [Trafodion-39] ...
Posted by DaveBirdsall <gi...@git.apache.org>.
Github user DaveBirdsall commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/50#discussion_r36582283
--- Diff: install/installer/tools/ambari_setup ---
@@ -62,6 +65,9 @@ done
#Info for log file
sudo mkdir -p /var/log/trafodion
sudo chmod 777 /var/log/trafodion
+
+linuxInstalled=$(grep -cr SUSE /proc/version)
--- End diff --
I assume $linuxInstalled is the empty string if it is not SUSE? (Which seems a little odd.) I wonder if a better name for the variable would be $SUSEInstalled?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request: [Trafodion-1433] [Trafodion-39] ...
Posted by amandamoran <gi...@git.apache.org>.
Github user amandamoran commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/50#discussion_r36905389
--- Diff: install/installer/trafodion_install ---
@@ -696,29 +625,30 @@ reservedTrafodionPorts="net.ipv4.ip_local_reserved_ports = ${trafodion_ports}"
for node in $NODE_LIST
do
- redhatSystem=$(ssh $node -n '/sbin/sysctl net.ipv4.ip_local_reserved_ports | wc -l')
+ redhatSystem=$(ssh -q -n $node '/sbin/sysctl net.ipv4.ip_local_reserved_ports | wc -l')
if [[ "$redhatSystem" -ge "1" ]]; then
- reserved_ports=$(ssh $node -n '/sbin/sysctl net.ipv4.ip_local_reserved_ports' | awk -F'=' '{print $2;}' | sed 's/^ //')
- ssh $node -n 'sudo chmod 777 /etc/sysctl.conf'
- ssh $node -n 'sudo sed -i '/net.ipv4.ip_local_reserved_ports""\=*/d' /etc/sysctl.conf'
+ reserved_ports=$(ssh -q -n $node '/sbin/sysctl net.ipv4.ip_local_reserved_ports' | awk -F'=' '{print $2;}' | sed 's/^ //')
+ ssh -q -n $node 'sudo chmod 777 /etc/sysctl.conf'
+ ssh -q -n $node 'sudo sed -i '/net.ipv4.ip_local_reserved_ports""\=*/d' /etc/sysctl.conf'
if [[ -z "${reserved_ports}" ]]; then
- ssh $node -n 'sudo echo "$reservedTrafodionPorts" >> /etc/sysctl.conf'
+ ssh -q -n $node "sudo echo "$reservedTrafodionPorts" >> /etc/sysctl.conf"
else
- ssh $node -n "sudo echo "$reservedTrafodionPorts","$reserved_ports" >> /etc/sysctl.conf"
+ ssh -q -n $node "sudo echo "$reservedTrafodionPorts","$reserved_ports" >> /etc/sysctl.conf"
fi
- ssh $node -n 'sudo chmod 644 /etc/sysctl.conf'
- ssh $node -n 'sudo /sbin/sysctl -p'
+ ssh -q -n $node 'sudo chmod 644 /etc/sysctl.conf'
+ ssh -q -n $node 'sudo /sbin/sysctl -p' 2>&1 > /dev/null
else
- echo "***ERROR: Unable to reserve DCS ports (${trafodion_ports})."
+ echo "***ERROR: Unable to reserve DCS ports (37800 and 40010)."
--- End diff --
Thanks for the find!
Fixed!
On Wed, Aug 12, 2015 at 12:29 PM, arvind-narain <no...@github.com>
wrote:
> In install/installer/trafodion_install
> <https://github.com/apache/incubator-trafodion/pull/50#discussion_r36902901>
> :
>
> > else
> > - echo "***ERROR: Unable to reserve DCS ports (${trafodion_ports})."
> > + echo "***ERROR: Unable to reserve DCS ports (37800 and 40010)."
>
> Since the default ports changed (line 623) could you revert this change to
> utilize the trafodion_ports var ?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/incubator-trafodion/pull/50/files#r36902901>.
>
--
Thanks,
Amanda Moran
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---