[jira] [Commented] (OAK-5301) Possible null dereference in MapRecord

["Michael Dürig (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OAK-5301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15748622#comment-15748622 ] 

Michael Dürig commented on OAK-5301:
------------------------------------

Fixing this will inevitably have an impact on the sort order. So we need to figure out what was the initial intent of making {{MapRecord}} instances {{Comparable}}. As just removing the implements clause doesn't break compilation I assume it is about order stability of {{MapRecord}} instances when put into some containers. However, this leaves me to wonder why the class doesn't implement {{equals()}} et. all., which would most likely as well be needed. 



> Possible null dereference in MapRecord
> --------------------------------------
>
>                 Key: OAK-5301
>                 URL: https://issues.apache.org/jira/browse/OAK-5301
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: segment-tar
>            Reporter: Michael Dürig
>              Labels: technical_debt
>             Fix For: 1.8
>
>
> {{MapEntry.compareTo()}} passes possibly {{null}} {{MapEntry.value}} to {{ComparisonChain.compare(Comparable, Comparable)}}, which does not accept {{null}} values. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)