[GitHub] [flink] wuchong commented on a diff in pull request #21522: [FLINK-29585][hive] Migrate TableSchema to Schema for Hive connector

["wuchong (via GitHub)" <gi...@apache.org>]

wuchong commented on code in PR #21522:
URL: https://github.com/apache/flink/pull/21522#discussion_r1134831904


##########
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/catalog/hive/HiveCatalog.java:
##########
@@ -763,7 +783,7 @@ CatalogBaseTable instantiateCatalogTable(Table hiveTable) {
             tableSchemaProps.putProperties(properties);
             // try to get table schema with both new and old (1.10) key, in order to support tables
             // created in old version
-            tableSchema =
+            TableSchema tableSchema =

Review Comment:
   `CatalogPropertiesUtil` is the alternative of `DescriptorProperties`. It should not be a major work to migrate. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org