You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by gu...@apache.org on 2023/10/31 07:47:54 UTC

(spark) branch branch-3.5 updated: [SPARK-45735][PYTHON][CONNECT][TESTS] Reenable CatalogTests without Spark Connect

This is an automated email from the ASF dual-hosted git repository.

gurwls223 pushed a commit to branch branch-3.5
in repository https://gitbox.apache.org/repos/asf/spark.git


The following commit(s) were added to refs/heads/branch-3.5 by this push:
     new 2a7e3fec1c8 [SPARK-45735][PYTHON][CONNECT][TESTS] Reenable CatalogTests without Spark Connect
2a7e3fec1c8 is described below

commit 2a7e3fec1c8e3867afb9bdecf7a02d6ba7b36f90
Author: Hyukjin Kwon <gu...@apache.org>
AuthorDate: Tue Oct 31 16:47:30 2023 +0900

    [SPARK-45735][PYTHON][CONNECT][TESTS] Reenable CatalogTests without Spark Connect
    
    ### What changes were proposed in this pull request?
    
    This PR is a followup of https://github.com/apache/spark/pull/39214 that restores the original Catalog tests in PySpark. That PR mistakenly disabled the tests without Spark Connect:
    
    https://github.com/apache/spark/blob/fc6a5cca06cf15c4a952cb56720f627efdba7cce/python/pyspark/sql/tests/test_catalog.py#L489
    
    ### Why are the changes needed?
    
    To restore the test coverage.
    
    ### Does this PR introduce _any_ user-facing change?
    
    No, test-only.
    
    ### How was this patch tested?
    
    Reenabled unittests.
    
    ### Was this patch authored or co-authored using generative AI tooling?
    
    No.
    
    Closes #43595 from HyukjinKwon/SPARK-45735.
    
    Authored-by: Hyukjin Kwon <gu...@apache.org>
    Signed-off-by: Hyukjin Kwon <gu...@apache.org>
    (cherry picked from commit 76d9a70932df97d8ea4cc6e279933dee29a88571)
    Signed-off-by: Hyukjin Kwon <gu...@apache.org>
---
 python/pyspark/sql/tests/test_catalog.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/python/pyspark/sql/tests/test_catalog.py b/python/pyspark/sql/tests/test_catalog.py
index cafffdc9ae8..b72172a402b 100644
--- a/python/pyspark/sql/tests/test_catalog.py
+++ b/python/pyspark/sql/tests/test_catalog.py
@@ -486,7 +486,7 @@ class CatalogTestsMixin:
                 self.assertEqual(spark.table("my_tab").count(), 0)
 
 
-class CatalogTests(ReusedSQLTestCase):
+class CatalogTests(CatalogTestsMixin, ReusedSQLTestCase):
     pass
 
 


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org