You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/12/27 11:25:15 UTC

[GitHub] [spark] HeartSaVioR opened a new pull request, #39245: [SPARK-41732][SQL][SS] Apply tree-pattern based pruning for the rule SessionWindowing

HeartSaVioR opened a new pull request, #39245:
URL: https://github.com/apache/spark/pull/39245

   ### What changes were proposed in this pull request?
   
   This PR proposes to apply tree-pattern based pruning for the rule SessionWindowing, to minimize the evaluation of rule with SessionWindow node.
   
   ### Why are the changes needed?
   
   The rule SessionWindowing is unnecessarily evaluated multiple times without proper pruning.
   
   ### Does this PR introduce _any_ user-facing change?
   
   No.
   
   ### How was this patch tested?
   
   Existing tests.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HeartSaVioR commented on pull request #39245: [SPARK-41732][SQL][SS] Apply tree-pattern based pruning for the rule SessionWindowing

Posted by GitBox <gi...@apache.org>.
HeartSaVioR commented on PR #39245:
URL: https://github.com/apache/spark/pull/39245#issuecomment-1366297616

   cc. @viirya as well


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HeartSaVioR commented on pull request #39245: [SPARK-41732][SQL][SS] Apply tree-pattern based pruning for the rule SessionWindowing

Posted by GitBox <gi...@apache.org>.
HeartSaVioR commented on PR #39245:
URL: https://github.com/apache/spark/pull/39245#issuecomment-1366349270

   It conflicts with branch-3.3 (probably 3.2 as well). I'll create a new PR for backport.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HeartSaVioR closed pull request #39245: [SPARK-41732][SQL][SS] Apply tree-pattern based pruning for the rule SessionWindowing

Posted by GitBox <gi...@apache.org>.
HeartSaVioR closed pull request #39245: [SPARK-41732][SQL][SS] Apply tree-pattern based pruning for the rule SessionWindowing
URL: https://github.com/apache/spark/pull/39245


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HeartSaVioR commented on pull request #39245: [SPARK-41732][SQL][SS] Apply tree-pattern based pruning for the rule SessionWindowing

Posted by GitBox <gi...@apache.org>.
HeartSaVioR commented on PR #39245:
URL: https://github.com/apache/spark/pull/39245#issuecomment-1365841672

   cc. @cloud-fan @rxin 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HeartSaVioR commented on pull request #39245: [SPARK-41732][SQL][SS] Apply tree-pattern based pruning for the rule SessionWindowing

Posted by GitBox <gi...@apache.org>.
HeartSaVioR commented on PR #39245:
URL: https://github.com/apache/spark/pull/39245#issuecomment-1366348248

   Thanks, merging to master/3.3/3.2!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HeartSaVioR commented on pull request #39245: [SPARK-41732][SQL][SS] Apply tree-pattern based pruning for the rule SessionWindowing

Posted by GitBox <gi...@apache.org>.
HeartSaVioR commented on PR #39245:
URL: https://github.com/apache/spark/pull/39245#issuecomment-1365842134

   We may need to port back to 3.3/3.2 version lines as well.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org