You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/10/22 05:17:31 UTC

[GitHub] [apisix] bisakhmondal opened a new pull request #5308: ci: curl with http2 support [centos 7]

bisakhmondal opened a new pull request #5308:
URL: https://github.com/apache/apisix/pull/5308


   ### What this PR does / why we need it:
   At present, centos 7 CI is using a version of curl that doesn't have the HTTP2 feature. So the PR recompiles curl from source by dynamically linking nghttp2 lib.  
   
   Relevant PR: https://github.com/apache/apisix/pull/5299
   ### Pre-submission checklist:
   
   * [x] Did you explain what problem does this PR solve? Or what new features have been added?
   * [ ] Have you added corresponding test cases?
   * [ ] Have you modified the corresponding document?
   * [x] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first**
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix] spacewander merged pull request #5308: ci: the test framework requires curl with http2 support

Posted by GitBox <gi...@apache.org>.
spacewander merged pull request #5308:
URL: https://github.com/apache/apisix/pull/5308


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix] bisakhmondal commented on pull request #5308: ci: curl with http2 support [centos 7]

Posted by GitBox <gi...@apache.org>.
bisakhmondal commented on pull request #5308:
URL: https://github.com/apache/apisix/pull/5308#issuecomment-949299009


   Main reason : curl with HTTP2 [Done]
   link: https://github.com/apache/apisix/runs/3972136785?check_suite_focus=true#step:8:2516
   Now removing the debug line.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix] bisakhmondal edited a comment on pull request #5308: ci: curl with http2 support [centos 7]

Posted by GitBox <gi...@apache.org>.
bisakhmondal edited a comment on pull request #5308:
URL: https://github.com/apache/apisix/pull/5308#issuecomment-949299009


   Main goal : curl with HTTP2 [Done]
   link: https://github.com/apache/apisix/runs/3972136785?check_suite_focus=true#step:8:2516
   Now removing the debug line.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix] bisakhmondal commented on a change in pull request #5308: ci: curl with http2 support [centos 7]

Posted by GitBox <gi...@apache.org>.
bisakhmondal commented on a change in pull request #5308:
URL: https://github.com/apache/apisix/pull/5308#discussion_r734305064



##########
File path: ci/centos7-ci.sh
##########
@@ -23,12 +23,29 @@ install_dependencies() {
 
     # install development tools
     yum install -y wget tar gcc automake autoconf libtool make unzip \
-        curl git which sudo openldap-devel
+        git which sudo openldap-devel libev libev-devel zlib zlib-devel openssl openssl-devel
 
     # install openresty to make apisix's rpm test work
     yum install -y yum-utils && yum-config-manager --add-repo https://openresty.org/package/centos/openresty.repo
     yum install -y openresty openresty-debug openresty-openssl111-debug-devel pcre pcre-devel
 
+    # build curl with http2

Review comment:
       Thanks for the reference. Great work by the repo owner!!




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix] spacewander commented on a change in pull request #5308: ci: curl with http2 support [centos 7]

Posted by GitBox <gi...@apache.org>.
spacewander commented on a change in pull request #5308:
URL: https://github.com/apache/apisix/pull/5308#discussion_r734264019



##########
File path: ci/centos7-ci.sh
##########
@@ -23,12 +23,29 @@ install_dependencies() {
 
     # install development tools
     yum install -y wget tar gcc automake autoconf libtool make unzip \
-        curl git which sudo openldap-devel
+        git which sudo openldap-devel libev libev-devel zlib zlib-devel openssl openssl-devel
 
     # install openresty to make apisix's rpm test work
     yum install -y yum-utils && yum-config-manager --add-repo https://openresty.org/package/centos/openresty.repo
     yum install -y openresty openresty-debug openresty-openssl111-debug-devel pcre pcre-devel
 
+    # build curl with http2

Review comment:
       We can download it directly? https://github.com/moparisthebest/static-curl




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org