You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "Hudson (JIRA)" <ji...@apache.org> on 2013/01/09 11:27:27 UTC

[jira] [Commented] (HIVE-3204) Windows: Fix the unit tests which contains “!” commands (Unix shell commands)

    [ https://issues.apache.org/jira/browse/HIVE-3204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13548017#comment-13548017 ] 

Hudson commented on HIVE-3204:
------------------------------

Integrated in Hive-trunk-hadoop2 #54 (See [https://builds.apache.org/job/Hive-trunk-hadoop2/54/])
    HIVE-3204 :Windows: Fix the unit tests which contains cmd commands (Unix shell commands) (Kanna Karanam via Ashutosh Chauhan) (Revision 1360825)

     Result = ABORTED
hashutosh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1360825
Files : 
* /hive/trunk/ql/src/test/queries/clientnegative/exim_00_unsupported_schema.q
* /hive/trunk/ql/src/test/queries/clientnegative/exim_01_nonpart_over_loaded.q
* /hive/trunk/ql/src/test/queries/clientnegative/exim_02_all_part_over_overlap.q
* /hive/trunk/ql/src/test/queries/clientnegative/exim_03_nonpart_noncompat_colschema.q
* /hive/trunk/ql/src/test/queries/clientnegative/exim_04_nonpart_noncompat_colnumber.q
* /hive/trunk/ql/src/test/queries/clientnegative/exim_05_nonpart_noncompat_coltype.q
* /hive/trunk/ql/src/test/queries/clientnegative/exim_06_nonpart_noncompat_storage.q
* /hive/trunk/ql/src/test/queries/clientnegative/exim_07_nonpart_noncompat_ifof.q
* /hive/trunk/ql/src/test/queries/clientnegative/exim_08_nonpart_noncompat_serde.q
* /hive/trunk/ql/src/test/queries/clientnegative/exim_09_nonpart_noncompat_serdeparam.q
* /hive/trunk/ql/src/test/queries/clientnegative/exim_10_nonpart_noncompat_bucketing.q
* /hive/trunk/ql/src/test/queries/clientnegative/exim_11_nonpart_noncompat_sorting.q
* /hive/trunk/ql/src/test/queries/clientnegative/exim_13_nonnative_import.q
* /hive/trunk/ql/src/test/queries/clientnegative/exim_14_nonpart_part.q
* /hive/trunk/ql/src/test/queries/clientnegative/exim_15_part_nonpart.q
* /hive/trunk/ql/src/test/queries/clientnegative/exim_16_part_noncompat_schema.q
* /hive/trunk/ql/src/test/queries/clientnegative/exim_17_part_spec_underspec.q
* /hive/trunk/ql/src/test/queries/clientnegative/exim_18_part_spec_missing.q
* /hive/trunk/ql/src/test/queries/clientnegative/exim_19_external_over_existing.q
* /hive/trunk/ql/src/test/queries/clientnegative/exim_20_managed_location_over_existing.q
* /hive/trunk/ql/src/test/queries/clientnegative/exim_21_part_managed_external.q
* /hive/trunk/ql/src/test/queries/clientnegative/exim_22_export_authfail.q
* /hive/trunk/ql/src/test/queries/clientnegative/exim_23_import_exist_authfail.q
* /hive/trunk/ql/src/test/queries/clientnegative/exim_24_import_part_authfail.q
* /hive/trunk/ql/src/test/queries/clientnegative/exim_25_import_nonexist_authfail.q
* /hive/trunk/ql/src/test/queries/clientpositive/exim_00_nonpart_empty.q
* /hive/trunk/ql/src/test/queries/clientpositive/exim_01_nonpart.q
* /hive/trunk/ql/src/test/queries/clientpositive/exim_02_00_part_empty.q
* /hive/trunk/ql/src/test/queries/clientpositive/exim_02_part.q
* /hive/trunk/ql/src/test/queries/clientpositive/exim_03_nonpart_over_compat.q
* /hive/trunk/ql/src/test/queries/clientpositive/exim_04_all_part.q
* /hive/trunk/ql/src/test/queries/clientpositive/exim_04_evolved_parts.q
* /hive/trunk/ql/src/test/queries/clientpositive/exim_05_some_part.q
* /hive/trunk/ql/src/test/queries/clientpositive/exim_06_one_part.q
* /hive/trunk/ql/src/test/queries/clientpositive/exim_07_all_part_over_nonoverlap.q
* /hive/trunk/ql/src/test/queries/clientpositive/exim_08_nonpart_rename.q
* /hive/trunk/ql/src/test/queries/clientpositive/exim_09_part_spec_nonoverlap.q
* /hive/trunk/ql/src/test/queries/clientpositive/exim_10_external_managed.q
* /hive/trunk/ql/src/test/queries/clientpositive/exim_11_managed_external.q
* /hive/trunk/ql/src/test/queries/clientpositive/exim_12_external_location.q
* /hive/trunk/ql/src/test/queries/clientpositive/exim_13_managed_location.q
* /hive/trunk/ql/src/test/queries/clientpositive/exim_14_managed_location_over_existing.q
* /hive/trunk/ql/src/test/queries/clientpositive/exim_15_external_part.q
* /hive/trunk/ql/src/test/queries/clientpositive/exim_16_part_external.q
* /hive/trunk/ql/src/test/queries/clientpositive/exim_17_part_managed.q
* /hive/trunk/ql/src/test/queries/clientpositive/exim_18_part_external.q
* /hive/trunk/ql/src/test/queries/clientpositive/exim_19_00_part_external_location.q
* /hive/trunk/ql/src/test/queries/clientpositive/exim_19_part_external_location.q
* /hive/trunk/ql/src/test/queries/clientpositive/exim_20_part_managed_location.q
* /hive/trunk/ql/src/test/queries/clientpositive/exim_21_export_authsuccess.q
* /hive/trunk/ql/src/test/queries/clientpositive/exim_22_import_exist_authsuccess.q
* /hive/trunk/ql/src/test/queries/clientpositive/exim_23_import_part_authsuccess.q
* /hive/trunk/ql/src/test/queries/clientpositive/exim_24_import_nonexist_authsuccess.q
* /hive/trunk/ql/src/test/queries/clientpositive/insertexternal1.q
* /hive/trunk/ql/src/test/queries/clientpositive/multi_insert.q
* /hive/trunk/ql/src/test/queries/clientpositive/multi_insert_move_tasks_share_dependencies.q
* /hive/trunk/ql/src/test/results/clientnegative/exim_00_unsupported_schema.q.out
* /hive/trunk/ql/src/test/results/clientnegative/exim_01_nonpart_over_loaded.q.out
* /hive/trunk/ql/src/test/results/clientnegative/exim_02_all_part_over_overlap.q.out
* /hive/trunk/ql/src/test/results/clientnegative/exim_03_nonpart_noncompat_colschema.q.out
* /hive/trunk/ql/src/test/results/clientnegative/exim_04_nonpart_noncompat_colnumber.q.out
* /hive/trunk/ql/src/test/results/clientnegative/exim_05_nonpart_noncompat_coltype.q.out
* /hive/trunk/ql/src/test/results/clientnegative/exim_06_nonpart_noncompat_storage.q.out
* /hive/trunk/ql/src/test/results/clientnegative/exim_07_nonpart_noncompat_ifof.q.out
* /hive/trunk/ql/src/test/results/clientnegative/exim_08_nonpart_noncompat_serde.q.out
* /hive/trunk/ql/src/test/results/clientnegative/exim_09_nonpart_noncompat_serdeparam.q.out
* /hive/trunk/ql/src/test/results/clientnegative/exim_10_nonpart_noncompat_bucketing.q.out
* /hive/trunk/ql/src/test/results/clientnegative/exim_11_nonpart_noncompat_sorting.q.out
* /hive/trunk/ql/src/test/results/clientnegative/exim_13_nonnative_import.q.out
* /hive/trunk/ql/src/test/results/clientnegative/exim_14_nonpart_part.q.out
* /hive/trunk/ql/src/test/results/clientnegative/exim_15_part_nonpart.q.out
* /hive/trunk/ql/src/test/results/clientnegative/exim_16_part_noncompat_schema.q.out
* /hive/trunk/ql/src/test/results/clientnegative/exim_17_part_spec_underspec.q.out
* /hive/trunk/ql/src/test/results/clientnegative/exim_18_part_spec_missing.q.out
* /hive/trunk/ql/src/test/results/clientnegative/exim_19_external_over_existing.q.out
* /hive/trunk/ql/src/test/results/clientnegative/exim_20_managed_location_over_existing.q.out
* /hive/trunk/ql/src/test/results/clientnegative/exim_21_part_managed_external.q.out
* /hive/trunk/ql/src/test/results/clientnegative/exim_22_export_authfail.q.out
* /hive/trunk/ql/src/test/results/clientnegative/exim_23_import_exist_authfail.q.out
* /hive/trunk/ql/src/test/results/clientnegative/exim_24_import_part_authfail.q.out
* /hive/trunk/ql/src/test/results/clientnegative/exim_25_import_nonexist_authfail.q.out
* /hive/trunk/ql/src/test/results/clientpositive/exim_00_nonpart_empty.q.out
* /hive/trunk/ql/src/test/results/clientpositive/exim_01_nonpart.q.out
* /hive/trunk/ql/src/test/results/clientpositive/exim_02_00_part_empty.q.out
* /hive/trunk/ql/src/test/results/clientpositive/exim_02_part.q.out
* /hive/trunk/ql/src/test/results/clientpositive/exim_03_nonpart_over_compat.q.out
* /hive/trunk/ql/src/test/results/clientpositive/exim_04_all_part.q.out
* /hive/trunk/ql/src/test/results/clientpositive/exim_04_evolved_parts.q.out
* /hive/trunk/ql/src/test/results/clientpositive/exim_05_some_part.q.out
* /hive/trunk/ql/src/test/results/clientpositive/exim_06_one_part.q.out
* /hive/trunk/ql/src/test/results/clientpositive/exim_07_all_part_over_nonoverlap.q.out
* /hive/trunk/ql/src/test/results/clientpositive/exim_08_nonpart_rename.q.out
* /hive/trunk/ql/src/test/results/clientpositive/exim_09_part_spec_nonoverlap.q.out
* /hive/trunk/ql/src/test/results/clientpositive/exim_10_external_managed.q.out
* /hive/trunk/ql/src/test/results/clientpositive/exim_11_managed_external.q.out
* /hive/trunk/ql/src/test/results/clientpositive/exim_12_external_location.q.out
* /hive/trunk/ql/src/test/results/clientpositive/exim_13_managed_location.q.out
* /hive/trunk/ql/src/test/results/clientpositive/exim_14_managed_location_over_existing.q.out
* /hive/trunk/ql/src/test/results/clientpositive/exim_15_external_part.q.out
* /hive/trunk/ql/src/test/results/clientpositive/exim_16_part_external.q.out
* /hive/trunk/ql/src/test/results/clientpositive/exim_17_part_managed.q.out
* /hive/trunk/ql/src/test/results/clientpositive/exim_18_part_external.q.out
* /hive/trunk/ql/src/test/results/clientpositive/exim_19_00_part_external_location.q.out
* /hive/trunk/ql/src/test/results/clientpositive/exim_19_part_external_location.q.out
* /hive/trunk/ql/src/test/results/clientpositive/exim_20_part_managed_location.q.out
* /hive/trunk/ql/src/test/results/clientpositive/exim_21_export_authsuccess.q.out
* /hive/trunk/ql/src/test/results/clientpositive/exim_22_import_exist_authsuccess.q.out
* /hive/trunk/ql/src/test/results/clientpositive/exim_23_import_part_authsuccess.q.out
* /hive/trunk/ql/src/test/results/clientpositive/exim_24_import_nonexist_authsuccess.q.out
* /hive/trunk/ql/src/test/results/clientpositive/insertexternal1.q.out
* /hive/trunk/ql/src/test/results/clientpositive/multi_insert.q.out
* /hive/trunk/ql/src/test/results/clientpositive/multi_insert_move_tasks_share_dependencies.q.out

                
> Windows: Fix the unit tests which contains “!<cmd>” commands (Unix shell commands)
> ----------------------------------------------------------------------------------
>
>                 Key: HIVE-3204
>                 URL: https://issues.apache.org/jira/browse/HIVE-3204
>             Project: Hive
>          Issue Type: Sub-task
>          Components: Tests, Windows
>    Affects Versions: 0.10.0
>            Reporter: Kanna Karanam
>            Assignee: Kanna Karanam
>             Fix For: 0.10.0
>
>         Attachments: HIVE-3204.1.patch.txt, HIVE-3204.2.patch.txt
>
>
> Possible solution 1: (Preferred one)
> !<Unix cmd | Windows cmd> => Keeping the same syntax. Hive uses Java runtime to launch the shell command  so any attempt to run windows commands on Unix will fail and vice versa.
> To deal with unit tests. Unix commands in each .q file will be modified as shown below. I will filter out the !commands which can’t be run on the current .
> Original entry in.q file:
> !rm -rf ../build/ql/test/data/exports/exim_department;
> It will be replaced with the following entries.
> UNIX::!rm -rf ../build/ql/test/data/exports/exim_department;
> WINDOWS::!del ../build/ql/test/data/exports/exim_department
> Possible solution 2:
> Provide a Shell UDF library(JAVA Based code)to support platform independent shell functionality
> Cons – 
> 1) Difficult to provide full shell functionality
> 2) Takes long time
> 3) Difficult to manage

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira