You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/03/30 18:05:08 UTC
[GitHub] [airflow] andrewgodwin opened a new pull request #15098: Fixed deprecated code example in Concepts doc
andrewgodwin opened a new pull request #15098:
URL: https://github.com/apache/airflow/pull/15098
This document used the now-deprecated import for "task"; this updates it to come from `airflow.decorators` so it won't raise a DeprecationWarning if copied and used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #15098: Fixed deprecated code example in Concepts doc
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #15098:
URL: https://github.com/apache/airflow/pull/15098#issuecomment-810535127
Awesome work, congrats on your first merged pull request!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #15098: Fixed deprecated code example in Concepts doc
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #15098:
URL: https://github.com/apache/airflow/pull/15098#issuecomment-810466624
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, pylint and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/master/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/master/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/master/BREEZE.rst) for testing locally, itโs a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better ๐.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] XD-DENG commented on pull request #15098: Fixed deprecated code example in Concepts doc
Posted by GitBox <gi...@apache.org>.
XD-DENG commented on pull request #15098:
URL: https://github.com/apache/airflow/pull/15098#issuecomment-810532298
> Yup, I plan to fix the tests once this is in - they're code changes so I need to get more stuff prepped on my end!
That's cool! Thanks for that.
I will merge this one once CI passes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] XD-DENG merged pull request #15098: Fixed deprecated code example in Concepts doc
Posted by GitBox <gi...@apache.org>.
XD-DENG merged pull request #15098:
URL: https://github.com/apache/airflow/pull/15098
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] andrewgodwin commented on pull request #15098: Fixed deprecated code example in Concepts doc
Posted by GitBox <gi...@apache.org>.
andrewgodwin commented on pull request #15098:
URL: https://github.com/apache/airflow/pull/15098#issuecomment-810531307
Yup, I plan to fix the tests once this is in - they're code changes so I need to get more stuff prepped on my end!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] XD-DENG commented on pull request #15098: Fixed deprecated code example in Concepts doc
Posted by GitBox <gi...@apache.org>.
XD-DENG commented on pull request #15098:
URL: https://github.com/apache/airflow/pull/15098#issuecomment-810514291
Hi @andrewgodwin , this issue also exists in some tests, for example https://github.com/apache/airflow/blob/ecb1365b15df04562adbc840a2a5df80e90835ef/tests/models/test_dagparam.py#L23
Are you open to help fix them as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org