You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by hmcc <gi...@git.apache.org> on 2017/12/20 10:31:15 UTC

[GitHub] storm pull request #2474: STORM-2862: More flexible logging in multilang

GitHub user hmcc opened a pull request:

    https://github.com/apache/storm/pull/2474

    STORM-2862: More flexible logging in multilang

    Connected to https://issues.apache.org/jira/browse/STORM-2862.
    Put contextual information in the ThreadContext for multilang logging.
    
    I've updated the Python and Ruby resources in multilang, but not the JS one. That's because the JS one is written to support variable arguments (probably because of [STORM-2435](https://issues.apache.org/jira/browse/STORM-2435)). I can't see a way to support optional IDs without breaking the current behaviour.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/hmcc/storm STORM-2862-1.x

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/storm/pull/2474.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2474
    
----
commit 92511b9ccf81c23476952aaf61e31556c41920b2
Author: Heather McCartney <he...@...>
Date:   2017-12-20T10:14:53Z

    Put contextual information in the ThreadContext for multilang logging.

----


---

[GitHub] storm issue #2474: STORM-2862: More flexible logging in multilang

Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:

    https://github.com/apache/storm/pull/2474
  
    +1 prior to merge. (It's kind of porting back.)


---

[GitHub] storm pull request #2474: STORM-2862: More flexible logging in multilang

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/storm/pull/2474


---