You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/08/23 20:11:02 UTC

[GitHub] [incubator-nuttx] v01d opened a new pull request #1633: Add support for Sparkfun NRF52832 Breakout board

v01d opened a new pull request #1633:
URL: https://github.com/apache/incubator-nuttx/pull/1633


   ## Summary
   
   Add (basic) support for this board
   
   ## Impact
   
   New board
   
   ## Testing
   
   Boots correctly, gives nsh prompt via serial.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] Ouss4 commented on pull request #1633: Add support for Sparkfun NRF52832 Breakout board

Posted by GitBox <gi...@apache.org>.
Ouss4 commented on pull request #1633:
URL: https://github.com/apache/incubator-nuttx/pull/1633#issuecomment-678838465


   BTW @v01d, the files have BSD licenses, that needs to be changed to Apache.
   I see some simple files with a certain Janne as author, similar files exist from Greg or Mateusz who both have ICLAs.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] v01d commented on pull request #1633: Add support for Sparkfun NRF52832 Breakout board

Posted by GitBox <gi...@apache.org>.
v01d commented on pull request #1633:
URL: https://github.com/apache/incubator-nuttx/pull/1633#issuecomment-678855000


   Ok, I recreated files from Apache licensed similar files and remove those copyrighted by Janne (userleds and buttons).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] v01d commented on pull request #1633: Add support for Sparkfun NRF52832 Breakout board

Posted by GitBox <gi...@apache.org>.
v01d commented on pull request #1633:
URL: https://github.com/apache/incubator-nuttx/pull/1633#issuecomment-678824084


   The CI is failing but I don't really understand the problem. Anyone could take a look?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] Ouss4 merged pull request #1633: Add support for Sparkfun NRF52832 Breakout board

Posted by GitBox <gi...@apache.org>.
Ouss4 merged pull request #1633:
URL: https://github.com/apache/incubator-nuttx/pull/1633


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] v01d commented on pull request #1633: Add support for Sparkfun NRF52832 Breakout board

Posted by GitBox <gi...@apache.org>.
v01d commented on pull request #1633:
URL: https://github.com/apache/incubator-nuttx/pull/1633#issuecomment-678847687


   Sorry I missed it, this was from a fork I only recently rebased to master. I used one of the other nrf52 boards as a base.
   I will update the headers and push again.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] v01d commented on pull request #1633: Add support for Sparkfun NRF52832 Breakout board

Posted by GitBox <gi...@apache.org>.
v01d commented on pull request #1633:
URL: https://github.com/apache/incubator-nuttx/pull/1633#issuecomment-678849159


   BTW, it seems Janne Rosberg is @jrosberg. He does not appear to be active on GitHub for some time but hopefully he gets notified and we can sort the licensing of existing files.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] v01d edited a comment on pull request #1633: Add support for Sparkfun NRF52832 Breakout board

Posted by GitBox <gi...@apache.org>.
v01d edited a comment on pull request #1633:
URL: https://github.com/apache/incubator-nuttx/pull/1633#issuecomment-678855000


   Ok, I recreated files from Apache licensed similar files and remove those copyrighted by Janne (userleds and buttons).
   
   EDIT: not that check step fails because it does not handle file deletions across commits 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] Ouss4 commented on pull request #1633: Add support for Sparkfun NRF52832 Breakout board

Posted by GitBox <gi...@apache.org>.
Ouss4 commented on pull request #1633:
URL: https://github.com/apache/incubator-nuttx/pull/1633#issuecomment-678824813


   > The CI is failing but I don't really understand the problem. Anyone could take a look?
   
   You need to run ./tools/refresh.sh --silent nrf52832-sparkfun:nsh to update the defconfig, it's using some old values.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org