You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/01/12 16:23:02 UTC

[GitHub] [kafka] chia7712 commented on a change in pull request #9857: KAFKA-12172 Migrate streams:examples module to JUnit 5

chia7712 commented on a change in pull request #9857:
URL: https://github.com/apache/kafka/pull/9857#discussion_r555901224



##########
File path: build.gradle
##########
@@ -241,7 +241,7 @@ subprojects {
     }
   }
 
-  def shouldUseJUnit5 = ["tools", "raft", "log4j-appender"].contains(it.project.name)
+  def shouldUseJUnit5 = ["tools", "raft", "log4j-appender", "examples"].contains(it.project.name)

Review comment:
       > Is "examples" the right name? Given that you converted streams-examples?
   
   gradle uses the folder name as project name. It can be override if we want to make more readable naming. All project names are shown below.
   
   ```
   clients
   connect
   core
   examples
   generator
   jmh-benchmarks
   log4j-appender
   raft
   streams
   tools
   api
   basic-auth-extension
   file
   json
   mirror
   mirror-client
   runtime
   transforms
   examples
   streams-scala
   test-utils
   upgrade-system-tests-0100
   upgrade-system-tests-0101
   upgrade-system-tests-0102
   upgrade-system-tests-0110
   upgrade-system-tests-10
   upgrade-system-tests-11
   upgrade-system-tests-20
   upgrade-system-tests-21
   upgrade-system-tests-22
   upgrade-system-tests-23
   upgrade-system-tests-24
   upgrade-system-tests-25
   upgrade-system-tests-26
   upgrade-system-tests-27
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org