You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "hainenber (via GitHub)" <gi...@apache.org> on 2025/01/05 05:26:38 UTC
[PR] chore: refactor for uplifting react-error-boundary to v5 [superset]
hainenber opened a new pull request, #31711:
URL: https://github.com/apache/superset/pull/31711
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
chore: refactor for uplifting react-error-boundary to v5
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
The `componentStack` attribute in `FallbackProps` type has been removed in [v3](https://github.com/bvaughn/react-error-boundary/releases/tag/v3.0.0) but since there's a need to render the stack trace as a React component, I decided to extend the type with removed attribute to avoid breaking backwards.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
CI and `npm run build` passed with colors.
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore: refactor for uplifting react-error-boundary to v5 [superset]
Posted by "hainenber (via GitHub)" <gi...@apache.org>.
hainenber commented on PR #31711:
URL: https://github.com/apache/superset/pull/31711#issuecomment-2619085055
Close this PR as the `react-error-boundary` uplift is done in [PR upgrading to React v17](https://github.com/apache/superset/pull/31961)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore: refactor for uplifting react-error-boundary to v5 [superset]
Posted by "hainenber (via GitHub)" <gi...@apache.org>.
hainenber closed pull request #31711: chore: refactor for uplifting react-error-boundary to v5
URL: https://github.com/apache/superset/pull/31711
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org