You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Neil Conway <ne...@gmail.com> on 2016/12/05 17:23:41 UTC

Re: Review Request 54311: Fixed whitespace, code style in Network::Address.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54311/
-----------------------------------------------------------

(Updated Dec. 5, 2016, 5:23 p.m.)


Review request for mesos and Alexander Rukletsov.


Changes
-------

Rebase.


Summary (updated)
-----------------

Fixed whitespace, code style in Network::Address.


Repository: mesos


Description (updated)
-------

Fixed whitespace, code style in Network::Address.


Diffs (updated)
-----

  3rdparty/libprocess/include/process/address.hpp a2eeb390db360b9441a19315ee697bfe9b138cf8 

Diff: https://reviews.apache.org/r/54311/diff/


Testing
-------

`make check`


Thanks,

Neil Conway


Re: Review Request 54311: Fixed whitespace, code style in Network::Address.

Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54311/#review158017
-----------------------------------------------------------


Ship it!





3rdparty/libprocess/include/process/address.hpp (lines 365 - 366)
<https://reviews.apache.org/r/54311/#comment228672>

    I'll preserve `// __WINDOWS__` to preserve local consistency.


- Alexander Rukletsov


On Dec. 5, 2016, 5:23 p.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54311/
> -----------------------------------------------------------
> 
> (Updated Dec. 5, 2016, 5:23 p.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fixed whitespace, code style in Network::Address.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/address.hpp a2eeb390db360b9441a19315ee697bfe9b138cf8 
> 
> Diff: https://reviews.apache.org/r/54311/diff/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Neil Conway
> 
>