[GitHub] [spark] MaxGekk commented on a diff in pull request #38896: [WIP][SQL] Replace `require()` by an internal error in catalyst

[GitBox <gi...@apache.org>]

MaxGekk commented on code in PR #38896:
URL: https://github.com/apache/spark/pull/38896#discussion_r1038778637


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/decimalExpressions.scala:
##########
@@ -224,7 +224,6 @@ case class DecimalAddNoOverflowCheck(
     left: Expression,
     right: Expression,
     override val dataType: DataType) extends BinaryOperator {
-  require(dataType.isInstanceOf[DecimalType])

Review Comment:
   This is not needed since we require the type below in the method `inputType()`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org