[GitHub] [linkis] casionone commented on a diff in pull request #4125: Fixed some docs error and upgraded netty-all

["casionone (via GitHub)" <gi...@apache.org>]

casionone commented on code in PR #4125:
URL: https://github.com/apache/linkis/pull/4125#discussion_r1089780082


##########
pom.xml:
##########
@@ -364,6 +364,14 @@
         <type>pom</type>
         <scope>import</scope>
       </dependency>
+      <dependency>

Review Comment:
   netty-bom  has been seted in parent pom.xml 
   and using in linkis-commons/linkis-module/pom.xml with 
   ```
       <dependency>
         <groupId>io.netty</groupId>
         <artifactId>netty-all</artifactId>
       </dependency>
   ```
   There is no need to add this configuration



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org