Re: [PR] feat: add DelRange API to go-client [incubator-pegasus]

["acelyc111 (via GitHub)" <gi...@apache.org>]

acelyc111 commented on code in PR #2199:
URL: https://github.com/apache/incubator-pegasus/pull/2199#discussion_r1977617482


##########
go-client/pegasus/table_connector.go:
##########
@@ -143,6 +162,16 @@ type TableConnector interface {
 	// `sortKeys[i]` : CAN'T be nil but CAN be empty.
 	MultiDel(ctx context.Context, hashKey []byte, sortKeys [][]byte) error
 
+	// DelRange /DelRangeOpt deletes the multiple entries under `hashKey`, between range (`startSortKey`, `stopSortKey`),
+	// atomically in one operation.
+	// DelRange is identical to DelRangeOpt except that the former uses DefaultDelRangeOptions as `options`.
+	//
+	// startSortKey: nil or len(startSortKey) == 0 means start from begin.
+	// stopSortKey: nil or len(stopSortKey) == 0 means stop to end.

Review Comment:
   Could you please explain what is 'begin' and 'end', add these to the comments, it's helpful for users, thanks!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org