You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by kavinkumarks <gi...@git.apache.org> on 2016/09/29 12:17:17 UTC
[GitHub] zeppelin pull request #1473: [ZEPPELIN-908] Apply new mechanism to Cassandra...
GitHub user kavinkumarks opened a pull request:
https://github.com/apache/zeppelin/pull/1473
[ZEPPELIN-908] Apply new mechanism to CassandraInterpreter
### What is this PR for?
This handles replacing the registration of interpreter with static block by the interpreter-setting.json file
### What type of PR is it?
Sub-ask
### Todos
NA
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-908
### How should this be tested?
* There shouldn't be any warning like below on starting the server
`INFO [2016-09-29 00:25:46,247] ({main} CassandraInterpreter.java[<clinit>]:155) - Bootstrapping Cassandra Interpreter
WARN [2016-09-29 00:25:46,250] ({main} Interpreter.java[register]:347) - Static initialization is deprecated for interpreter cassandra, You should change it to use interpreter-setting.json in your jar or interpreter/{interpreter}/interpreter-setting.json
INFO [2016-09-29 00:25:46,250] ({main} InterpreterFactory.java[init]:204) - Interpreter cassandra.cassandra found. class=org.apache.zeppelin.cassandra.CassandraInterpreter`
* And ensure that the cassandra related paragraphs run without any error
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kavinkumarks/zeppelin zeppelin-908-register-cassandra-interpreter
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1473.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1473
----
commit d1fe58604f0b0b31438743e46846c6fe429360bc
Author: Kavin <ka...@imaginea.com>
Date: 2016-09-29T12:02:03Z
Removed static initialization of interpreter registration with the
interpreter-setting.json file.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1473: [ZEPPELIN-908] Apply new mechanism to Cassandra...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1473
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1473: [ZEPPELIN-908] Apply new mechanism to Cassandra...
Posted by kavinkumarks <gi...@git.apache.org>.
Github user kavinkumarks closed the pull request at:
https://github.com/apache/zeppelin/pull/1473
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1473: [ZEPPELIN-908] Apply new mechanism to Cassandra...
Posted by kavinkumarks <gi...@git.apache.org>.
GitHub user kavinkumarks reopened a pull request:
https://github.com/apache/zeppelin/pull/1473
[ZEPPELIN-908] Apply new mechanism to CassandraInterpreter
### What is this PR for?
This handles replacing the registration of interpreter with static block by the interpreter-setting.json file
### What type of PR is it?
Sub-ask
### Todos
NA
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-908
### How should this be tested?
* There shouldn't be any warning like below on starting the server
`INFO [2016-09-29 00:25:46,247] ({main} CassandraInterpreter.java[<clinit>]:155) - Bootstrapping Cassandra Interpreter
WARN [2016-09-29 00:25:46,250] ({main} Interpreter.java[register]:347) - Static initialization is deprecated for interpreter cassandra, You should change it to use interpreter-setting.json in your jar or interpreter/{interpreter}/interpreter-setting.json
INFO [2016-09-29 00:25:46,250] ({main} InterpreterFactory.java[init]:204) - Interpreter cassandra.cassandra found. class=org.apache.zeppelin.cassandra.CassandraInterpreter`
* And ensure that the cassandra related paragraphs run without any error
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kavinkumarks/zeppelin zeppelin-908-register-cassandra-interpreter
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1473.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1473
----
commit d1fe58604f0b0b31438743e46846c6fe429360bc
Author: Kavin <ka...@imaginea.com>
Date: 2016-09-29T12:02:03Z
Removed static initialization of interpreter registration with the
interpreter-setting.json file.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1473: [ZEPPELIN-908] Apply new mechanism to CassandraInterpr...
Posted by kavinkumarks <gi...@git.apache.org>.
Github user kavinkumarks commented on the issue:
https://github.com/apache/zeppelin/pull/1473
Thanks @doanduyhai for reviewing it and the CI build is green!
- Kavin
MailTo: kavin.kumar@imaginea.com
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1473: [ZEPPELIN-908] Apply new mechanism to CassandraInterpr...
Posted by doanduyhai <gi...@git.apache.org>.
Github user doanduyhai commented on the issue:
https://github.com/apache/zeppelin/pull/1473
Thank you @jongyoul it works like a charm \U0001f44d
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1473: [ZEPPELIN-908] Apply new mechanism to CassandraInterpr...
Posted by kavinkumarks <gi...@git.apache.org>.
Github user kavinkumarks commented on the issue:
https://github.com/apache/zeppelin/pull/1473
Thanks @doanduyhai and @jongyoul
Kavin
MailTo: kavin.kumar@imaginea.com
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1473: [ZEPPELIN-908] Apply new mechanism to CassandraInterpr...
Posted by kavinkumarks <gi...@git.apache.org>.
Github user kavinkumarks commented on the issue:
https://github.com/apache/zeppelin/pull/1473
Reopening to trigger the CI build.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1473: [ZEPPELIN-908] Apply new mechanism to CassandraInterpr...
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1473
@doanduyhai Do you try to do it via https://cwiki.apache.org/confluence/display/ZEPPELIN/Committer+Guide ? AFAIK, there's no more step except creating account.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1473: [ZEPPELIN-908] Apply new mechanism to CassandraInterpr...
Posted by doanduyhai <gi...@git.apache.org>.
Github user doanduyhai commented on the issue:
https://github.com/apache/zeppelin/pull/1473
The code looks good to me
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1473: [ZEPPELIN-908] Apply new mechanism to CassandraInterpr...
Posted by doanduyhai <gi...@git.apache.org>.
Github user doanduyhai commented on the issue:
https://github.com/apache/zeppelin/pull/1473
@jongyoul I would like too but I don't have the commit right ...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1473: [ZEPPELIN-908] Apply new mechanism to CassandraInterpr...
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1473
@doanduyhai Can you commit this PR? I think it's good starting point. :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---