You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Mukund <mu...@tessna.com> on 2003/07/08 10:54:09 UTC
Oops.. here is the patch
Here is the patch for your reference, against 0.24.2.
Mukund
Re: Oops.. here is the patch
Posted by Paul L Lussier <pl...@lanminds.com>.
In a message dated: Tue, 08 Jul 2003 17:49:58 BST
Mukund said:
>
>On Tue, Jul 08, 2003 at 12:38:42PM -0400, Paul L Lussier wrote:
>| Please submit patches with the proper Subject line of [PATCH],
>| my procmail recipes don't work otherwise :)
>|
>
>I am sorry Paul. I was merely reposting the patch as a reference.
>The patch was posted by Sander to this list earlier this month.
Okay. I'm just trying to get a handle on this patch management as
well :)
--
Seeya,
Paul
--
Key fingerprint = 1660 FECC 5D21 D286 F853 E808 BB07 9239 53F1 28EE
It may look like I'm just sitting here doing nothing,
but I'm really actively waiting for all my problems to go away.
If you're not having fun, you're not doing it right!
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: Oops.. here is the patch
Posted by Mukund <mu...@tessna.com>.
On Tue, Jul 08, 2003 at 12:38:42PM -0400, Paul L Lussier wrote:
| Please submit patches with the proper Subject line of [PATCH],
| my procmail recipes don't work otherwise :)
|
I am sorry Paul. I was merely reposting the patch as a reference.
The patch was posted by Sander to this list earlier this month.
Mukund
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: Oops.. here is the patch
Posted by Paul L Lussier <pl...@lanminds.com>.
In a message dated: Tue, 08 Jul 2003 20:06:00 +0200
"Sander Striker" said:
>Paul, I'll be applying this patch myself. Don't worry
>about it ;).
Okay, thanks :)
--
Seeya,
Paul
--
Key fingerprint = 1660 FECC 5D21 D286 F853 E808 BB07 9239 53F1 28EE
It may look like I'm just sitting here doing nothing,
but I'm really actively waiting for all my problems to go away.
If you're not having fun, you're not doing it right!
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
RE: Oops.. here is the patch
Posted by Sander Striker <st...@apache.org>.
> From: Paul L Lussier [mailto:pll@lanminds.com]
> Sent: Tuesday, July 08, 2003 6:39 PM
> In a message dated: Tue, 08 Jul 2003 11:54:09 BST
> Mukund said:
>
>
> >Here is the patch for your reference, against 0.24.2.
>
> Please submit patches with the proper Subject line of [PATCH],
> my procmail recipes don't work otherwise :)
>
> Thanks kindly!
Paul, I'll be applying this patch myself. Don't worry
about it ;).
Sander
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: Oops.. here is the patch
Posted by Paul L Lussier <pl...@lanminds.com>.
In a message dated: Tue, 08 Jul 2003 11:54:09 BST
Mukund said:
>Here is the patch for your reference, against 0.24.2.
Please submit patches with the proper Subject line of [PATCH],
my procmail recipes don't work otherwise :)
Thanks kindly!
--
Seeya,
Paul
--
Key fingerprint = 1660 FECC 5D21 D286 F853 E808 BB07 9239 53F1 28EE
It may look like I'm just sitting here doing nothing,
but I'm really actively waiting for all my problems to go away.
If you're not having fun, you're not doing it right!
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
RE: Oops.. here is the patch
Posted by Sander Striker <st...@apache.org>.
> From: Greg Hudson [mailto:ghudson@MIT.EDU]
> Sent: Tuesday, July 08, 2003 6:10 PM
[...]
> Incidentally, I feel a little weird about a performance improvement
> patch which *relies* on mod_dav not clearing the pool between requests.
> Or am I misunderstanding how this works?
Yes. You probably overlooked that we are using the _connection_ pool.
Everything in there is guaranteed to live as long as the connection.
Sander
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: Oops.. here is the patch
Posted by Greg Hudson <gh...@MIT.EDU>.
On Tue, 2003-07-08 at 07:33, Greg Stein wrote:
> On Tue, Jul 08, 2003 at 11:54:09AM +0100, Mukund wrote:
> >...
> > + /* Cache open repository. Key it off by root_path, which should be more
> > + * unique than the fs_path, given that two Locations may point to the
> > + * same repository.
> > + */
> > + repos_key = apr_pstrcat(r->pool, "mod_dav_svn:", root_path, NULL);
>
> You know... I still don't understand this. You *want* to use the same key
> whenever possible. So why shoot for something "more unique" ?? If two
> Locations refer to the same repos, and requests come in over the connection
> for each of those Locations, then they ought to use the same FS!
Could virtual hosting cause the same fs_path to refer to two different
repositories? (If that's the case, then the code is more correct, but
the comment is severely confused.)
Incidentally, I feel a little weird about a performance improvement
patch which *relies* on mod_dav not clearing the pool between requests.
Or am I misunderstanding how this works?
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: Oops.. here is the patch
Posted by br...@xbc.nu.
Quoting Greg Stein <gs...@lyra.org>:
> Mind you, we don't want to use an FS simultaneously across threads, but
> that isn't the case here.
And why not? The BDB environment is supposed to be thread-safe, isn't it? We may
have to add another flag when we open the environment, and we definitely don't
want to serve the same request in more than one thread, but using the same
environment in different threads shouldn't be a problem.
Brane
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
RE: Oops.. here is the patch
Posted by Sander Striker <st...@apache.org>.
> From: Greg Stein [mailto:gstein@lyra.org]
> Sent: Tuesday, July 08, 2003 1:34 PM
> On Tue, Jul 08, 2003 at 11:54:09AM +0100, Mukund wrote:
>>...
>> + /* Cache open repository. Key it off by root_path, which should be more
>> + * unique than the fs_path, given that two Locations may point to the
>> + * same repository.
>> + */
>> + repos_key = apr_pstrcat(r->pool, "mod_dav_svn:", root_path, NULL);
>
> You know... I still don't understand this. You *want* to use the same key
> whenever possible. So why shoot for something "more unique" ?? If two
> Locations refer to the same repos, and requests come in over the connection
> for each of those Locations, then they ought to use the same FS!
Dude, you're so right! ;). /me wakes up
Ok, I'll just key off on fs_path then.
Sander
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: Oops.. here is the patch
Posted by Greg Stein <gs...@lyra.org>.
On Tue, Jul 08, 2003 at 11:54:09AM +0100, Mukund wrote:
>...
> + /* Cache open repository. Key it off by root_path, which should be more
> + * unique than the fs_path, given that two Locations may point to the
> + * same repository.
> + */
> + repos_key = apr_pstrcat(r->pool, "mod_dav_svn:", root_path, NULL);
You know... I still don't understand this. You *want* to use the same key
whenever possible. So why shoot for something "more unique" ?? If two
Locations refer to the same repos, and requests come in over the connection
for each of those Locations, then they ought to use the same FS!
Mind you, we don't want to use an FS simultaneously across threads, but that
isn't the case here.
Cheers,
-g
--
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org