[GitHub] [cloudstack] weizhouapache commented on a change in pull request #5684: (ccc2021 hachathon ) kvm: add hosts using cloustack ssh private key

[GitBox <gi...@apache.org>]

weizhouapache commented on a change in pull request #5684:
URL: https://github.com/apache/cloudstack/pull/5684#discussion_r748177170



##########
File path: utils/src/main/java/com/cloud/utils/ssh/SSHCmdHelper.java
##########
@@ -77,8 +80,47 @@ public String getStdErr() {
     }
 
     public static com.trilead.ssh2.Connection acquireAuthorizedConnection(String ip, int port, String username, String password) {
+        return acquireAuthorizedConnection(ip, 22, username, password, null);
+    }
+
+    public static boolean acquireAuthorizedConnectionWithPublicKey(final com.trilead.ssh2.Connection sshConnection, final String username, final String privateKey) {
+        if (StringUtils.isNotBlank(privateKey)) {
+            File privateKeyFile = null;
+            try {
+                privateKeyFile = File.createTempFile("cloudstack-host-", null);

Review comment:
       
   
   
   > @weizhouapache This temp. hack may not be required as mgmt server saves the ssh private/pub keys at: `/var/lib/cloudstack/management/.ssh/id_rsa` on the mgmt server, why not just read/use that?
   > 
   > In fact if this is saved/assumed, then we don't even need to read the private key from db and pass it here. Thoughts?
   
   @rhtyd 
   I have considered it. but at the end I decided to use temp file so that the process will not rely on any file on management server.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org