[GitHub] [hudi] trushev commented on a diff in pull request #7637: [MINOR] Fix ContinuousFileSource and ITTestDataStreamWrite for flink 1.16 support

[GitBox <gi...@apache.org>]

trushev commented on code in PR #7637:
URL: https://github.com/apache/hudi/pull/7637#discussion_r1066658597


##########
hudi-flink-datasource/hudi-flink/src/test/java/org/apache/hudi/sink/ITTestDataStreamWrite.java:
##########
@@ -554,4 +518,20 @@ public void testHoodiePipelineBuilderSinkWithSchemaSet() throws Exception {
     execute(execEnv, false, "Api_Sink_Test");
     TestData.checkWrittenDataCOW(tempFile, EXPECTED);
   }
+
+  private JsonDeserializationFunction getDeserializationFunc(Configuration conf) {
+    // Read from file source

Review Comment:
   > Why CI does not fail
   
   As I understand it happens because azure still runs test with flink 1.14
   
   azure-pipelines.yml:
   ```
   BUILD_PROFILES: '-Dscala-2.11 -Dspark2.4 -Dflink1.14'
   ```
   I was thinking 1.14 version is purposely  left as main for azure but it looks like a bug now :)
   
   > we can have a static factory method
   
   thanks, I'll fix it
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org