[jira] [Commented] (TINKERPOP3-666) We should not use @IgnoreEngine but instead ComputerVerificationStrategy

["Daniel Kuppitz (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TINKERPOP3-666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14539131#comment-14539131 ] 

Daniel Kuppitz commented on TINKERPOP3-666:
-------------------------------------------

All done, {{@IgnoreEngine}} can still be used, but is no longer necessary (that means {{ComputerVerificationException}}'s will not lead to failed tests). Changes are merged to master and pushed. All test suites passing.

Next steps: We can bring {{ComputerVerificationStrategy}} to perfection by removing the few remaining {{@IgnoreEngine}} annotations one by one and catch those cases in the {{ComputerVerificationStrategy}}.

This issue can be closed (I'm still not able / allowed to do that).

> We should not use @IgnoreEngine but instead ComputerVerificationStrategy
> ------------------------------------------------------------------------
>
>                 Key: TINKERPOP3-666
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP3-666
>             Project: TinkerPop 3
>          Issue Type: Improvement
>          Components: test-suite
>            Reporter: Marko A. Rodriguez
>
> We currently use {{@IgnoreEngine(COMPUTER)}} in the process test suite for the following situations:
> 1. lambdas (gremlin-java only)
> 2. range (we should allow range if its the end step)
> 3. dedup (we have to make this a barrier step)
> 4. except/retain (side-effect sets -- don't have an easy solution)
> 5. by('name') and the OLAP vertex doesn't have properties.
> {{ComputerVerificationStrategy}} should be able to identify these situations and fail. The test suite should then say: "ah, ComputerVerificationStrategy is not happy, silently fail with a WARN or something."
> Finally, note that 2 and 3 above can be fixed if range/dedup are the end steps of the traversal. We currently don't support this in OLAP.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)