You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/08/19 03:39:08 UTC

[GitHub] [spark] yikf opened a new pull request, #37574: [MINOR][SQL] Specify the column name when the data type is not supported by datasource

yikf opened a new pull request, #37574:
URL: https://github.com/apache/spark/pull/37574

   
   <!--
   Thanks for sending a pull request!  Here are some tips for you:
     1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
     2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
     3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
     4. Be sure to keep the PR description updated to reflect all changes.
     5. Please write your PR title to summarize what this PR proposes.
     6. If possible, provide a concise example to reproduce the issue for a faster review.
     7. If you want to add a new configuration, please read the guideline first for naming configurations in
        'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
     8. If you want to add or modify an error type or message, please read the guideline first in
        'core/src/main/resources/error/README.md'.
   -->
   
   ### What changes were proposed in this pull request?
   <!--
   Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue. 
   If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
     1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
     2. If you fix some SQL features, you can provide some references of other DBMSes.
     3. If there is design documentation, please add the link.
     4. If there is a discussion in the mailing list, please add the link.
   -->
   This is a minor fix and aims to specify the column name when the data type is not supported by datasource
   
   ### Why are the changes needed?
   <!--
   Please clarify why the changes are needed. For instance,
     1. If you propose a new API, clarify the use case for a new API.
     2. If you fix a bug, you can clarify why it is a bug.
   -->
   More explicit error messages
   
   
   
   ### Does this PR introduce _any_ user-facing change?
   <!--
   Note that it means *any* user-facing change including all aspects such as the documentation fix.
   If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
   If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
   If no, write 'No'.
   -->
   No
   
   ### How was this patch tested?
   <!--
   If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
   If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
   If tests were not added, please describe why they were not added and/or why it was difficult to add.
   If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
   -->
   GA


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] wangyum commented on a diff in pull request #37574: [SPARK-40207][SQL] Specify the column name when the data type is not supported by datasource

Posted by GitBox <gi...@apache.org>.
wangyum commented on code in PR #37574:
URL: https://github.com/apache/spark/pull/37574#discussion_r955989716


##########
sql/core/src/test/scala/org/apache/spark/sql/FileBasedDataSourceSuite.scala:
##########
@@ -257,58 +257,64 @@ class FileBasedDataSourceSuite extends QueryTest
   // Text file format only supports string type
   test("SPARK-24691 error handling for unsupported types - text") {
     withTempDir { dir =>
+      def validateErrorMessage(msg: String, column: String, dt: String, format: String): Unit = {
+        val excepted = s"column `$column` has a data type of $dt, " +
+          s"which is not supported by $format."
+        assert(msg.toLowerCase(Locale.ROOT).contains(excepted))

Review Comment:
   Why do we need `toLowerCase`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] wangyum closed pull request #37574: [SPARK-40207][SQL] Specify the column name when the data type is not supported by datasource

Posted by GitBox <gi...@apache.org>.
wangyum closed pull request #37574: [SPARK-40207][SQL] Specify the column name when the data type is not supported by datasource
URL: https://github.com/apache/spark/pull/37574


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] wangyum commented on a diff in pull request #37574: [SPARK-40207][SQL] Specify the column name when the data type is not supported by datasource

Posted by GitBox <gi...@apache.org>.
wangyum commented on code in PR #37574:
URL: https://github.com/apache/spark/pull/37574#discussion_r957913997


##########
sql/hive/src/test/scala/org/apache/spark/sql/hive/orc/HiveOrcSourceSuite.scala:
##########
@@ -112,37 +113,43 @@ class HiveOrcSourceSuite extends OrcSuite with TestHiveSingleton {
     withTempDir { dir =>
       val orcDir = new File(dir, "orc").getCanonicalPath
 
+      def validateErrorMessage(msg: String, column: String, dt: String, format: String): Unit = {
+        val excepted = s"column `$column` has a data type of $dt, " +
+          s"which is not supported by $format."
+        assert(msg.toLowerCase(Locale.ROOT).contains(excepted))

Review Comment:
   Let's remove `.toLowerCase(Locale.ROOT)`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] wangyum commented on a diff in pull request #37574: [SPARK-40207][SQL] Specify the column name when the data type is not supported by datasource

Posted by GitBox <gi...@apache.org>.
wangyum commented on code in PR #37574:
URL: https://github.com/apache/spark/pull/37574#discussion_r958049599


##########
connector/avro/src/test/scala/org/apache/spark/sql/avro/AvroSuite.scala:
##########
@@ -1181,14 +1181,16 @@ abstract class AvroSuite
           sql("select interval 1 days").write.format("avro").mode("overwrite").save(tempDir)
         }.getMessage
         assert(msg.contains("Cannot save interval data type into external storage.") ||
-          msg.contains("AVRO data source does not support interval data type."))
+          msg.contains("column `interval 1 days` has a data type of interval, " +
+            "which is not supported by avro."))

Review Comment:
   It should be:
   ```
   Column `INTERVAL '1' DAY` has a data type of interval day, which is not supported by Avro.
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] Yikf commented on a diff in pull request #37574: [SPARK-40207][SQL] Specify the column name when the data type is not supported by datasource

Posted by GitBox <gi...@apache.org>.
Yikf commented on code in PR #37574:
URL: https://github.com/apache/spark/pull/37574#discussion_r958162570


##########
connector/avro/src/test/scala/org/apache/spark/sql/avro/AvroSuite.scala:
##########
@@ -1181,14 +1181,16 @@ abstract class AvroSuite
           sql("select interval 1 days").write.format("avro").mode("overwrite").save(tempDir)
         }.getMessage
         assert(msg.contains("Cannot save interval data type into external storage.") ||
-          msg.contains("AVRO data source does not support interval data type."))
+          msg.contains("column `interval 1 days` has a data type of interval, " +
+            "which is not supported by avro."))

Review Comment:
   Yes, updated



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] wangyum commented on a diff in pull request #37574: [SPARK-40207][SQL] Specify the column name when the data type is not supported by datasource

Posted by GitBox <gi...@apache.org>.
wangyum commented on code in PR #37574:
URL: https://github.com/apache/spark/pull/37574#discussion_r957914185


##########
sql/hive/src/test/scala/org/apache/spark/sql/hive/orc/HiveOrcSourceSuite.scala:
##########
@@ -112,37 +113,43 @@ class HiveOrcSourceSuite extends OrcSuite with TestHiveSingleton {
     withTempDir { dir =>
       val orcDir = new File(dir, "orc").getCanonicalPath
 
+      def validateErrorMessage(msg: String, column: String, dt: String, format: String): Unit = {
+        val excepted = s"column `$column` has a data type of $dt, " +
+          s"which is not supported by $format."
+        assert(msg.toLowerCase(Locale.ROOT).contains(excepted))
+      }
+
       // write path
       var msg = intercept[AnalysisException] {
         sql("select interval 1 days").write.mode("overwrite").orc(orcDir)
       }.getMessage
-      assert(msg.contains("ORC data source does not support interval day data type"))
+      validateErrorMessage(msg, "interval '1' day", "interval day", "orc")

Review Comment:
   `validateErrorMessage(msg, "interval '1' day", "interval day", "orc")` -> `validateErrorMessage(msg, "INTERVAL '1' DAY", "interval day", "ORC")`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] wangyum commented on pull request #37574: [MINOR][SQL] Specify the column name when the data type is not supported by datasource

Posted by GitBox <gi...@apache.org>.
wangyum commented on PR #37574:
URL: https://github.com/apache/spark/pull/37574#issuecomment-1225737366

   Could you file a jira ticket?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] wangyum commented on pull request #37574: [SPARK-40207][SQL] Specify the column name when the data type is not supported by datasource

Posted by GitBox <gi...@apache.org>.
wangyum commented on PR #37574:
URL: https://github.com/apache/spark/pull/37574#issuecomment-1231512083

   Merged to master.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] wangyum commented on a diff in pull request #37574: [SPARK-40207][SQL] Specify the column name when the data type is not supported by datasource

Posted by GitBox <gi...@apache.org>.
wangyum commented on code in PR #37574:
URL: https://github.com/apache/spark/pull/37574#discussion_r957957465


##########
sql/core/src/test/scala/org/apache/spark/sql/FileBasedDataSourceSuite.scala:
##########
@@ -319,56 +325,62 @@ class FileBasedDataSourceSuite extends QueryTest
   //  parquet -> R/W: Interval, Null
   test("SPARK-24204 error handling for unsupported Array/Map/Struct types - csv") {
     withTempDir { dir =>
+      def validateErrorMessage(msg: String, column: String, dt: String, format: String): Unit = {
+        val excepted = s"column `$column` has a data type of $dt, " +
+          s"which is not supported by $format."
+        assert(msg.toLowerCase(Locale.ROOT).contains(excepted))

Review Comment:
   Please remove `.toLowerCase(Locale.ROOT)`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] Yikf commented on pull request #37574: [SPARK-40207][SQL] Specify the column name when the data type is not supported by datasource

Posted by GitBox <gi...@apache.org>.
Yikf commented on PR #37574:
URL: https://github.com/apache/spark/pull/37574#issuecomment-1225784190

   > Could you file a jira ticket?
   
   done


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] wangyum commented on a diff in pull request #37574: [SPARK-40207][SQL] Specify the column name when the data type is not supported by datasource

Posted by GitBox <gi...@apache.org>.
wangyum commented on code in PR #37574:
URL: https://github.com/apache/spark/pull/37574#discussion_r958049599


##########
connector/avro/src/test/scala/org/apache/spark/sql/avro/AvroSuite.scala:
##########
@@ -1181,14 +1181,16 @@ abstract class AvroSuite
           sql("select interval 1 days").write.format("avro").mode("overwrite").save(tempDir)
         }.getMessage
         assert(msg.contains("Cannot save interval data type into external storage.") ||
-          msg.contains("AVRO data source does not support interval data type."))
+          msg.contains("column `interval 1 days` has a data type of interval, " +
+            "which is not supported by avro."))

Review Comment:
   It should be:
   ```
   Column `INTERVAL '1' DAY` has a data type of interval, which is not supported by Avro.
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] wangyum commented on a diff in pull request #37574: [SPARK-40207][SQL] Specify the column name when the data type is not supported by datasource

Posted by GitBox <gi...@apache.org>.
wangyum commented on code in PR #37574:
URL: https://github.com/apache/spark/pull/37574#discussion_r957914905


##########
sql/core/src/test/scala/org/apache/spark/sql/FileBasedDataSourceSuite.scala:
##########
@@ -257,58 +257,64 @@ class FileBasedDataSourceSuite extends QueryTest
   // Text file format only supports string type
   test("SPARK-24691 error handling for unsupported types - text") {
     withTempDir { dir =>
+      def validateErrorMessage(msg: String, column: String, dt: String, format: String): Unit = {
+        val excepted = s"column `$column` has a data type of $dt, " +
+          s"which is not supported by $format."
+        assert(msg.toLowerCase(Locale.ROOT).contains(excepted))
+      }
+
       // write path
       val textDir = new File(dir, "text").getCanonicalPath
       var msg = intercept[AnalysisException] {
         Seq(1).toDF.write.text(textDir)
       }.getMessage
-      assert(msg.contains("Text data source does not support int data type"))
+      validateErrorMessage(msg, "value", "int", "text")

Review Comment:
   `validateErrorMessage(msg, "value", "int", "text")` -> `validateErrorMessage(msg, "value", "int", "Text")`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] Yikf commented on a diff in pull request #37574: [SPARK-40207][SQL] Specify the column name when the data type is not supported by datasource

Posted by GitBox <gi...@apache.org>.
Yikf commented on code in PR #37574:
URL: https://github.com/apache/spark/pull/37574#discussion_r955994504


##########
sql/core/src/test/scala/org/apache/spark/sql/FileBasedDataSourceSuite.scala:
##########
@@ -257,58 +257,64 @@ class FileBasedDataSourceSuite extends QueryTest
   // Text file format only supports string type
   test("SPARK-24691 error handling for unsupported types - text") {
     withTempDir { dir =>
+      def validateErrorMessage(msg: String, column: String, dt: String, format: String): Unit = {
+        val excepted = s"column `$column` has a data type of $dt, " +
+          s"which is not supported by $format."
+        assert(msg.toLowerCase(Locale.ROOT).contains(excepted))

Review Comment:
   we thrown `AnalysisException` which error message contains upper `Column`
   ```
   new AnalysisException(s"Column `${field.name}` has a data type of " +
         s"${field.dataType.catalogString}, which is not supported by $format."
       )
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #37574: [MINOR][SQL] Specify the column name when the data type is not supported by datasource

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on PR #37574:
URL: https://github.com/apache/spark/pull/37574#issuecomment-1220343416

   Can one of the admins verify this patch?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] wangyum commented on a diff in pull request #37574: [SPARK-40207][SQL] Specify the column name when the data type is not supported by datasource

Posted by GitBox <gi...@apache.org>.
wangyum commented on code in PR #37574:
URL: https://github.com/apache/spark/pull/37574#discussion_r957914603


##########
sql/core/src/test/scala/org/apache/spark/sql/FileBasedDataSourceSuite.scala:
##########
@@ -257,58 +257,64 @@ class FileBasedDataSourceSuite extends QueryTest
   // Text file format only supports string type
   test("SPARK-24691 error handling for unsupported types - text") {
     withTempDir { dir =>
+      def validateErrorMessage(msg: String, column: String, dt: String, format: String): Unit = {
+        val excepted = s"column `$column` has a data type of $dt, " +
+          s"which is not supported by $format."
+        assert(msg.toLowerCase(Locale.ROOT).contains(excepted))

Review Comment:
   Let's remove `.toLowerCase(Locale.ROOT)`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] Yikf commented on a diff in pull request #37574: [SPARK-40207][SQL] Specify the column name when the data type is not supported by datasource

Posted by GitBox <gi...@apache.org>.
Yikf commented on code in PR #37574:
URL: https://github.com/apache/spark/pull/37574#discussion_r958015729


##########
sql/core/src/test/scala/org/apache/spark/sql/FileBasedDataSourceSuite.scala:
##########
@@ -319,56 +325,62 @@ class FileBasedDataSourceSuite extends QueryTest
   //  parquet -> R/W: Interval, Null
   test("SPARK-24204 error handling for unsupported Array/Map/Struct types - csv") {
     withTempDir { dir =>
+      def validateErrorMessage(msg: String, column: String, dt: String, format: String): Unit = {
+        val excepted = s"column `$column` has a data type of $dt, " +
+          s"which is not supported by $format."
+        assert(msg.toLowerCase(Locale.ROOT).contains(excepted))

Review Comment:
   updated, thanks



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] wangyum commented on a diff in pull request #37574: [SPARK-40207][SQL] Specify the column name when the data type is not supported by datasource

Posted by GitBox <gi...@apache.org>.
wangyum commented on code in PR #37574:
URL: https://github.com/apache/spark/pull/37574#discussion_r958028056


##########
sql/core/src/test/scala/org/apache/spark/sql/FileBasedDataSourceSuite.scala:
##########
@@ -429,8 +441,8 @@ class FileBasedDataSourceSuite extends QueryTest
       } else {
         ""
       }
-      def errorMessage(format: String): String = {
-        s"$format data source does not support void data type."
+      def errorMessage(format: String, column: String = "null"): String = {

Review Comment:
   Could we remove this default value since it is only used once?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] Yikf commented on pull request #37574: [MINOR][SQL] Specify the column name when the data type is not supported by datasource

Posted by GitBox <gi...@apache.org>.
Yikf commented on PR #37574:
URL: https://github.com/apache/spark/pull/37574#issuecomment-1225332724

   friendly ping @wangyum @LuciferYang , PTAL if you find a moment


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org