You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by rw...@apache.org on 2002/12/01 19:29:06 UTC
cvs commit: jakarta-commons/pool/src/java/org/apache/commons/pool/impl GenericKeyedObjectPool.java GenericObjectPool.java
rwaldhoff 2002/12/01 10:29:06
Modified: pool/src/java/org/apache/commons/pool/impl
GenericKeyedObjectPool.java GenericObjectPool.java
Log:
add no-arg constructor
add javadoc comment clarifying that non-null factory is required
Revision Changes Path
1.10 +16 -4 jakarta-commons/pool/src/java/org/apache/commons/pool/impl/GenericKeyedObjectPool.java
Index: GenericKeyedObjectPool.java
===================================================================
RCS file: /home/cvs/jakarta-commons/pool/src/java/org/apache/commons/pool/impl/GenericKeyedObjectPool.java,v
retrieving revision 1.9
retrieving revision 1.10
diff -u -r1.9 -r1.10
--- GenericKeyedObjectPool.java 31 Oct 2002 20:57:19 -0000 1.9
+++ GenericKeyedObjectPool.java 1 Dec 2002 18:29:06 -0000 1.10
@@ -159,6 +159,11 @@
* that fail to validate will be dropped from the pool.
* </li>
* </ul>
+ * <p>
+ * GenericKeyedObjectPool is not usable without a {@link KeyedPoolableObjectFactory}. A
+ * non-<code>null</code> factory must be provided either as a constructor argument
+ * or via a call to {@link #setFactory} before the pool is used.
+ * </p>
* @see GenericObjectPool
* @author Rodney Waldhoff
* @version $Revision$ $Date$
@@ -287,6 +292,13 @@
public static final long DEFAULT_MIN_EVICTABLE_IDLE_TIME_MILLIS = 1000L * 60L * 30L;
//--- constructors -----------------------------------------------
+
+ /**
+ * Create a new <tt>GenericKeyedObjectPool</tt>..
+ */
+ public GenericKeyedObjectPool() {
+ this(null,DEFAULT_MAX_ACTIVE,DEFAULT_WHEN_EXHAUSTED_ACTION,DEFAULT_MAX_WAIT,DEFAULT_MAX_IDLE,DEFAULT_TEST_ON_BORROW,DEFAULT_TEST_ON_RETURN,DEFAULT_TIME_BETWEEN_EVICTION_RUNS_MILLIS,DEFAULT_NUM_TESTS_PER_EVICTION_RUN,DEFAULT_MIN_EVICTABLE_IDLE_TIME_MILLIS,DEFAULT_TEST_WHILE_IDLE);
+ }
/**
* Create a new <tt>GenericKeyedObjectPool</tt> using the specified values.
1.12 +16 -4 jakarta-commons/pool/src/java/org/apache/commons/pool/impl/GenericObjectPool.java
Index: GenericObjectPool.java
===================================================================
RCS file: /home/cvs/jakarta-commons/pool/src/java/org/apache/commons/pool/impl/GenericObjectPool.java,v
retrieving revision 1.11
retrieving revision 1.12
diff -u -r1.11 -r1.12
--- GenericObjectPool.java 1 Nov 2002 23:58:40 -0000 1.11
+++ GenericObjectPool.java 1 Dec 2002 18:29:06 -0000 1.12
@@ -156,6 +156,11 @@
* that fail to validate will be dropped from the pool.
* </li>
* </ul>
+ * <p>
+ * GenericObjectPool is not usable without a {@link PoolableObjectFactory}. A
+ * non-<code>null</code> factory must be provided either as a constructor argument
+ * or via a call to {@link #setFactory} before the pool is used.
+ *
* @see GenericKeyedObjectPool
* @author Rodney Waldhoff
* @version $Revision$ $Date$
@@ -281,6 +286,13 @@
public static final long DEFAULT_MIN_EVICTABLE_IDLE_TIME_MILLIS = 1000L * 60L * 30L;
//--- constructors -----------------------------------------------
+
+ /**
+ * Create a new <tt>GenericObjectPool</tt>.
+ */
+ public GenericObjectPool() {
+ this(null,DEFAULT_MAX_ACTIVE,DEFAULT_WHEN_EXHAUSTED_ACTION,DEFAULT_MAX_WAIT,DEFAULT_MAX_IDLE,DEFAULT_TEST_ON_BORROW,DEFAULT_TEST_ON_RETURN,DEFAULT_TIME_BETWEEN_EVICTION_RUNS_MILLIS,DEFAULT_NUM_TESTS_PER_EVICTION_RUN,DEFAULT_MIN_EVICTABLE_IDLE_TIME_MILLIS,DEFAULT_TEST_WHILE_IDLE);
+ }
/**
* Create a new <tt>GenericObjectPool</tt> using the specified values.
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>