You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2022/09/14 13:23:43 UTC

[GitHub] [geode] jvarenina commented on a diff in pull request #7851: GEODE-10419: Enhancment of backup disk-store command

jvarenina commented on code in PR #7851:
URL: https://github.com/apache/geode/pull/7851#discussion_r970802822


##########
geode-core/src/main/java/org/apache/geode/internal/cache/backup/BackupTask.java:
##########
@@ -38,6 +42,7 @@
 class BackupTask {
   private static final Logger logger = LogService.getLogger();
 
+  private static final String CLUSTER_CONFIG_DISK_STORE_NAME = "cluster_config";

Review Comment:
   Just a minor comment. Maybe to change the access modifier of "InternalConfigurationPersistenceService.CLUSTER_CONFIG_DISK_STORE_NAME" to public and use it instead of this one to avoid duplicated code. 
   
   No further comments from my side, everything else looks good. Good work!
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org