You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@perl.apache.org by Steve Hay <st...@apache.org> on 2019/09/24 16:53:14 UTC
[RELEASE CANDIDATE] mod_perl-2.0.11 RC2
Please download, test, and report back on this mod_perl 2.0.11 release
candidate.
https://dist.apache.org/repos/dist/dev/perl/mod_perl-2.0.11-rc2.tar.gz
MD5 = abc2c2168121a09b0fc3b6fc6adc00bd
SHA1 = 36ee7626506a3a461118b3957814dfe9331ef1de
Changes since RC1 are as follows:
Fix [CVE-2011-2767] Arbitrary Perl code execution in the context of the user
account via a user-owned .htaccess. Patch from bugs.debian.org #644169. [Jan
Ingvoldstad <ja...@ifi.uio.no>]
Fix potential test suite hangs due to pipelined response deadlocks. Patch
from rt.cpan.org #82409. [Zefram <ze...@fysh.org>]
Fix t/compat/request.t failures [Steve Hay]
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: [RELEASE CANDIDATE] mod_perl-2.0.11 RC2
Posted by Adam Prime <ad...@utoronto.ca>.
>
> What happens if you revert the change in that file? I.e. Change
> FINFO_NAME back to FINFO_NORM on line 168, and on line 18 (the
> APR::Const -compile line)? Does that fix it for you?
>
With that change all the request_rec tests run and pass.
Adam
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: [OT] [RELEASE CANDIDATE] mod_perl-2.0.11 RC2
Posted by Wesley Peng <we...@thepeng.eu>.
on 2019/9/26 18:32, André Warnier (tomcat) wrote:
> Not being able myself to contribute really to this process, I did not
> comment on the previous emails here.
> But as a grateful user of mod_perl for many years, I just want to
> express my immense gratitude to Steve and all other people who
> contribute to keep this project and product alive and well, and let them
> know that their efforts are not in vain.
> The activity of my little software and services company in Germany,
> Spain and worldwide, depends vitally on Apache httpd, perl and mod_perl.
> And I expect that I am not alone in such a situation.
We also use modperl for regular commercial applications.
Thanks for everyone's contribution.
regards.
Re:[OT] [RELEASE CANDIDATE] mod_perl-2.0.11 RC2
Posted by "André Warnier (tomcat)" <aw...@ice-sa.com>.
Guys,
Not being able myself to contribute really to this process, I did not comment on the
previous emails here.
But as a grateful user of mod_perl for many years, I just want to express my immense
gratitude to Steve and all other people who contribute to keep this project and product
alive and well, and let them know that their efforts are not in vain.
The activity of my little software and services company in Germany, Spain and worldwide,
depends vitally on Apache httpd, perl and mod_perl. And I expect that I am not alone in
such a situation.
Thanks !
André
On 26.09.2019 10:02, Steve Hay wrote:
> On Thu, 26 Sep 2019 at 06:54, Damyan Ivanov <dm...@debian.org> wrote:
>>
>> -=| Damyan Ivanov, 25.09.2019 23:06:56 +0300 |=-
>>> -=| Steve Hay, 25.09.2019 08:34:07 +0100 |=-
>>>> What happens if you revert the change in that file? I.e. Change
>>>> FINFO_NAME back to FINFO_NORM on line 168, and on line 18 (the
>>>> APR::Const -compile line)? Does that fix it for you?
>>>
>>> With these two lines reverted, all tests pass for me.
>>
>> Out of interest I also tried using "FINFO_NAME | FINFO_NORM" on line
>> 168 and the test failed with the same error. It appears that
>> FINFO_NAME triggers it.
>>
>> Tracing this in APR, the error seems to come from
>> file_io/unix/filestat.c¹ where the valid flags on line 73 don't
>> include APR_FINFO_NAME. This kind of makes sense, because the stat(2)
>> struct lacks information about the file name.
>>
>> ¹ https://sources.debian.org/src/apr/1.6.5-1/file_io/unix/filestat.c/
>>
>> -- Damyan
>
> Good catch! That explains why using FINFO_NAME is failing for you but
> working for me (on Windows): apr/file_io/win32/filestat.c *does* have
> support for FINFO_NAME in it, filling in finfo->name from filename if
> it succeeded in getting filename (using calls other than stat()!).
>
> The point of the request_rec test in question is only to test a single
> field anyway (the rest are tested in TestAPR::finfo, as the comment
> says) so I will simply change it to test a different field. Evidently
> FINFO_NAME was a poor choice!
>
> Before I actually roll out an RC3, please can you confirm that
> switching to FINFO_SIZE as per this patch works for you (it does for
> me):
>
> Index: t/response/TestAPI/request_rec.pm
> ===================================================================
> --- t/response/TestAPI/request_rec.pm (revision 1866274)
> +++ t/response/TestAPI/request_rec.pm (working copy)
> @@ -15,7 +15,7 @@
> use APR::Pool ();
>
> use Apache2::Const -compile => qw(OK M_GET M_PUT);
> -use APR::Const -compile => qw(FINFO_NAME);
> +use APR::Const -compile => qw(FINFO_SIZE);
>
> #this test module is only for testing fields in the request_rec
> #listed in apache_structures.map
> @@ -165,12 +165,13 @@
>
> # finfo
> {
> - my $finfo = APR::Finfo::stat(__FILE__,
> APR::Const::FINFO_NAME, $r->pool);
> + my $size = (stat __FILE__)[7];
> + my $finfo = APR::Finfo::stat(__FILE__,
> APR::Const::FINFO_SIZE, $r->pool);
> $r->finfo($finfo);
> # just one field test, all accessors are fully tested in
> # TestAPR::finfo
> - ok t_cmp($r->finfo->fname,
> - __FILE__,
> + ok t_cmp($r->finfo->size,
> + $size,
> '$r->finfo');
> }
>
Re: [RELEASE CANDIDATE] mod_perl-2.0.11 RC2
Posted by Steve Hay <st...@googlemail.com.INVALID>.
On Thu, 26 Sep 2019 at 16:17, Damyan Ivanov <dm...@debian.org> wrote:
>
> -=| Steve Hay, 26.09.2019 09:02:19 +0100 |=-
> > Before I actually roll out an RC3, please can you confirm that
> > switching to FINFO_SIZE as per this patch works for you (it does for
> > me):
> > …
>
> This works for me:
>
> # testing : $r->finfo
> # expected: 7278
> # received: 7278
> ok 44
>
> (the rest of the tests still pass).
>
Thanks for the confirmation. RC3 is now uploaded.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: [RELEASE CANDIDATE] mod_perl-2.0.11 RC2
Posted by Steve Hay <st...@googlemail.com>.
On Thu, 26 Sep 2019 at 16:17, Damyan Ivanov <dm...@debian.org> wrote:
>
> -=| Steve Hay, 26.09.2019 09:02:19 +0100 |=-
> > Before I actually roll out an RC3, please can you confirm that
> > switching to FINFO_SIZE as per this patch works for you (it does for
> > me):
> > …
>
> This works for me:
>
> # testing : $r->finfo
> # expected: 7278
> # received: 7278
> ok 44
>
> (the rest of the tests still pass).
>
Thanks for the confirmation. RC3 is now uploaded.
Re: [RELEASE CANDIDATE] mod_perl-2.0.11 RC2
Posted by Damyan Ivanov <dm...@debian.org>.
-=| Steve Hay, 26.09.2019 09:02:19 +0100 |=-
> Before I actually roll out an RC3, please can you confirm that
> switching to FINFO_SIZE as per this patch works for you (it does for
> me):
> …
This works for me:
# testing : $r->finfo
# expected: 7278
# received: 7278
ok 44
(the rest of the tests still pass).
-- Damyan
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: [RELEASE CANDIDATE] mod_perl-2.0.11 RC2
Posted by Damyan Ivanov <dm...@debian.org>.
-=| Steve Hay, 26.09.2019 09:02:19 +0100 |=-
> Before I actually roll out an RC3, please can you confirm that
> switching to FINFO_SIZE as per this patch works for you (it does for
> me):
> …
This works for me:
# testing : $r->finfo
# expected: 7278
# received: 7278
ok 44
(the rest of the tests still pass).
-- Damyan
Re: [RELEASE CANDIDATE] mod_perl-2.0.11 RC2
Posted by Steve Hay <st...@googlemail.com.INVALID>.
On Thu, 26 Sep 2019 at 06:54, Damyan Ivanov <dm...@debian.org> wrote:
>
> -=| Damyan Ivanov, 25.09.2019 23:06:56 +0300 |=-
> > -=| Steve Hay, 25.09.2019 08:34:07 +0100 |=-
> > > What happens if you revert the change in that file? I.e. Change
> > > FINFO_NAME back to FINFO_NORM on line 168, and on line 18 (the
> > > APR::Const -compile line)? Does that fix it for you?
> >
> > With these two lines reverted, all tests pass for me.
>
> Out of interest I also tried using "FINFO_NAME | FINFO_NORM" on line
> 168 and the test failed with the same error. It appears that
> FINFO_NAME triggers it.
>
> Tracing this in APR, the error seems to come from
> file_io/unix/filestat.c¹ where the valid flags on line 73 don't
> include APR_FINFO_NAME. This kind of makes sense, because the stat(2)
> struct lacks information about the file name.
>
> ¹ https://sources.debian.org/src/apr/1.6.5-1/file_io/unix/filestat.c/
>
> -- Damyan
Good catch! That explains why using FINFO_NAME is failing for you but
working for me (on Windows): apr/file_io/win32/filestat.c *does* have
support for FINFO_NAME in it, filling in finfo->name from filename if
it succeeded in getting filename (using calls other than stat()!).
The point of the request_rec test in question is only to test a single
field anyway (the rest are tested in TestAPR::finfo, as the comment
says) so I will simply change it to test a different field. Evidently
FINFO_NAME was a poor choice!
Before I actually roll out an RC3, please can you confirm that
switching to FINFO_SIZE as per this patch works for you (it does for
me):
Index: t/response/TestAPI/request_rec.pm
===================================================================
--- t/response/TestAPI/request_rec.pm (revision 1866274)
+++ t/response/TestAPI/request_rec.pm (working copy)
@@ -15,7 +15,7 @@
use APR::Pool ();
use Apache2::Const -compile => qw(OK M_GET M_PUT);
-use APR::Const -compile => qw(FINFO_NAME);
+use APR::Const -compile => qw(FINFO_SIZE);
#this test module is only for testing fields in the request_rec
#listed in apache_structures.map
@@ -165,12 +165,13 @@
# finfo
{
- my $finfo = APR::Finfo::stat(__FILE__,
APR::Const::FINFO_NAME, $r->pool);
+ my $size = (stat __FILE__)[7];
+ my $finfo = APR::Finfo::stat(__FILE__,
APR::Const::FINFO_SIZE, $r->pool);
$r->finfo($finfo);
# just one field test, all accessors are fully tested in
# TestAPR::finfo
- ok t_cmp($r->finfo->fname,
- __FILE__,
+ ok t_cmp($r->finfo->size,
+ $size,
'$r->finfo');
}
Re: [RELEASE CANDIDATE] mod_perl-2.0.11 RC2
Posted by Steve Hay <st...@googlemail.com>.
On Thu, 26 Sep 2019 at 06:54, Damyan Ivanov <dm...@debian.org> wrote:
>
> -=| Damyan Ivanov, 25.09.2019 23:06:56 +0300 |=-
> > -=| Steve Hay, 25.09.2019 08:34:07 +0100 |=-
> > > What happens if you revert the change in that file? I.e. Change
> > > FINFO_NAME back to FINFO_NORM on line 168, and on line 18 (the
> > > APR::Const -compile line)? Does that fix it for you?
> >
> > With these two lines reverted, all tests pass for me.
>
> Out of interest I also tried using "FINFO_NAME | FINFO_NORM" on line
> 168 and the test failed with the same error. It appears that
> FINFO_NAME triggers it.
>
> Tracing this in APR, the error seems to come from
> file_io/unix/filestat.c¹ where the valid flags on line 73 don't
> include APR_FINFO_NAME. This kind of makes sense, because the stat(2)
> struct lacks information about the file name.
>
> ¹ https://sources.debian.org/src/apr/1.6.5-1/file_io/unix/filestat.c/
>
> -- Damyan
Good catch! That explains why using FINFO_NAME is failing for you but
working for me (on Windows): apr/file_io/win32/filestat.c *does* have
support for FINFO_NAME in it, filling in finfo->name from filename if
it succeeded in getting filename (using calls other than stat()!).
The point of the request_rec test in question is only to test a single
field anyway (the rest are tested in TestAPR::finfo, as the comment
says) so I will simply change it to test a different field. Evidently
FINFO_NAME was a poor choice!
Before I actually roll out an RC3, please can you confirm that
switching to FINFO_SIZE as per this patch works for you (it does for
me):
Index: t/response/TestAPI/request_rec.pm
===================================================================
--- t/response/TestAPI/request_rec.pm (revision 1866274)
+++ t/response/TestAPI/request_rec.pm (working copy)
@@ -15,7 +15,7 @@
use APR::Pool ();
use Apache2::Const -compile => qw(OK M_GET M_PUT);
-use APR::Const -compile => qw(FINFO_NAME);
+use APR::Const -compile => qw(FINFO_SIZE);
#this test module is only for testing fields in the request_rec
#listed in apache_structures.map
@@ -165,12 +165,13 @@
# finfo
{
- my $finfo = APR::Finfo::stat(__FILE__,
APR::Const::FINFO_NAME, $r->pool);
+ my $size = (stat __FILE__)[7];
+ my $finfo = APR::Finfo::stat(__FILE__,
APR::Const::FINFO_SIZE, $r->pool);
$r->finfo($finfo);
# just one field test, all accessors are fully tested in
# TestAPR::finfo
- ok t_cmp($r->finfo->fname,
- __FILE__,
+ ok t_cmp($r->finfo->size,
+ $size,
'$r->finfo');
}
Re: [RELEASE CANDIDATE] mod_perl-2.0.11 RC2
Posted by Damyan Ivanov <dm...@debian.org>.
-=| Damyan Ivanov, 25.09.2019 23:06:56 +0300 |=-
> -=| Steve Hay, 25.09.2019 08:34:07 +0100 |=-
> > What happens if you revert the change in that file? I.e. Change
> > FINFO_NAME back to FINFO_NORM on line 168, and on line 18 (the
> > APR::Const -compile line)? Does that fix it for you?
>
> With these two lines reverted, all tests pass for me.
Out of interest I also tried using "FINFO_NAME | FINFO_NORM" on line
168 and the test failed with the same error. It appears that
FINFO_NAME triggers it.
Tracing this in APR, the error seems to come from
file_io/unix/filestat.c¹ where the valid flags on line 73 don't
include APR_FINFO_NAME. This kind of makes sense, because the stat(2)
struct lacks information about the file name.
¹ https://sources.debian.org/src/apr/1.6.5-1/file_io/unix/filestat.c/
-- Damyan
Re: [RELEASE CANDIDATE] mod_perl-2.0.11 RC2
Posted by Damyan Ivanov <dm...@debian.org>.
-=| Damyan Ivanov, 25.09.2019 23:06:56 +0300 |=-
> -=| Steve Hay, 25.09.2019 08:34:07 +0100 |=-
> > What happens if you revert the change in that file? I.e. Change
> > FINFO_NAME back to FINFO_NORM on line 168, and on line 18 (the
> > APR::Const -compile line)? Does that fix it for you?
>
> With these two lines reverted, all tests pass for me.
Out of interest I also tried using "FINFO_NAME | FINFO_NORM" on line
168 and the test failed with the same error. It appears that
FINFO_NAME triggers it.
Tracing this in APR, the error seems to come from
file_io/unix/filestat.c¹ where the valid flags on line 73 don't
include APR_FINFO_NAME. This kind of makes sense, because the stat(2)
struct lacks information about the file name.
¹ https://sources.debian.org/src/apr/1.6.5-1/file_io/unix/filestat.c/
-- Damyan
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: [RELEASE CANDIDATE] mod_perl-2.0.11 RC2
Posted by Damyan Ivanov <dm...@debian.org>.
-=| Steve Hay, 25.09.2019 08:34:07 +0100 |=-
> What happens if you revert the change in that file? I.e. Change
> FINFO_NAME back to FINFO_NORM on line 168, and on line 18 (the
> APR::Const -compile line)? Does that fix it for you?
With these two lines reverted, all tests pass for me (and the Debian
package finished building. Yay!).
-- Damyan
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: [RELEASE CANDIDATE] mod_perl-2.0.11 RC2
Posted by Damyan Ivanov <dm...@debian.org>.
-=| Steve Hay, 25.09.2019 08:34:07 +0100 |=-
> What happens if you revert the change in that file? I.e. Change
> FINFO_NAME back to FINFO_NORM on line 168, and on line 18 (the
> APR::Const -compile line)? Does that fix it for you?
With these two lines reverted, all tests pass for me (and the Debian
package finished building. Yay!).
-- Damyan
Re: [RELEASE CANDIDATE] mod_perl-2.0.11 RC2
Posted by Adam Prime <ad...@utoronto.ca>.
>
> What happens if you revert the change in that file? I.e. Change
> FINFO_NAME back to FINFO_NORM on line 168, and on line 18 (the
> APR::Const -compile line)? Does that fix it for you?
>
With that change all the request_rec tests run and pass.
Adam
Re: [RELEASE CANDIDATE] mod_perl-2.0.11 RC2
Posted by Steve Hay <st...@googlemail.com.INVALID>.
On Wed, 25 Sep 2019 at 03:59, Adam Prime <ad...@utoronto.ca> wrote:
>
> Still seeing the t/api/request_rec.t failures, which do not occur with
> the same machine and same settings with 2.0.10. It's failing after the
> mtime test, before the finfo test.
>
> Test Summary Report
> -------------------
> t/api/request_rec.t (Wstat: 0 Tests: 43 Failed: 0)
> Parse errors: Bad plan. You planned 55 tests but ran 43.
> t/filter/in_bbs_inject_header.t (Wstat: 0 Tests: 36 Failed: 3)
> Failed tests: 22, 26, 30
> Files=245, Tests=3402, 98 wallclock secs ( 0.71 usr 0.30 sys + 67.05
> cusr 12.05 csys = 80.11 CPU)
> Result: FAIL
> Failed 2/245 test programs. 3/3402 subtests failed.
>
>
> This is what i see in the error_log:
>
> [Tue Sep 24 22:56:10.012601 2019] [perl:error] [pid 743] [client
> 127.0.0.1:57720] APR::Finfo::stat: (70008) Partial results are valid but
> processing is incomplete at
> /tmp/mod_perl-2.0.11-rc2/t/response/TestAPI/request_rec.pm line 168
>
> Not sure if this is a concern or not, but it seems like it should be?
>
Yes, it's definitely a concern! We have two reports of exactly the
same failure now - this and the one from Damyan Ivanov.
This is exactly the kind of problem that I was getting with libapr's
apr_stat() function (see
https://bz.apache.org/bugzilla/show_bug.cgi?id=51560), which I fixed
for Windows in rev. 1865449. As noted before I do see various test
failures on Windows, but none relating to apr_stat() now, and I don't
get any api/request_rec.t failure at all.
This seems to imply either that other OSes are getting similar
problems that need working around similarly to Windows, or else that
the Windows fixes I've applied have broken other OSes. In this case
I'm wondering if it might the latter:-
The rev. cited above changed exactly the line that the failure is
reported on - line 168 in t/response/TestAPI/request_rec.pm... I
changed FINFO_NORM to FINFO_NAME since it's only fname that we access
so we shouldn't need all the other fields. (Windows has a problem
getting all the fields (specifically, it often fails on the
APR_FINFO_GPROT and APR_FINFO_WPROT bits) so that change dodged the
problem for me.)
What happens if you revert the change in that file? I.e. Change
FINFO_NAME back to FINFO_NORM on line 168, and on line 18 (the
APR::Const -compile line)? Does that fix it for you?
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: [RELEASE CANDIDATE] mod_perl-2.0.11 RC2
Posted by Steve Hay <st...@googlemail.com>.
On Wed, 25 Sep 2019 at 03:59, Adam Prime <ad...@utoronto.ca> wrote:
>
> Still seeing the t/api/request_rec.t failures, which do not occur with
> the same machine and same settings with 2.0.10. It's failing after the
> mtime test, before the finfo test.
>
> Test Summary Report
> -------------------
> t/api/request_rec.t (Wstat: 0 Tests: 43 Failed: 0)
> Parse errors: Bad plan. You planned 55 tests but ran 43.
> t/filter/in_bbs_inject_header.t (Wstat: 0 Tests: 36 Failed: 3)
> Failed tests: 22, 26, 30
> Files=245, Tests=3402, 98 wallclock secs ( 0.71 usr 0.30 sys + 67.05
> cusr 12.05 csys = 80.11 CPU)
> Result: FAIL
> Failed 2/245 test programs. 3/3402 subtests failed.
>
>
> This is what i see in the error_log:
>
> [Tue Sep 24 22:56:10.012601 2019] [perl:error] [pid 743] [client
> 127.0.0.1:57720] APR::Finfo::stat: (70008) Partial results are valid but
> processing is incomplete at
> /tmp/mod_perl-2.0.11-rc2/t/response/TestAPI/request_rec.pm line 168
>
> Not sure if this is a concern or not, but it seems like it should be?
>
Yes, it's definitely a concern! We have two reports of exactly the
same failure now - this and the one from Damyan Ivanov.
This is exactly the kind of problem that I was getting with libapr's
apr_stat() function (see
https://bz.apache.org/bugzilla/show_bug.cgi?id=51560), which I fixed
for Windows in rev. 1865449. As noted before I do see various test
failures on Windows, but none relating to apr_stat() now, and I don't
get any api/request_rec.t failure at all.
This seems to imply either that other OSes are getting similar
problems that need working around similarly to Windows, or else that
the Windows fixes I've applied have broken other OSes. In this case
I'm wondering if it might the latter:-
The rev. cited above changed exactly the line that the failure is
reported on - line 168 in t/response/TestAPI/request_rec.pm... I
changed FINFO_NORM to FINFO_NAME since it's only fname that we access
so we shouldn't need all the other fields. (Windows has a problem
getting all the fields (specifically, it often fails on the
APR_FINFO_GPROT and APR_FINFO_WPROT bits) so that change dodged the
problem for me.)
What happens if you revert the change in that file? I.e. Change
FINFO_NAME back to FINFO_NORM on line 168, and on line 18 (the
APR::Const -compile line)? Does that fix it for you?
Re: [RELEASE CANDIDATE] mod_perl-2.0.11 RC2
Posted by Steve Hay <st...@googlemail.com.INVALID>.
On Wed, 25 Sep 2019 at 03:59, Adam Prime <ad...@utoronto.ca> wrote:
>
> Still seeing the t/api/request_rec.t failures, which do not occur with
> the same machine and same settings with 2.0.10. It's failing after the
> mtime test, before the finfo test.
>
> Test Summary Report
> -------------------
> t/api/request_rec.t (Wstat: 0 Tests: 43 Failed: 0)
> Parse errors: Bad plan. You planned 55 tests but ran 43.
> t/filter/in_bbs_inject_header.t (Wstat: 0 Tests: 36 Failed: 3)
> Failed tests: 22, 26, 30
> Files=245, Tests=3402, 98 wallclock secs ( 0.71 usr 0.30 sys + 67.05
> cusr 12.05 csys = 80.11 CPU)
> Result: FAIL
> Failed 2/245 test programs. 3/3402 subtests failed.
>
>
(Btw, the filter/in_bbs_inject_header.t failures are an existing
problem - see https://rt.cpan.org/Ticket/Display.html?id=118919)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: [RELEASE CANDIDATE] mod_perl-2.0.11 RC2
Posted by Steve Hay <st...@googlemail.com>.
On Wed, 25 Sep 2019 at 03:59, Adam Prime <ad...@utoronto.ca> wrote:
>
> Still seeing the t/api/request_rec.t failures, which do not occur with
> the same machine and same settings with 2.0.10. It's failing after the
> mtime test, before the finfo test.
>
> Test Summary Report
> -------------------
> t/api/request_rec.t (Wstat: 0 Tests: 43 Failed: 0)
> Parse errors: Bad plan. You planned 55 tests but ran 43.
> t/filter/in_bbs_inject_header.t (Wstat: 0 Tests: 36 Failed: 3)
> Failed tests: 22, 26, 30
> Files=245, Tests=3402, 98 wallclock secs ( 0.71 usr 0.30 sys + 67.05
> cusr 12.05 csys = 80.11 CPU)
> Result: FAIL
> Failed 2/245 test programs. 3/3402 subtests failed.
>
>
(Btw, the filter/in_bbs_inject_header.t failures are an existing
problem - see https://rt.cpan.org/Ticket/Display.html?id=118919)
Re: [RELEASE CANDIDATE] mod_perl-2.0.11 RC2
Posted by Adam Prime <ad...@utoronto.ca>.
Still seeing the t/api/request_rec.t failures, which do not occur with
the same machine and same settings with 2.0.10. It's failing after the
mtime test, before the finfo test.
Test Summary Report
-------------------
t/api/request_rec.t (Wstat: 0 Tests: 43 Failed: 0)
Parse errors: Bad plan. You planned 55 tests but ran 43.
t/filter/in_bbs_inject_header.t (Wstat: 0 Tests: 36 Failed: 3)
Failed tests: 22, 26, 30
Files=245, Tests=3402, 98 wallclock secs ( 0.71 usr 0.30 sys + 67.05
cusr 12.05 csys = 80.11 CPU)
Result: FAIL
Failed 2/245 test programs. 3/3402 subtests failed.
This is what i see in the error_log:
[Tue Sep 24 22:56:10.012601 2019] [perl:error] [pid 743] [client
127.0.0.1:57720] APR::Finfo::stat: (70008) Partial results are valid but
processing is incomplete at
/tmp/mod_perl-2.0.11-rc2/t/response/TestAPI/request_rec.pm line 168
Not sure if this is a concern or not, but it seems like it should be?
Adam
On 9/24/19 12:53 PM, Steve Hay wrote:
> Please download, test, and report back on this mod_perl 2.0.11 release
> candidate.
>
> https://dist.apache.org/repos/dist/dev/perl/mod_perl-2.0.11-rc2.tar.gz
>
> MD5 = abc2c2168121a09b0fc3b6fc6adc00bd
> SHA1 = 36ee7626506a3a461118b3957814dfe9331ef1de
>
> Changes since RC1 are as follows:
>
> Fix [CVE-2011-2767] Arbitrary Perl code execution in the context of the user
> account via a user-owned .htaccess. Patch from bugs.debian.org #644169. [Jan
> Ingvoldstad <ja...@ifi.uio.no>]
>
> Fix potential test suite hangs due to pipelined response deadlocks. Patch
> from rt.cpan.org #82409. [Zefram <ze...@fysh.org>]
>
> Fix t/compat/request.t failures [Steve Hay]
>
Re: [RELEASE CANDIDATE] mod_perl-2.0.11 RC2
Posted by Damyan Ivanov <dm...@debian.org>.
(Cc-ing Debian Perl group in case I missed something obvious)
-=| Steve Hay, 24.09.2019 17:53:14 +0100 |=-
> Please download, test, and report back on this mod_perl 2.0.11 release
> candidate.
>
> https://dist.apache.org/repos/dist/dev/perl/mod_perl-2.0.11-rc2.tar.gz
One test fails on Debian unstable/amd64.
-------------8<---------- Start Bug Report ------------8<----------
1. Problem Description:
…
# testing : mtime
# expected: 1569347574
# received: '1569347574'
ok 43
<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML 2.0//EN">
<html><head>
<title>500 Internal Server Error</title>
</head><body>
<h1>Internal Server Error</h1>
<p>The server encountered an internal error or
misconfiguration and was unable to complete
your request.</p>
<p>Please contact the server administrator at
dam@localhost to inform them of the time this error occurred,
and the actions you performed just before this error.</p>
<p>More information about this error may be available
in the server error log.</p>
<hr>
<address>Apache/2.4.41 (Debian) world domination series/2.0 mod_apreq2-20090110/2.8.0 mod_perl/2.0.11-rc2 Perl/v5.28.1 Server at localhost Port 8529</address>
</body></html>
Failed 12/55 subtests
Test Summary Report
-------------------
t/api/request_rec.t (Wstat: 0 Tests: 43 Failed: 0)
Parse errors: Bad plan. You planned 55 tests but ran 43.
Files=1, Tests=43, 0 wallclock secs ( 0.02 usr 0.00 sys + 0.46 cusr 0.13 csys = 0.61 CPU)
Result: FAIL
error_log:
(full log for request_rec.t attached)
[Tue Sep 24 21:55:53.589476 2019] [perl:error] [pid 1184:tid 140271230908160] [client 127.0.0.1:40218] APR::Finfo::stat: (70008) Partial results are valid but processing is incomplete at /home/dam/w/pkg-perl/packages/libapache2-mod-perl2/t/response/TestAPI/request_rec.pm line 168
Note that in Debian apache, apreq and mod_perl have plenty of patches
applied. That wasn't a problem by itself before, but I'd rather
mention it here to avoid surprises.
This report is about the RC2 tarball with all the patches at
https://salsa.debian.org/perl-team/modules/packages/libapache2-mod-perl2/tree/master/debian/patches
minus
260_fix_pipelined_response_deadlock.patch,
370_http_syntax.patch,
380_inject_header_line_terminators.patch, and
CVE-2011-2767.patch
that were included in this RC2 release (thanks!)
2. Used Components and their Configuration:
*** mod_perl version 2.000011
*** using /home/dam/w/pkg-perl/packages/libapache2-mod-perl2/lib/Apache2/BuildConfig.pm
*** Makefile.PL options:
MP_APR_CONFIG => /usr/bin/apr-config
MP_APR_LIB => aprext
MP_APXS => /usr/bin/apxs
MP_CCOPTS => -g -O2 -fdebug-prefix-map=/home/dam/w/pkg-perl/packages/libapache2-mod-perl2=. -fstack-protector-strong -Wformat -Werror=format-security -Wall -fgnu89-inline
MP_COMPAT_1X => 1
MP_GENERATE_XS => 1
MP_LIBNAME => mod_perl
MP_TRACE => 0
MP_USE_DSO => 1
MP_USE_STATIC => 0
*** /usr/sbin/apache2 -V
Server version: Apache/2.4.41 (Debian)
Server built: 2019-08-14T04:42:29
Server's Module Magic Number: 20120211:88
Server loaded: APR 1.6.5, APR-UTIL 1.6.1
Compiled using: APR 1.6.5, APR-UTIL 1.6.1
Architecture: 64-bit
Server MPM:
Server compiled with....
-D APR_HAS_SENDFILE
-D APR_HAS_MMAP
-D APR_HAVE_IPV6 (IPv4-mapped addresses enabled)
-D APR_USE_SYSVSEM_SERIALIZE
-D APR_USE_PTHREAD_SERIALIZE
-D SINGLE_LISTEN_UNSERIALIZED_ACCEPT
-D APR_HAS_OTHER_CHILD
-D AP_HAVE_RELIABLE_PIPED_LOGS
-D DYNAMIC_MODULE_LIMIT=256
-D HTTPD_ROOT="/etc/apache2"
-D SUEXEC_BIN="/usr/lib/apache2/suexec"
-D DEFAULT_PIDLOG="/var/run/apache2.pid"
-D DEFAULT_SCOREBOARD="logs/apache_runtime_status"
-D DEFAULT_ERRORLOG="logs/error_log"
-D AP_TYPES_CONFIG_FILE="mime.types"
-D SERVER_CONFIG_FILE="apache2.conf"
*** /usr/bin/ldd /usr/sbin/apache2
linux-vdso.so.1 (0x00007ffc791c9000)
libpcre.so.3 => /lib/x86_64-linux-gnu/libpcre.so.3 (0x00007f145fe89000)
libaprutil-1.so.0 => /usr/lib/x86_64-linux-gnu/libaprutil-1.so.0 (0x00007f145fe5b000)
libapr-1.so.0 => /usr/lib/x86_64-linux-gnu/libapr-1.so.0 (0x00007f145fe22000)
libpthread.so.0 => /lib/x86_64-linux-gnu/libpthread.so.0 (0x00007f145fe01000)
libc.so.6 => /lib/x86_64-linux-gnu/libc.so.6 (0x00007f145fc41000)
libuuid.so.1 => /lib/x86_64-linux-gnu/libuuid.so.1 (0x00007f145fc38000)
librt.so.1 => /lib/x86_64-linux-gnu/librt.so.1 (0x00007f145fc2b000)
libcrypt.so.1 => /lib/x86_64-linux-gnu/libcrypt.so.1 (0x00007f145fbf2000)
libdl.so.2 => /lib/x86_64-linux-gnu/libdl.so.2 (0x00007f145fbed000)
libexpat.so.1 => /lib/x86_64-linux-gnu/libexpat.so.1 (0x00007f145fbc0000)
/lib64/ld-linux-x86-64.so.2 (0x00007f145ffcc000)
*** (apr|apu)-config linking info
-L/usr/lib/x86_64-linux-gnu -laprutil-1
-L/usr/lib/x86_64-linux-gnu -lapr-1
*** /usr/bin/perl -V
Summary of my perl5 (revision 5 version 28 subversion 1) configuration:
Platform:
osname=linux
osvers=4.9.0
archname=x86_64-linux-gnu-thread-multi
uname='linux localhost 4.9.0 #1 smp debian 4.9.0 x86_64 gnulinux '
config_args='-Dusethreads -Duselargefiles -Dcc=x86_64-linux-gnu-gcc -Dcpp=x86_64-linux-gnu-cpp -Dld=x86_64-linux-gnu-gcc -Dccflags=-DDEBIAN -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -fdebug-prefix-map=/build/perl-5WfRyb/perl-5.28.1=. -fstack-protector-strong -Wformat -Werror=format-security -Dldflags= -Wl,-z,relro -Dlddlflags=-shared -Wl,-z,relro -Dcccdlflags=-fPIC -Darchname=x86_64-linux-gnu -Dprefix=/usr -Dprivlib=/usr/share/perl/5.28 -Darchlib=/usr/lib/x86_64-linux-gnu/perl/5.28 -Dvendorprefix=/usr -Dvendorlib=/usr/share/perl5 -Dvendorarch=/usr/lib/x86_64-linux-gnu/perl5/5.28 -Dsiteprefix=/usr/local -Dsitelib=/usr/local/share/perl/5.28.1 -Dsitearch=/usr/local/lib/x86_64-linux-gnu/perl/5.28.1 -Dman1dir=/usr/share/man/man1 -Dman3dir=/usr/share/man/man3 -Dsiteman1dir=/usr/local/man/man1 -Dsiteman3dir=/usr/local/man/man3 -Duse64bitint -Dman1ext=1 -Dman3ext=3perl -Dpager=/usr/bin/sensible-pager -Uafs -Ud_csh -Ud_ualarm -Uusesfio -Uusenm -Ui_libutil -Ui_xlocale -Uversiononly -DDEBUGGING=-g -Doptimize=-O2 -dEs -Duseshrplib -Dlibperl=libperl.so.5.28.1'
hint=recommended
useposix=true
d_sigaction=define
useithreads=define
usemultiplicity=define
use64bitint=define
use64bitall=define
uselongdouble=undef
usemymalloc=n
default_inc_excludes_dot=define
bincompat5005=undef
Compiler:
cc='x86_64-linux-gnu-gcc'
ccflags ='-D_REENTRANT -D_GNU_SOURCE -DDEBIAN -fwrapv -fno-strict-aliasing -pipe -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64'
optimize='-O2 -g'
cppflags='-D_REENTRANT -D_GNU_SOURCE -DDEBIAN -fwrapv -fno-strict-aliasing -pipe -I/usr/local/include'
ccversion=''
gccversion='8.3.0'
gccosandvers=''
intsize=4
longsize=8
ptrsize=8
doublesize=8
byteorder=12345678
doublekind=3
d_longlong=define
longlongsize=8
d_longdbl=define
longdblsize=16
longdblkind=3
ivtype='long'
ivsize=8
nvtype='double'
nvsize=8
Off_t='off_t'
lseeksize=8
alignbytes=8
prototype=define
Linker and Libraries:
ld='x86_64-linux-gnu-gcc'
ldflags =' -fstack-protector-strong -L/usr/local/lib'
libpth=/usr/local/lib /usr/lib/gcc/x86_64-linux-gnu/8/include-fixed /usr/include/x86_64-linux-gnu /usr/lib /lib/x86_64-linux-gnu /lib/../lib /usr/lib/x86_64-linux-gnu /usr/lib/../lib /lib
libs=-lgdbm -lgdbm_compat -ldb -ldl -lm -lpthread -lc -lcrypt
perllibs=-ldl -lm -lpthread -lc -lcrypt
libc=libc-2.28.so
so=so
useshrplib=true
libperl=libperl.so.5.28
gnulibc_version='2.28'
Dynamic Linking:
dlsrc=dl_dlopen.xs
dlext=so
d_dlsymun=undef
ccdlflags='-Wl,-E'
cccdlflags='-fPIC'
lddlflags='-shared -L/usr/local/lib -fstack-protector-strong'
Characteristics of this binary (from libperl):
Compile-time options:
HAS_TIMES
MULTIPLICITY
PERLIO_LAYERS
PERL_COPY_ON_WRITE
PERL_DONT_CREATE_GVSV
PERL_IMPLICIT_CONTEXT
PERL_MALLOC_WRAP
PERL_OP_PARENT
PERL_PRESERVE_IVUV
USE_64_BIT_ALL
USE_64_BIT_INT
USE_ITHREADS
USE_LARGE_FILES
USE_LOCALE
USE_LOCALE_COLLATE
USE_LOCALE_CTYPE
USE_LOCALE_NUMERIC
USE_LOCALE_TIME
USE_PERLIO
USE_PERL_ATOF
USE_REENTRANT_API
Locally applied patches:
DEBPKG:debian/cpan_definstalldirs - Provide a sensible INSTALLDIRS default for modules installed from CPAN.
DEBPKG:debian/db_file_ver - https://bugs.debian.org/340047 Remove overly restrictive DB_File version check.
DEBPKG:debian/doc_info - Replace generic man(1) instructions with Debian-specific information.
DEBPKG:debian/enc2xs_inc - https://bugs.debian.org/290336 Tweak enc2xs to follow symlinks and ignore missing @INC directories.
DEBPKG:debian/errno_ver - https://bugs.debian.org/343351 Remove Errno version check due to upgrade problems with long-running processes.
DEBPKG:debian/libperl_embed_doc - https://bugs.debian.org/186778 Note that libperl-dev package is required for embedded linking
DEBPKG:fixes/respect_umask - Respect umask during installation
DEBPKG:debian/writable_site_dirs - Set umask approproately for site install directories
DEBPKG:debian/extutils_set_libperl_path - EU:MM: set location of libperl.a under /usr/lib
DEBPKG:debian/no_packlist_perllocal - Don't install .packlist or perllocal.pod for perl or vendor
DEBPKG:debian/fakeroot - Postpone LD_LIBRARY_PATH evaluation to the binary targets.
DEBPKG:debian/instmodsh_doc - Debian policy doesn't install .packlist files for core or vendor.
DEBPKG:debian/ld_run_path - Remove standard libs from LD_RUN_PATH as per Debian policy.
DEBPKG:debian/libnet_config_path - Set location of libnet.cfg to /etc/perl/Net as /usr may not be writable.
DEBPKG:debian/perlivp - https://bugs.debian.org/510895 Make perlivp skip include directories in /usr/local
DEBPKG:debian/squelch-locale-warnings - https://bugs.debian.org/508764 Squelch locale warnings in Debian package maintainer scripts
DEBPKG:debian/patchlevel - https://bugs.debian.org/567489 List packaged patches for 5.28.1-6 in patchlevel.h
DEBPKG:fixes/document_makemaker_ccflags - https://bugs.debian.org/628522 [rt.cpan.org #68613] Document that CCFLAGS should include $Config{ccflags}
DEBPKG:debian/find_html2text - https://bugs.debian.org/640479 Configure CPAN::Distribution with correct name of html2text
DEBPKG:debian/perl5db-x-terminal-emulator.patch - https://bugs.debian.org/668490 Invoke x-terminal-emulator rather than xterm in perl5db.pl
DEBPKG:debian/cpan-missing-site-dirs - https://bugs.debian.org/688842 Fix CPAN::FirstTime defaults with nonexisting site dirs if a parent is writable
DEBPKG:fixes/memoize_storable_nstore - [rt.cpan.org #77790] https://bugs.debian.org/587650 Memoize::Storable: respect 'nstore' option not respected
DEBPKG:debian/makemaker-pasthru - https://bugs.debian.org/758471 Pass LD settings through to subdirectories
DEBPKG:debian/makemaker-manext - https://bugs.debian.org/247370 Make EU::MakeMaker honour MANnEXT settings in generated manpage headers
DEBPKG:debian/kfreebsd-softupdates - https://bugs.debian.org/796798 Work around Debian Bug#796798
DEBPKG:fixes/autodie-scope - https://bugs.debian.org/798096 Fix a scoping issue with "no autodie" and the "system" sub
DEBPKG:fixes/memoize-pod - [rt.cpan.org #89441] Fix POD errors in Memoize
DEBPKG:debian/hurd-softupdates - https://bugs.debian.org/822735 Fix t/op/stat.t failures on hurd
DEBPKG:fixes/math_complex_doc_great_circle - https://bugs.debian.org/697567 [rt.cpan.org #114104] Math::Trig: clarify definition of great_circle_midpoint
DEBPKG:fixes/math_complex_doc_see_also - https://bugs.debian.org/697568 [rt.cpan.org #114105] Math::Trig: add missing SEE ALSO
DEBPKG:fixes/math_complex_doc_angle_units - https://bugs.debian.org/731505 [rt.cpan.org #114106] Math::Trig: document angle units
DEBPKG:fixes/cpan_web_link - https://bugs.debian.org/367291 CPAN: Add link to main CPAN web site
DEBPKG:debian/hppa_op_optimize_workaround - https://bugs.debian.org/838613 Temporarily lower the optimization of op.c on hppa due to gcc-6 problems
DEBPKG:debian/installman-utf8 - https://bugs.debian.org/840211 Generate man pages with UTF-8 characters
DEBPKG:fixes/getopt-long-4 - https://bugs.debian.org/864544 [rt.cpan.org #122068] Fix issue #122068.
DEBPKG:debian/hppa_opmini_optimize_workaround - https://bugs.debian.org/869122 Lower the optimization level of opmini.c on hppa
DEBPKG:debian/sh4_op_optimize_workaround - https://bugs.debian.org/869373 Also lower the optimization level of op.c and opmini.c on sh4
DEBPKG:debian/perldoc-pager - https://bugs.debian.org/870340 [rt.cpan.org #120229] Fix perldoc terminal escapes when sensible-pager is less
DEBPKG:debian/prune_libs - https://bugs.debian.org/128355 Prune the list of libraries wanted to what we actually need.
DEBPKG:debian/mod_paths - Tweak @INC ordering for Debian
DEBPKG:debian/configure-regen - https://bugs.debian.org/762638 Regenerate Configure et al. after probe unit changes
DEBPKG:debian/deprecate-with-apt - https://bugs.debian.org/747628 Point users to Debian packages of deprecated core modules
DEBPKG:debian/disable-stack-check - https://bugs.debian.org/902779 [perl #133327] Disable debugperl stack extension checks for binary compatibility with perl
DEBPKG:debian/gdbm-fatal - [perl #133295] https://bugs.debian.org/904005 Temporarily skip GDBM_File fatal.t for gdbm >= 1.15 compatibility
DEBPKG:fixes/storable-recursion - https://bugs.debian.org/912900 [perl #133326] [120060c] (perl #133326) fix and clarify handling of recurs_sv.
DEBPKG:fixes/caretx-fallback - https://bugs.debian.org/913347 [perl #133573] [03b94aa] RT#133573: $^X fallback when platform-specific technique fails
DEBPKG:fixes/eumm-usrmerge - https://bugs.debian.org/913637 Avoid mangling /bin non-perl shebangs on merged-/usr systems
DEBPKG:fixes/errno-include-path - [6c5080f] [perl #133662] https://bugs.debian.org/875921 Make Errno_pm.PL compatible with /usr/include/<ARCH>/errno.h
DEBPKG:fixes/kfreebsd-renameat - [a3c63a9] https://bugs.debian.org/912521 [perl #133668] Also work around renameat() kernel bug on GNU/kFreeBSD
DEBPKG:fixes/time-local-2020 - https://bugs.debian.org/915209 [rt.cpan.org #124787] Fix Time::Local tests
DEBPKG:fixes/inplace-editing-bugfix/part1 - https://bugs.debian.org/914651 (perl #133659) move argvout cleanup to a new function
DEBPKG:fixes/inplace-editing-bugfix/part2 - https://bugs.debian.org/914651 (perl #133659) tests for global destruction handling of inplace editing
DEBPKG:fixes/inplace-editing-bugfix/part3 - https://bugs.debian.org/914651 (perl #133659) make an in-place edit successful if the exit status is zero
DEBPKG:fixes/fix-manifest-failures - https://bugs.debian.org/914962 Fix t/porting/manifest.t failures when run in a foreign git checkout
DEBPKG:fixes/pipe-open-bugfix/part1 - [perl #133726] https://bugs.debian.org/916313 Always mark pipe in pipe-open as inherit-on-exec
DEBPKG:fixes/pipe-open-bugfix/part2 - [perl #133726] https://bugs.debian.org/916313 Always mark pipe in list pipe-open as inherit-on-exec
DEBPKG:fixes/storable-probing/prereq1 - [3f4cad1] Storable: fix for strawberry build failures:
DEBPKG:fixes/storable-probing/prereq2 - [perl #133411] [edf639f] (perl #133411) don't try to load Storable with -Dusecrosscompile
DEBPKG:fixes/storable-probing/disable-probing - https://bugs.debian.org/914133 [perl #133708] [2a0bbd3] (perl #133708) remove build-time probing for stack limits for Storable
DEBPKG:debian/perlbug-editor - https://bugs.debian.org/922609 Use "editor" as the default perlbug editor, as per Debian policy
DEBPKG:fixes/posix-mbrlen - [25d7b7a] https://bugs.debian.org/924517 [perl #133928] Fix POSIX::mblen mbstate_t initialization on threaded perls with glibc
Built under linux
Compiled at Mar 31 2019 11:51:22
%ENV:
PERL_LWP_USE_HTTP_10="1"
@INC:
/etc/perl
/usr/local/lib/x86_64-linux-gnu/perl/5.28.1
/usr/local/share/perl/5.28.1
/usr/lib/x86_64-linux-gnu/perl5/5.28
/usr/share/perl5
/usr/lib/x86_64-linux-gnu/perl/5.28
/usr/share/perl/5.28
/usr/local/lib/site_perl
/usr/lib/x86_64-linux-gnu/perl-base
*** Packages of interest status:
Apache2 : 2.4.41
Apache2::Request : 2.13
CGI : 4.44
ExtUtils::MakeMaker: 7.34
LWP : 6.39
mod_perl : -
mod_perl2 : 2.000010
3. This is the core dump trace: (if you get a core dump):
[CORE TRACE COMES HERE]
This report was generated by t/REPORT on Tue Sep 24 19:03:05 2019 GMT.
-------------8<---------- End Bug Report --------------8<----------
Re: [RELEASE CANDIDATE] mod_perl-2.0.11 RC2
Posted by Adam Prime <ad...@utoronto.ca>.
Still seeing the t/api/request_rec.t failures, which do not occur with
the same machine and same settings with 2.0.10. It's failing after the
mtime test, before the finfo test.
Test Summary Report
-------------------
t/api/request_rec.t (Wstat: 0 Tests: 43 Failed: 0)
Parse errors: Bad plan. You planned 55 tests but ran 43.
t/filter/in_bbs_inject_header.t (Wstat: 0 Tests: 36 Failed: 3)
Failed tests: 22, 26, 30
Files=245, Tests=3402, 98 wallclock secs ( 0.71 usr 0.30 sys + 67.05
cusr 12.05 csys = 80.11 CPU)
Result: FAIL
Failed 2/245 test programs. 3/3402 subtests failed.
This is what i see in the error_log:
[Tue Sep 24 22:56:10.012601 2019] [perl:error] [pid 743] [client
127.0.0.1:57720] APR::Finfo::stat: (70008) Partial results are valid but
processing is incomplete at
/tmp/mod_perl-2.0.11-rc2/t/response/TestAPI/request_rec.pm line 168
Not sure if this is a concern or not, but it seems like it should be?
Adam
On 9/24/19 12:53 PM, Steve Hay wrote:
> Please download, test, and report back on this mod_perl 2.0.11 release
> candidate.
>
> https://dist.apache.org/repos/dist/dev/perl/mod_perl-2.0.11-rc2.tar.gz
>
> MD5 = abc2c2168121a09b0fc3b6fc6adc00bd
> SHA1 = 36ee7626506a3a461118b3957814dfe9331ef1de
>
> Changes since RC1 are as follows:
>
> Fix [CVE-2011-2767] Arbitrary Perl code execution in the context of the user
> account via a user-owned .htaccess. Patch from bugs.debian.org #644169. [Jan
> Ingvoldstad <ja...@ifi.uio.no>]
>
> Fix potential test suite hangs due to pipelined response deadlocks. Patch
> from rt.cpan.org #82409. [Zefram <ze...@fysh.org>]
>
> Fix t/compat/request.t failures [Steve Hay]
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: [RELEASE CANDIDATE] mod_perl-2.0.11 RC2
Posted by Румен Палов <rp...@e-card.bg>.
Hello Steve,
I have tested it in two ways:
1) Installation via freebsd port system via fooling the port about
distro checksum.
Installed successful on
1) FreeBSD 11.2-STABLE
2) apache-2.4.37
3) perl 5, version 26
Installation via port is made without modifying t/ files ( F_NAME ->
F_NORM )
Application looks to work without issues.
If we spot some errors I will write here.
2) I ran tests after modification in t files F_NAME -> F_NORM, as
suggest in this thread. The results are bellow:
> t/apache/add_config.t ................... ok
> t/apache/cgihandler.t ................... ok
> t/apache/conftree.t ..................... ok
> t/apache/constants.t .................... ok
> t/apache/content_length_header.t ........ ok
> t/apache/daemon.t ....................... ok
> t/apache/discard_rbody.t ................ ok
> t/apache/post.t ......................... ok
> t/apache/read.t ......................... ok
> t/apache/read2.t ........................ ok
> t/apache/read3.t ........................ ok
> t/apache/read4.t ........................ ok
> t/apache/scanhdrs.t ..................... ok
> t/apache/scanhdrs2.t .................... ok
> t/apache/send_cgi_header.t .............. ok
> t/apache/subprocess.t ................... ok
> t/apache/util.t ......................... ok
> t/apache/write.t ........................ ok
> t/api/access.t .......................... ok
> t/api/access2.t ......................... skipped: mod_perl is not compiled with httpd-2.2
> t/api/access2_24.t ...................... ok
> t/api/add_config.t ...................... ok
> t/api/aplog.t ........................... ok
> t/api/command.t ......................... ok
> t/api/conn_rec.t ........................ ok
> t/api/conn_util.t ....................... ok
> t/api/content_encoding.t ................ ok
> t/api/custom_response.t ................. ok
> t/api/err_headers_out.t ................. ok
> t/api/in_out_filters.t .................. ok
> t/api/internal_redirect.t ............... ok
> t/api/internal_redirect_handler.t ....... ok
> t/api/lookup_misc.t ..................... ok
> t/api/lookup_uri.t ...................... ok
> t/api/lookup_uri2.t ..................... ok
> t/api/module.t .......................... ok
> t/api/process.t ......................... ok
> t/api/query.t ........................... ok
> t/api/request_rec.t ..................... ok
> t/api/request_subclass.t ................ ok
> t/api/request_util.t .................... ok
> t/api/response.t ........................ ok
> t/api/rflush.t .......................... ok
> t/api/sendfile.t ........................ ok
> t/api/server_const.t .................... ok
> t/api/server_rec.t ...................... ok
> t/api/server_util.t ..................... ok
> t/api/show.t ............................ ok
> t/api/slurp_filename.t .................. ok
> t/api/status.t .......................... ok
> t/api/sub_request.t ..................... ok
> t/api/uri.t ............................. ok
> t/apr-ext/base64.t ...................... ok
> t/apr-ext/brigade.t ..................... ok
> t/apr-ext/bucket.t ...................... ok
> t/apr-ext/date.t ........................ ok
> t/apr-ext/error.t ....................... ok
> t/apr-ext/finfo.t ....................... ok
> t/apr-ext/os.t .......................... ok
> t/apr-ext/pool.t ........................ ok
> t/apr-ext/status.t ...................... ok
> t/apr-ext/string.t ...................... ok
> t/apr-ext/table.t ....................... ok
> t/apr-ext/threadmutex.t ................. ok
> t/apr-ext/threadrwlock.t ................ ok
> t/apr-ext/uri.t ......................... ok
> t/apr-ext/util.t ........................ ok
> t/apr-ext/uuid.t ........................ ok
> t/apr/base64.t .......................... ok
> t/apr/brigade.t ......................... ok
> t/apr/bucket.t .......................... ok
> t/apr/constants.t ....................... ok
> t/apr/date.t ............................ ok
> t/apr/finfo.t ........................... ok
> t/apr/flatten.t ......................... ok
> t/apr/ipsubnet.t ........................ ok
> t/apr/os.t .............................. ok
> t/apr/perlio.t .......................... ok
> t/apr/pool.t ............................ ok
> t/apr/pool_lifetime.t ................... ok
> t/apr/sockaddr.t ........................ ok
> t/apr/socket.t .......................... ok
> t/apr/status.t .......................... ok
> t/apr/string.t .......................... ok
> t/apr/table.t ........................... ok
> t/apr/threadmutex.t ..................... ok
> t/apr/threadrwlock.t .................... ok
> t/apr/uri.t ............................. ok
> t/apr/util.t ............................ ok
> t/apr/uuid.t ............................ ok
> t/compat/apache.t ....................... ok
> t/compat/apache_file.t .................. ok
> t/compat/apache_module.t ................ ok
> t/compat/apache_table.t ................. ok
> t/compat/apache_uri.t ................... ok
> t/compat/apache_util.t .................. ok
> t/compat/conn_authen.t .................. ok
> t/compat/conn_rec.t ..................... ok
> t/compat/request.t ...................... ok
> t/compat/request_body.t ................. ok
> t/compat/send_fd.t ...................... ok
> t/directive/cmdparms.t .................. ok
> t/directive/env.t ....................... ok
> t/directive/perl.t ...................... ok
> t/directive/perlcleanuphandler.t ........ ok
> t/directive/perldo.t .................... ok
> t/directive/perlloadmodule.t ............ ok
> t/directive/perlloadmodule2.t ........... ok
> t/directive/perlloadmodule3.t ........... ok
> t/directive/perlloadmodule4.t ........... ok
> t/directive/perlloadmodule5.t ........... ok
> t/directive/perlloadmodule6.t ........... ok
> t/directive/perlloadmodule7.t ........... ok
> t/directive/perlmodule.t ................ ok
> t/directive/perlrequire.t ............... ok
> t/directive/pod.t ....................... ok
> t/directive/setupenv.t .................. ok
> t/error/api.t ........................... ok
> t/error/runtime.t ....................... ok
> t/error/syntax.t ........................ ok
> t/filter/both_str_con_add.t ............. ok
> t/filter/both_str_native_remove.t ....... skipped: cannot find module 'include'
> t/filter/both_str_req_add.t ............. ok
> t/filter/both_str_req_mix.t ............. skipped: cannot find module 'include'
> t/filter/both_str_req_proxy.t ........... ok
> t/filter/in_autoload.t .................. ok
> t/filter/in_bbs_body.t .................. ok
> t/filter/in_bbs_consume.t ............... ok
> t/filter/in_bbs_inject_header.t ......... 1/? # Failed test 22 in t/filter/in_bbs_inject_header.t at line 58 fail #6
> # Failed test 26 in t/filter/in_bbs_inject_header.t at line 58 fail #7
> # Failed test 30 in t/filter/in_bbs_inject_header.t at line 58 fail #8
> t/filter/in_bbs_inject_header.t ......... Failed 3/36 subtests
> t/filter/in_bbs_msg.t ................... ok
> t/filter/in_bbs_underrun.t .............. ok
> t/filter/in_error.t ..................... ok
> t/filter/in_init_basic.t ................ ok
> t/filter/in_str_bin_data.t .............. ok
> t/filter/in_str_consume.t ............... ok
> t/filter/in_str_declined.t .............. ok
> t/filter/in_str_declined_read.t ......... ok
> t/filter/in_str_lc.t .................... ok
> t/filter/in_str_msg.t ................... ok
> t/filter/in_str_sandwich.t .............. ok
> t/filter/out_apache.t ................... skipped: cannot find module 'include'
> t/filter/out_bbs_basic.t ................ ok
> t/filter/out_bbs_ctx.t .................. ok
> t/filter/out_bbs_filebucket.t ........... ok
> t/filter/out_init_basic.t ............... ok
> t/filter/out_str_api.t .................. ok
> t/filter/out_str_buffer.t ............... ok
> t/filter/out_str_ctx.t .................. ok
> t/filter/out_str_declined.t ............. ok
> t/filter/out_str_eval.t ................. ok
> t/filter/out_str_lc.t ................... ok
> t/filter/out_str_remove.t ............... ok
> t/filter/out_str_req_eos.t .............. skipped: cannot find module 'include'
> t/filter/out_str_req_mix.t .............. skipped: cannot find module 'include'
> t/filter/out_str_reverse.t .............. ok
> t/filter/out_str_subreq_default.t ....... ok
> t/filter/out_str_subreq_modperl.t ....... ok
> t/filter/with_subrequest.t .............. ok
> t/hooks/access.t ........................ ok
> t/hooks/authen_basic.t .................. ok
> t/hooks/authen_digest.t ................. skipped: cannot find module 'auth_digest'
> t/hooks/authz.t ......................... ok
> t/hooks/cleanup.t ....................... ok
> t/hooks/cleanup2.t ...................... ok
> t/hooks/error.t ......................... ok
> t/hooks/fixup.t ......................... ok
> t/hooks/headerparser.t .................. ok
> t/hooks/hookrun.t ....................... ok
> t/hooks/init.t .......................... ok
> t/hooks/inlined_handlers.t .............. ok
> t/hooks/push_handlers.t ................. ok
> t/hooks/push_handlers_anon.t ............ ok
> t/hooks/push_handlers_blessed.t ......... ok
> t/hooks/push_handlers_same_phase.t ...... ok
> t/hooks/set_handlers.t .................. ok
> t/hooks/stacked_handlers.t .............. ok
> t/hooks/stacked_handlers2.t ............. ok
> t/hooks/startup.t ....................... ok
> t/hooks/trans.t ......................... ok
> t/modperl/cookie.t ...................... ok
> t/modperl/cookie2.t ..................... ok
> t/modperl/current_callback.t ............ ok
> t/modperl/dir_config.t .................. ok
> t/modperl/endav.t ....................... ok
> t/modperl/env.t ......................... ok
> t/modperl/exit.t ........................ ok
> t/modperl/getc.t ........................ ok
> t/modperl/interpreter.t ................. ok
> t/modperl/io_nested_with_closed_stds.t .. ok
> t/modperl/io_with_closed_stds.t ......... ok
> t/modperl/local_env.t ................... skipped: local %ENV is still broken
> t/modperl/merge.t ....................... ok
> t/modperl/merge2.t ...................... ok
> t/modperl/merge3.t ...................... ok
> t/modperl/method.t ...................... ok
> t/modperl/methodname.t .................. ok
> t/modperl/methodobj.t ................... ok
> t/modperl/perl.t ........................ ok
> t/modperl/perl_options.t ................ ok
> t/modperl/perl_options2.t ............... skipped: PerlOptions None is broken
> t/modperl/pnotes.t ...................... ok
> t/modperl/pnotes2.t ..................... ok
> t/modperl/post_utf8.t ................... ok
> t/modperl/print.t ....................... ok
> t/modperl/print_utf8.t .................. ok
> t/modperl/print_utf8_2.t ................ ok
> t/modperl/printf.t ...................... ok
> t/modperl/readline.t .................... ok
> t/modperl/request_rec_perlio_api.t ...... ok
> t/modperl/request_rec_tie_api.t ......... skipped: perl 5.026002: PerlIO is used instead of TIEd IO
> t/modperl/setauth.t ..................... ok
> t/modperl/setupenv.t .................... ok
> t/modperl/setupenv2.t ................... ok
> t/modperl/status.t ...................... ok
> t/modperl/stdfd.t ....................... ok
> t/modperl/stdfd2.t ...................... ok
> t/modperl/subenv.t ...................... ok
> t/modperl/taint.t ....................... ok
> t/modperl/util.t ........................ ok
> t/modules/apache_resource.t ............. ok
> t/modules/apache_status.t ............... ok
> t/modules/cgi.t ......................... ok
> t/modules/cgi2.t ........................ ok
> t/modules/cgipost.t ..................... ok
> t/modules/cgipost2.t .................... ok
> t/modules/cgiupload.t ................... ok
> t/modules/cgiupload2.t .................. ok
> t/modules/include.t ..................... skipped: cannot find module 'mod_include'
> t/modules/include2.t .................... skipped: cannot find module 'include'
> t/modules/include_subreq.t .............. skipped: cannot find module 'include'
> t/modules/proxy.t ....................... ok
> t/perl/api.t ............................ ok
> t/perl/hash_attack.t .................... skipped: relevant only for perl 5.8.2 and up to 5.17.6
> t/perl/signals.t ........................ ok
> t/preconnection/note.t .................. ok
> t/protocol/echo_bbs.t ................... ok
> t/protocol/echo_bbs2.t .................. ok
> t/protocol/echo_block.t ................. ok
> t/protocol/echo_filter.t ................ ok
> t/protocol/echo_nonblock.t .............. ok
> t/protocol/echo_timeout.t ............... ok
> t/protocol/pseudo_http.t ................ ok
> t/user/rewrite.t ........................ ok
> t/vhost/config.t ........................ ok
> t/vhost/log.t ........................... ok
>
> Test Summary Report
> -------------------
> t/filter/in_bbs_inject_header.t (Wstat: 0 Tests: 36 Failed: 3)
> Failed tests: 22, 26, 30
> Files=245, Tests=4800, 250 wallclock secs ( 2.02 usr 1.46 sys + 167.39 cusr 57.16 csys = 228.03 CPU)
> Result: FAIL
> Failed 1/245 test programs. 3/4800 subtests failed.
> [warning] server localhost:8529 shutdown
> [ error] error running tests (please examine t/logs/error_log)
> +--------------------------------------------------------+
> | Please file a bug report: http://perl.apache.org/bugs/ |
> +--------------------------------------------------------+
> *** Error code 1
>
> Stop.
> make[1]: stopped in /usr/ports/www/mod_perl2/work/mod_perl-2.0.10
> *** Error code 1 (ignored)
Cheers
Rumen Palov
On 2019-09-24 19:53, Steve Hay wrote:
> Please download, test, and report back on this mod_perl 2.0.11 release
> candidate.
>
> https://dist.apache.org/repos/dist/dev/perl/mod_perl-2.0.11-rc2.tar.gz
>
> MD5 = abc2c2168121a09b0fc3b6fc6adc00bd
> SHA1 = 36ee7626506a3a461118b3957814dfe9331ef1de
>
> Changes since RC1 are as follows:
>
> Fix [CVE-2011-2767] Arbitrary Perl code execution in the context of the user
> account via a user-owned .htaccess. Patch from bugs.debian.org #644169. [Jan
> Ingvoldstad <ja...@ifi.uio.no>]
>
> Fix potential test suite hangs due to pipelined response deadlocks. Patch
> from rt.cpan.org #82409. [Zefram <ze...@fysh.org>]
>
> Fix t/compat/request.t failures [Steve Hay]
>