You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@falcon.apache.org by Ruslan Ostafiychuk <ro...@hortonworks.com> on 2015/05/06 19:01:09 UTC
Review Request 33899: Test buttons available on search results page
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33899/
-----------------------------------------------------------
Review request for Falcon.
Bugs: FALCON-1198
https://issues.apache.org/jira/browse/FALCON-1198
Repository: falcon-git
Description
-------
Test witch buttons should be available in different situations.
Check changed on UI statuses via API.
merlin.current_user_name property can be used to change user.name for API operations.
Diffs
-----
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/enumsAndConstants/MerlinConstants.java 7f0f5c7
falcon-regression/merlin-core/src/main/java/org/apache/falcon/request/BaseRequest.java a70ceeb
falcon-regression/merlin-core/src/main/java/org/apache/falcon/request/RequestKeys.java 3232978
falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/SearchPage.java 9ad2591
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/searchUI/EntitiesTableReflectionTest.java 8d64a0e
Diff: https://reviews.apache.org/r/33899/diff/
Testing
-------
Tested
Thanks,
Ruslan Ostafiychuk
Re: Review Request 33899: Test buttons available on search results
page
Posted by Raghav Gautam <ra...@apache.org>.
> On May 6, 2015, 4:37 p.m., Raghav Gautam wrote:
> > Ship It!
+1 after review comments are addressed.
- Raghav
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33899/#review82771
-----------------------------------------------------------
On May 6, 2015, 10:01 a.m., Ruslan Ostafiychuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33899/
> -----------------------------------------------------------
>
> (Updated May 6, 2015, 10:01 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1198
> https://issues.apache.org/jira/browse/FALCON-1198
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Test witch buttons should be available in different situations.
> Check changed on UI statuses via API.
> merlin.current_user_name property can be used to change user.name for API operations.
>
>
> Diffs
> -----
>
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/enumsAndConstants/MerlinConstants.java 7f0f5c7
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/request/BaseRequest.java a70ceeb
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/request/RequestKeys.java 3232978
> falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/SearchPage.java 9ad2591
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/searchUI/EntitiesTableReflectionTest.java 8d64a0e
>
> Diff: https://reviews.apache.org/r/33899/diff/
>
>
> Testing
> -------
>
> Tested
>
>
> Thanks,
>
> Ruslan Ostafiychuk
>
>
Re: Review Request 33899: Test buttons available on search results
page
Posted by Raghav Gautam <ra...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33899/#review82771
-----------------------------------------------------------
Ship it!
Ship It!
- Raghav Gautam
On May 6, 2015, 10:01 a.m., Ruslan Ostafiychuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33899/
> -----------------------------------------------------------
>
> (Updated May 6, 2015, 10:01 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1198
> https://issues.apache.org/jira/browse/FALCON-1198
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Test witch buttons should be available in different situations.
> Check changed on UI statuses via API.
> merlin.current_user_name property can be used to change user.name for API operations.
>
>
> Diffs
> -----
>
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/enumsAndConstants/MerlinConstants.java 7f0f5c7
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/request/BaseRequest.java a70ceeb
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/request/RequestKeys.java 3232978
> falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/SearchPage.java 9ad2591
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/searchUI/EntitiesTableReflectionTest.java 8d64a0e
>
> Diff: https://reviews.apache.org/r/33899/diff/
>
>
> Testing
> -------
>
> Tested
>
>
> Thanks,
>
> Ruslan Ostafiychuk
>
>
Re: Review Request 33899: Test buttons available on search results
page
Posted by Ruslan Ostafiychuk <ro...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33899/
-----------------------------------------------------------
(Updated May 7, 2015, 7:10 a.m.)
Review request for Falcon.
Changes
-------
property name is changed
Bugs: FALCON-1198
https://issues.apache.org/jira/browse/FALCON-1198
Repository: falcon-git
Description
-------
Test witch buttons should be available in different situations.
Check changed on UI statuses via API.
merlin.current_user_name property can be used to change user.name for API operations.
Diffs (updated)
-----
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/enumsAndConstants/MerlinConstants.java 7f0f5c7
falcon-regression/merlin-core/src/main/java/org/apache/falcon/request/BaseRequest.java a70ceeb
falcon-regression/merlin-core/src/main/java/org/apache/falcon/request/RequestKeys.java 3232978
falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/SearchPage.java 9ad2591
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/searchUI/EntitiesTableReflectionTest.java 8d64a0e
Diff: https://reviews.apache.org/r/33899/diff/
Testing
-------
Tested
Thanks,
Ruslan Ostafiychuk
Re: Review Request 33899: Test buttons available on search results
page
Posted by Raghav Gautam <ra...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33899/#review82768
-----------------------------------------------------------
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/enumsAndConstants/MerlinConstants.java
<https://reviews.apache.org/r/33899/#comment133578>
Using merlin prefix is inconsistent with our coding convention.
Other similar properties have names like:
current_user_keytab
user2_name = hrt_1
user2_keytab = none
- Raghav Gautam
On May 6, 2015, 10:01 a.m., Ruslan Ostafiychuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33899/
> -----------------------------------------------------------
>
> (Updated May 6, 2015, 10:01 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1198
> https://issues.apache.org/jira/browse/FALCON-1198
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Test witch buttons should be available in different situations.
> Check changed on UI statuses via API.
> merlin.current_user_name property can be used to change user.name for API operations.
>
>
> Diffs
> -----
>
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/enumsAndConstants/MerlinConstants.java 7f0f5c7
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/request/BaseRequest.java a70ceeb
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/request/RequestKeys.java 3232978
> falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/SearchPage.java 9ad2591
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/searchUI/EntitiesTableReflectionTest.java 8d64a0e
>
> Diff: https://reviews.apache.org/r/33899/diff/
>
>
> Testing
> -------
>
> Tested
>
>
> Thanks,
>
> Ruslan Ostafiychuk
>
>