You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@heron.apache.org by GitBox <gi...@apache.org> on 2020/02/10 07:44:25 UTC
[GitHub] [incubator-heron] windhamwong opened a new pull request #3449:
Adding support of docker build for debian10
windhamwong opened a new pull request #3449: Adding support of docker build for debian10
URL: https://github.com/apache/incubator-heron/pull/3449
The docker build for debian10 includes:
- using openjdk8 debian10 image, openjdk:8u242-jre-slim-buster
- default install Python3.7
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-heron] windhamwong commented on issue #3449: Adding
support of docker build for debian10
Posted by GitBox <gi...@apache.org>.
windhamwong commented on issue #3449: Adding support of docker build for debian10
URL: https://github.com/apache/incubator-heron/pull/3449#issuecomment-584241559
oh interesting situation. I am trying debian10 because debian9 docker build doesn't support Python 3.6+ due to lack of python-dev for 3.6+ version. (Or maybe I can sort out the source build thing but I can't find the source link) Let me try both debian9 and debian10 and come back :)
My debian10 commit is still having a huge break due to issue of protobuf bazel build. That's why the PR is still in draft.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-heron] windhamwong commented on issue #3449: Adding
support of docker build for debian10
Posted by GitBox <gi...@apache.org>.
windhamwong commented on issue #3449: Adding support of docker build for debian10
URL: https://github.com/apache/incubator-heron/pull/3449#issuecomment-586816868
Will merge with PR #3438 .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-heron] joshfischer1108 commented on issue #3449: Adding
support of docker build for debian10
Posted by GitBox <gi...@apache.org>.
joshfischer1108 commented on issue #3449: Adding support of docker build for debian10
URL: https://github.com/apache/incubator-heron/pull/3449#issuecomment-584171340
@windhamwong Thank you for the start of this pull request. I was in the process of working through of getting a Debian 9 Heron container ready for for the next release. Do you have a time estimate of when you think your contribution will be complete? I may hold off working on the Debian9 container if you feel that you are not far off from getting this ready for review.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-heron] joshfischer1108 edited a comment on issue #3449:
Adding support of docker build for debian10
Posted by GitBox <gi...@apache.org>.
joshfischer1108 edited a comment on issue #3449: Adding support of docker build for debian10
URL: https://github.com/apache/incubator-heron/pull/3449#issuecomment-584171340
@windhamwong Thank you for the start of this pull request. I was in the process of working through getting a Debian 9 Heron container ready for for the next release. Do you have a time estimate of when you think your contribution will be complete? I may hold off working on the Debian9 container if you feel that you are not far off from getting this ready for review.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-heron] windhamwong commented on issue #3449: Adding
support of docker build for debian10
Posted by GitBox <gi...@apache.org>.
windhamwong commented on issue #3449: Adding support of docker build for debian10
URL: https://github.com/apache/incubator-heron/pull/3449#issuecomment-585100213
[Unrelated to the PR]
I have successfully deploy Python3.7.3 with Python37-dev to debian9. I am currently fixing the imp version.
[Related to PR]
The debian10 is having issue with bazel. I might retry again later to fix the issue before officially submit PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-heron] joshfischer1108 edited a comment on issue #3449:
Adding support of docker build for debian10
Posted by GitBox <gi...@apache.org>.
joshfischer1108 edited a comment on issue #3449: Adding support of docker build for debian10
URL: https://github.com/apache/incubator-heron/pull/3449#issuecomment-584253999
Well I wouldn't say the container is perfect yet. There is still some debugging to do. For example, I had to add in some environment variables when compiling the zookeeper target. I tried to add the environment variables only to the container to prevent needing to change the Bazel build targets, but adding them to the container didn't seem to fix the issue. On mac the build passes. On Debian9 it fails because the warnings that are thrown are treated as errors. I'm not exactly sure why yet. After adding those environment variables I was able to build a Debian9 container and submit an example ECO topology successfully. You can find the branch in this repo.. It is -> `joshfischer/debian9`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-heron] joshfischer1108 commented on issue #3449: Adding
support of docker build for debian10
Posted by GitBox <gi...@apache.org>.
joshfischer1108 commented on issue #3449: Adding support of docker build for debian10
URL: https://github.com/apache/incubator-heron/pull/3449#issuecomment-584253999
Well I wouldn't say the container is perfect yet. There is still some debugging to do. For example, I had to add in some flags when compiling the zookeeper target.. On mac it passes on Debian9 it fails because the warnings that are thrown are treated as errors. I'm not exactly sure why yet. After adding those flags I was able to build a Debian9 container and submit an example ECO topology successfully. You can find the branch in this repo.. It is -> `joshfischer/debian9`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-heron] windhamwong commented on issue #3449: Adding
support of docker build for debian10
Posted by GitBox <gi...@apache.org>.
windhamwong commented on issue #3449: Adding support of docker build for debian10
URL: https://github.com/apache/incubator-heron/pull/3449#issuecomment-584564311
I didn't put any env or config for building docker. I believe if you see the warnings are treated as error, that means there is a major error before this line. The docker build is quite slow and I am reverting to debian9 build now as debian10 + protobuf update +python37 fails due to lack of library build (need time to build and fix).
I will come back when I have finished my build.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-heron] windhamwong commented on issue #3449: Adding
support of docker build for debian10
Posted by GitBox <gi...@apache.org>.
windhamwong commented on issue #3449: Adding support of docker build for debian10
URL: https://github.com/apache/incubator-heron/pull/3449#issuecomment-585099391
Ok, I am working on debian9 now with the master configs. I do have an error here,
`
08:54:42 [WARN] /root/.cache/pants/setup/bootstrap-Linux-x86_64/1.23.0_py37/lib/python3.7/site-packages/pex/pep425tags.py:274: DeprecationWarning: the imp module is deprecated in favour of importlib; see the module's documentation for alternative uses
import imp
`
Is this the error you got?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-heron] windhamwong closed pull request #3449: Adding
support of docker build for debian10
Posted by GitBox <gi...@apache.org>.
windhamwong closed pull request #3449: Adding support of docker build for debian10
URL: https://github.com/apache/incubator-heron/pull/3449
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services