You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2022/11/10 05:25:50 UTC
[GitHub] [druid] tejaswini-imply opened a new pull request, #13347: Add static-checks Github Action
tejaswini-imply opened a new pull request, #13347:
URL: https://github.com/apache/druid/pull/13347
We are moving away from the Travis CI/CD pipeline to GitHub Actions. As the first step, this PR adds static-checks GitHub action (triggered on any pull request activity) to run all the below steps:
```
animal sniffer checks
checkstyle
enforcer checks
forbidden api checks
pmd checks
spotbugs checks
license checks
license checks for hadoop 3
script checks
analyze dependencies
analyze hadoop 3 dependencies
(openjdk11) strict compilation
```
Optimizations implemented:
1. Caching maven dependencies.
2. Running checks parallelly.
3. Concurrency - single job per PR at a time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] tejaswini-imply commented on pull request #13347: Add static-checks Github Action
Posted by GitBox <gi...@apache.org>.
tejaswini-imply commented on PR #13347:
URL: https://github.com/apache/druid/pull/13347#issuecomment-1313380637
Here is the Static Checks CI GitHub actions on a forked repo - https://github.com/tejaswini-imply/druid/actions/runs/3442505350
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] abhishekagarwal87 commented on a diff in pull request #13347: Add static-checks Github Action
Posted by GitBox <gi...@apache.org>.
abhishekagarwal87 commented on code in PR #13347:
URL: https://github.com/apache/druid/pull/13347#discussion_r1019323662
##########
.github/workflows/static-checks.yml:
##########
@@ -0,0 +1,190 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+name: Static Checks CI
+on:
+ pull_request:
Review Comment:
it's possible that Infra needs to enable actions for this repo?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] FrankChen021 commented on a diff in pull request #13347: Add static-checks Github Action
Posted by GitBox <gi...@apache.org>.
FrankChen021 commented on code in PR #13347:
URL: https://github.com/apache/druid/pull/13347#discussion_r1019242086
##########
.github/workflows/static-checks.yml:
##########
@@ -0,0 +1,190 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+name: Static Checks CI
+on:
+ pull_request:
Review Comment:
BTW, why does the GitHub Action not run for this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] imply-elliott commented on a diff in pull request #13347: Add static-checks Github Action
Posted by GitBox <gi...@apache.org>.
imply-elliott commented on code in PR #13347:
URL: https://github.com/apache/druid/pull/13347#discussion_r1023390833
##########
.github/workflows/static-checks.yml:
##########
@@ -0,0 +1,194 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+name: Static Checks CI
+on:
+ push:
+ branches:
+ - master
+ - /^\d+\.\d+\.\d+(-\S*)?$/ # release branches
+ pull_request:
+ branches:
+ - master
+ - /^\d+\.\d+\.\d+(-\S*)?$/ # release branches
+
+concurrency:
+ group: '${{ github.workflow }} @ ${{ github.event.pull_request.head.label || github.head_ref || github.ref }}'
+ cancel-in-progress: true
+
+env:
+ MVN: mvn -B
+ MAVEN_SKIP: -P skip-static-checks -Dweb.console.skip=true -Dmaven.javadoc.skip=true
+ MAVEN_SKIP_TESTS: -P skip-tests
+
+jobs:
+ build:
+ runs-on: ubuntu-latest
+ steps:
+ - uses: actions/checkout@v3
+ - name: setup java 8
+ uses: actions/setup-java@v3
+ with:
+ distribution: 'zulu'
+ java-version: '8'
+ cache: 'maven'
+ - run: |
+ echo 'Running Maven install...' &&
+ MAVEN_OPTS='-Xmx3000m' \
Review Comment:
Let's move this to a env variable so it's set the same way as others and universally applied:
```
env:
MAVEN_OPTS: -Xmx3000m
##########
.github/scripts/setup_generate_license.sh:
##########
@@ -0,0 +1,20 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+sudo apt-get update && sudo apt-get install python3 -y
+curl https://bootstrap.pypa.io/pip/3.5/get-pip.py | sudo -H python3
+../../check_test_suite.py && travis_terminate 0 || echo 'Continuing setup'
Review Comment:
What's this reference to travis_terminate here? I saw this in my tests too and I don't think this will work in Actions?
##########
.github/workflows/static-checks.yml:
##########
@@ -0,0 +1,194 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+name: Static Checks CI
+on:
+ push:
+ branches:
+ - master
+ - /^\d+\.\d+\.\d+(-\S*)?$/ # release branches
+ pull_request:
+ branches:
+ - master
+ - /^\d+\.\d+\.\d+(-\S*)?$/ # release branches
+
+concurrency:
+ group: '${{ github.workflow }} @ ${{ github.event.pull_request.head.label || github.head_ref || github.ref }}'
+ cancel-in-progress: true
+
+env:
+ MVN: mvn -B
+ MAVEN_SKIP: -P skip-static-checks -Dweb.console.skip=true -Dmaven.javadoc.skip=true
+ MAVEN_SKIP_TESTS: -P skip-tests
+
+jobs:
+ build:
+ runs-on: ubuntu-latest
+ steps:
+ - uses: actions/checkout@v3
+ - name: setup java 8
+ uses: actions/setup-java@v3
+ with:
+ distribution: 'zulu'
+ java-version: '8'
+ cache: 'maven'
+ - run: |
+ echo 'Running Maven install...' &&
+ MAVEN_OPTS='-Xmx3000m' \
+ ${MVN} clean install -q -ff -pl '!distribution,!:druid-it-image,!:druid-it-cases' ${MAVEN_SKIP} ${MAVEN_SKIP_TESTS} -T1C &&
+ ${MVN} install -q -ff -pl 'distribution' ${MAVEN_SKIP} ${MAVEN_SKIP_TESTS}
+
+ animal_sniffer_checks:
+ runs-on: ubuntu-latest
+ needs: [build]
+ steps:
+ - uses: actions/checkout@v3
+ - name: setup java 8
Review Comment:
Do we expect to only run some of these checks with java 8, or should they eventually be run for all supported versions?
##########
.github/workflows/static-checks.yml:
##########
@@ -0,0 +1,194 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+name: Static Checks CI
+on:
+ push:
+ branches:
+ - master
+ - /^\d+\.\d+\.\d+(-\S*)?$/ # release branches
+ pull_request:
+ branches:
+ - master
+ - /^\d+\.\d+\.\d+(-\S*)?$/ # release branches
+
+concurrency:
+ group: '${{ github.workflow }} @ ${{ github.event.pull_request.head.label || github.head_ref || github.ref }}'
+ cancel-in-progress: true
+
+env:
+ MVN: mvn -B
+ MAVEN_SKIP: -P skip-static-checks -Dweb.console.skip=true -Dmaven.javadoc.skip=true
+ MAVEN_SKIP_TESTS: -P skip-tests
+
+jobs:
+ build:
+ runs-on: ubuntu-latest
+ steps:
+ - uses: actions/checkout@v3
+ - name: setup java 8
+ uses: actions/setup-java@v3
+ with:
+ distribution: 'zulu'
+ java-version: '8'
+ cache: 'maven'
+ - run: |
+ echo 'Running Maven install...' &&
+ MAVEN_OPTS='-Xmx3000m' \
+ ${MVN} clean install -q -ff -pl '!distribution,!:druid-it-image,!:druid-it-cases' ${MAVEN_SKIP} ${MAVEN_SKIP_TESTS} -T1C &&
+ ${MVN} install -q -ff -pl 'distribution' ${MAVEN_SKIP} ${MAVEN_SKIP_TESTS}
+
+ animal_sniffer_checks:
+ runs-on: ubuntu-latest
+ needs: [build]
+ steps:
+ - uses: actions/checkout@v3
+ - name: setup java 8
+ uses: actions/setup-java@v3
+ with:
+ distribution: 'zulu'
+ java-version: '8'
+ cache: 'maven'
+ - run: ${MVN} animal-sniffer:check --fail-at-end
+
+ checkstyle:
+ runs-on: ubuntu-latest
+ needs: [build]
+ steps:
+ - uses: actions/checkout@v3
+ - name: setup java 8
+ uses: actions/setup-java@v3
+ with:
+ distribution: 'zulu'
+ java-version: '8'
+ cache: 'maven'
+ - run: ${MVN} checkstyle:checkstyle --fail-at-end
+
+ enforcer_checks:
+ runs-on: ubuntu-latest
+ needs: [build]
+ steps:
+ - uses: actions/checkout@v3
+ - name: setup java 8
+ uses: actions/setup-java@v3
+ with:
+ distribution: 'zulu'
+ java-version: '8'
+ cache: 'maven'
+ - run: ${MVN} enforcer:enforce --fail-at-end
+
+ forbidden_api_checks:
+ runs-on: ubuntu-latest
+ needs: [build]
+ steps:
+ - uses: actions/checkout@v3
+ - name: setup java 8
+ uses: actions/setup-java@v3
+ with:
+ distribution: 'zulu'
+ java-version: '8'
+ cache: 'maven'
+ - run: ${MVN} forbiddenapis:check forbiddenapis:testCheck --fail-at-end
+
+ pmd_checks:
+ runs-on: ubuntu-latest
+ needs: [build]
+ steps:
+ - uses: actions/checkout@v3
+ - name: setup java 8
+ uses: actions/setup-java@v3
+ with:
+ distribution: 'zulu'
+ java-version: '8'
+ cache: 'maven'
+ - run: ${MVN} pmd:check --fail-at-end # TODO: consider adding pmd:cpd-check
+
+ spotbugs_checks:
+ runs-on: ubuntu-latest
+ needs: [build]
+ steps:
+ - uses: actions/checkout@v3
+ - name: setup java 8
+ uses: actions/setup-java@v3
+ with:
+ distribution: 'zulu'
+ java-version: '8'
+ cache: 'maven'
+ - run: ${MVN} spotbugs:check --fail-at-end -pl '!benchmarks'
+
+ license_checks:
+ runs-on: ubuntu-latest
+ needs: [build]
+ strategy:
+ matrix:
+ HADOOP_PROFILE: ['', '-Phadoop3']
+ steps:
+ - uses: actions/checkout@v3
+ - name: setup java 8
+ uses: actions/setup-java@v3
+ with:
+ distribution: 'zulu'
+ java-version: '8'
+ cache: 'maven'
+ - run: |
+ ./.github/scripts/setup_generate_license.sh
+ ${MVN} apache-rat:check -Prat --fail-at-end \
+ -Dorg.slf4j.simpleLogger.log.org.apache.maven.cli.transfer.Slf4jMavenTransferListener=warn \
+ -Drat.consoleOutput=true ${{ matrix.HADOOP_PROFILE }}
+ # Generate dependency reports and checks they are valid.
+ mkdir -p target
+ distribution/bin/generate-license-dependency-reports.py . target --clean-maven-artifact-transfer --parallel 2
+ distribution/bin/check-licenses.py licenses.yaml target/license-reports
+
+ script_checks:
+ runs-on: ubuntu-latest
+ steps:
+ - uses: actions/checkout@v3
+ # who watches the watchers?
+ - run: ./check_test_suite_test.py
+
+ analyze_dependencies:
+ runs-on: ubuntu-latest
+ needs: [build]
+ strategy:
+ matrix:
+ HADOOP_PROFILE: [ '', '-Phadoop3' ]
+ steps:
+ - uses: actions/checkout@v3
+ - name: setup java 8
+ uses: actions/setup-java@v3
+ with:
+ distribution: 'zulu'
+ java-version: '8'
+ cache: 'maven'
+ - run: |-
+ MAVEN_OPTS='-Xmx3000m' ${MVN} ${MAVEN_SKIP} dependency:analyze -DoutputXML=true -DignoreNonCompile=true -DfailOnWarning=true ${{ matrix.HADOOP_PROFILE }} ||
+ ./.github/scripts/display_dependency_analysis_error_message.sh
+
+ openjdk11_strict_compilation:
+ runs-on: ubuntu-latest
+ steps:
+ - uses: actions/checkout@v3
+ - name: setup java 11
+ uses: actions/setup-java@v3
+ with:
+ distribution: 'zulu'
+ java-version: '11'
+ cache: 'maven'
+
+ # errorprone requires JDK 11
+ # Strict compilation requires more than 2 GB
+ - run: |
+ MAVEN_OPTS='-Xmx3000m' ${MVN} clean -DstrictCompile compile test-compile --fail-at-end ${MAVEN_SKIP} ${MAVEN_SKIP_TESTS}
Review Comment:
We can pull out MAVEN_OPTS here when set as a global env variable.
##########
.github/workflows/static-checks.yml:
##########
@@ -0,0 +1,194 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+name: Static Checks CI
+on:
+ push:
+ branches:
+ - master
+ - /^\d+\.\d+\.\d+(-\S*)?$/ # release branches
+ pull_request:
+ branches:
+ - master
+ - /^\d+\.\d+\.\d+(-\S*)?$/ # release branches
+
+concurrency:
+ group: '${{ github.workflow }} @ ${{ github.event.pull_request.head.label || github.head_ref || github.ref }}'
+ cancel-in-progress: true
+
+env:
+ MVN: mvn -B
+ MAVEN_SKIP: -P skip-static-checks -Dweb.console.skip=true -Dmaven.javadoc.skip=true
+ MAVEN_SKIP_TESTS: -P skip-tests
+
+jobs:
+ build:
+ runs-on: ubuntu-latest
+ steps:
+ - uses: actions/checkout@v3
+ - name: setup java 8
+ uses: actions/setup-java@v3
+ with:
+ distribution: 'zulu'
+ java-version: '8'
+ cache: 'maven'
+ - run: |
+ echo 'Running Maven install...' &&
+ MAVEN_OPTS='-Xmx3000m' \
+ ${MVN} clean install -q -ff -pl '!distribution,!:druid-it-image,!:druid-it-cases' ${MAVEN_SKIP} ${MAVEN_SKIP_TESTS} -T1C &&
+ ${MVN} install -q -ff -pl 'distribution' ${MAVEN_SKIP} ${MAVEN_SKIP_TESTS}
+
+ animal_sniffer_checks:
+ runs-on: ubuntu-latest
+ needs: [build]
+ steps:
+ - uses: actions/checkout@v3
+ - name: setup java 8
+ uses: actions/setup-java@v3
+ with:
+ distribution: 'zulu'
+ java-version: '8'
+ cache: 'maven'
+ - run: ${MVN} animal-sniffer:check --fail-at-end
+
+ checkstyle:
+ runs-on: ubuntu-latest
+ needs: [build]
+ steps:
+ - uses: actions/checkout@v3
+ - name: setup java 8
+ uses: actions/setup-java@v3
+ with:
+ distribution: 'zulu'
+ java-version: '8'
+ cache: 'maven'
+ - run: ${MVN} checkstyle:checkstyle --fail-at-end
+
+ enforcer_checks:
+ runs-on: ubuntu-latest
+ needs: [build]
+ steps:
+ - uses: actions/checkout@v3
+ - name: setup java 8
+ uses: actions/setup-java@v3
+ with:
+ distribution: 'zulu'
+ java-version: '8'
+ cache: 'maven'
+ - run: ${MVN} enforcer:enforce --fail-at-end
+
+ forbidden_api_checks:
+ runs-on: ubuntu-latest
+ needs: [build]
+ steps:
+ - uses: actions/checkout@v3
+ - name: setup java 8
+ uses: actions/setup-java@v3
+ with:
+ distribution: 'zulu'
+ java-version: '8'
+ cache: 'maven'
+ - run: ${MVN} forbiddenapis:check forbiddenapis:testCheck --fail-at-end
+
+ pmd_checks:
+ runs-on: ubuntu-latest
+ needs: [build]
+ steps:
+ - uses: actions/checkout@v3
+ - name: setup java 8
+ uses: actions/setup-java@v3
+ with:
+ distribution: 'zulu'
+ java-version: '8'
+ cache: 'maven'
+ - run: ${MVN} pmd:check --fail-at-end # TODO: consider adding pmd:cpd-check
+
+ spotbugs_checks:
+ runs-on: ubuntu-latest
+ needs: [build]
+ steps:
+ - uses: actions/checkout@v3
+ - name: setup java 8
+ uses: actions/setup-java@v3
+ with:
+ distribution: 'zulu'
+ java-version: '8'
+ cache: 'maven'
+ - run: ${MVN} spotbugs:check --fail-at-end -pl '!benchmarks'
+
+ license_checks:
+ runs-on: ubuntu-latest
+ needs: [build]
+ strategy:
+ matrix:
+ HADOOP_PROFILE: ['', '-Phadoop3']
+ steps:
+ - uses: actions/checkout@v3
+ - name: setup java 8
+ uses: actions/setup-java@v3
+ with:
+ distribution: 'zulu'
+ java-version: '8'
+ cache: 'maven'
+ - run: |
+ ./.github/scripts/setup_generate_license.sh
+ ${MVN} apache-rat:check -Prat --fail-at-end \
+ -Dorg.slf4j.simpleLogger.log.org.apache.maven.cli.transfer.Slf4jMavenTransferListener=warn \
+ -Drat.consoleOutput=true ${{ matrix.HADOOP_PROFILE }}
+ # Generate dependency reports and checks they are valid.
+ mkdir -p target
+ distribution/bin/generate-license-dependency-reports.py . target --clean-maven-artifact-transfer --parallel 2
+ distribution/bin/check-licenses.py licenses.yaml target/license-reports
+
+ script_checks:
+ runs-on: ubuntu-latest
+ steps:
+ - uses: actions/checkout@v3
+ # who watches the watchers?
+ - run: ./check_test_suite_test.py
+
+ analyze_dependencies:
+ runs-on: ubuntu-latest
+ needs: [build]
+ strategy:
+ matrix:
+ HADOOP_PROFILE: [ '', '-Phadoop3' ]
+ steps:
+ - uses: actions/checkout@v3
+ - name: setup java 8
+ uses: actions/setup-java@v3
+ with:
+ distribution: 'zulu'
+ java-version: '8'
+ cache: 'maven'
+ - run: |-
+ MAVEN_OPTS='-Xmx3000m' ${MVN} ${MAVEN_SKIP} dependency:analyze -DoutputXML=true -DignoreNonCompile=true -DfailOnWarning=true ${{ matrix.HADOOP_PROFILE }} ||
Review Comment:
We can pull out MAVEN_OPTS here when set as a global env variable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] tejaswini-imply commented on a diff in pull request #13347: Add static-checks Github Action
Posted by GitBox <gi...@apache.org>.
tejaswini-imply commented on code in PR #13347:
URL: https://github.com/apache/druid/pull/13347#discussion_r1019823316
##########
.github/workflows/static-checks.yml:
##########
@@ -0,0 +1,190 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+name: Static Checks CI
+on:
+ pull_request:
Review Comment:
Seems like it. This runs on a PR raised in the fork repo.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] tejaswini-imply commented on a diff in pull request #13347: Add static-checks Github Action
Posted by GitBox <gi...@apache.org>.
tejaswini-imply commented on code in PR #13347:
URL: https://github.com/apache/druid/pull/13347#discussion_r1023819007
##########
.github/workflows/static-checks.yml:
##########
@@ -0,0 +1,194 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+name: Static Checks CI
+on:
+ push:
+ branches:
+ - master
+ - /^\d+\.\d+\.\d+(-\S*)?$/ # release branches
+ pull_request:
+ branches:
+ - master
+ - /^\d+\.\d+\.\d+(-\S*)?$/ # release branches
+
+concurrency:
+ group: '${{ github.workflow }} @ ${{ github.event.pull_request.head.label || github.head_ref || github.ref }}'
+ cancel-in-progress: true
+
+env:
+ MVN: mvn -B
+ MAVEN_SKIP: -P skip-static-checks -Dweb.console.skip=true -Dmaven.javadoc.skip=true
+ MAVEN_SKIP_TESTS: -P skip-tests
+
+jobs:
+ build:
+ runs-on: ubuntu-latest
+ steps:
+ - uses: actions/checkout@v3
+ - name: setup java 8
+ uses: actions/setup-java@v3
+ with:
+ distribution: 'zulu'
+ java-version: '8'
+ cache: 'maven'
+ - run: |
+ echo 'Running Maven install...' &&
+ MAVEN_OPTS='-Xmx3000m' \
+ ${MVN} clean install -q -ff -pl '!distribution,!:druid-it-image,!:druid-it-cases' ${MAVEN_SKIP} ${MAVEN_SKIP_TESTS} -T1C &&
+ ${MVN} install -q -ff -pl 'distribution' ${MAVEN_SKIP} ${MAVEN_SKIP_TESTS}
+
+ animal_sniffer_checks:
+ runs-on: ubuntu-latest
+ needs: [build]
+ steps:
+ - uses: actions/checkout@v3
+ - name: setup java 8
Review Comment:
Maybe eventually, This is the existing flow with Travis checks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] abhishekagarwal87 commented on a diff in pull request #13347: Add static-checks Github Action
Posted by GitBox <gi...@apache.org>.
abhishekagarwal87 commented on code in PR #13347:
URL: https://github.com/apache/druid/pull/13347#discussion_r1021274216
##########
.github/workflows/static-checks.yml:
##########
@@ -0,0 +1,190 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+name: Static Checks CI
+on:
+ pull_request:
Review Comment:
https://the-asf.slack.com/archives/CBX4TSBQ8/p1668410098261039 - We need to merge the first PR before it can get triggered.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] abhishekagarwal87 merged pull request #13347: Add static-checks Github Action
Posted by GitBox <gi...@apache.org>.
abhishekagarwal87 merged PR #13347:
URL: https://github.com/apache/druid/pull/13347
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] FrankChen021 commented on a diff in pull request #13347: Add static-checks Github Action
Posted by GitBox <gi...@apache.org>.
FrankChen021 commented on code in PR #13347:
URL: https://github.com/apache/druid/pull/13347#discussion_r1019233936
##########
.github/workflows/static-checks.yml:
##########
@@ -0,0 +1,190 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+name: Static Checks CI
+on:
+ pull_request:
Review Comment:
I think we also need this GitHub Action to run on each commit on master and release branch.
e.g.
```yaml
on:
push:
branches: [ master ]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] tejaswini-imply commented on pull request #13347: Add static-checks Github Action
Posted by GitBox <gi...@apache.org>.
tejaswini-imply commented on PR #13347:
URL: https://github.com/apache/druid/pull/13347#issuecomment-1316774160
Thanks for the review @imply-elliott, I have addressed your comments in the latest commit. PTAL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org