[jira] [Commented] (CASSANDRA-12792) delete with timestamp long.MAX_VALUE for the whole key creates tombstone that cannot be removed.

["Branimir Lambov (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-12792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15635971#comment-15635971 ] 

Branimir Lambov commented on CASSANDRA-12792:
---------------------------------------------

[The check whether to use timestamp|https://github.com/apache/cassandra/compare/trunk...jkni:CASSANDRA-12792-3.X#diff-e8e282423dcbf34d30a3578c8dec15cdR252] doesn't seem entirely correct. I believe you should turn the {{hasMemtableCf}} flag into a {{hasTimestamp}} to be set whenever you take the minimum.

The rest looks good. I'd prefer it a little less verbose, though:
- We can do without the {{hasPurgeEvaluator}} flag since {{purgeEvaluator != null}} can serve the same purpose quite well.
- For 3.0+ it will be a little easier to see what happens if you use lambdas instead of the evaluator classes. I know this creates a difference between the 2.2 and 3+ versions, but IMO adding clarity to the version we are going forward with is worth it.

> delete with timestamp long.MAX_VALUE for the whole key creates tombstone that cannot be removed. 
> -------------------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-12792
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-12792
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Compaction
>            Reporter: Ian Ilsley
>            Assignee: Joel Knighton
>
> In db/compaction/LazilyCompactedRow.java 
> we only check for  <  MaxPurgeableTimeStamp  
> eg:
> (this.maxRowTombstone.markedForDeleteAt < getMaxPurgeableTimestamp())
> this should probably be <= 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)