You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by "DanielCarter-stack (via GitHub)" <gi...@apache.org> on 2026/08/08 13:05:15 UTC

[PR] [Docs][Connector-V2] Improve Paimon StarRocks and RabbitMQ connector docs [seatunnel]

DanielCarter-stack opened a new pull request, #11705:
URL: https://github.com/apache/seatunnel/pull/11705

   ## [Docs][Connector-V2] Improve Paimon StarRocks and RabbitMQ connector docs
   
   ### Summary
   
   This PR polishes the user-facing documentation for five Paimon, StarRocks, and RabbitMQ connector pages. It is part of an ongoing effort to make connector docs self-contained, accurate, and copy-paste friendly.
   
   ### Changes
   
   **Paimon source**
   - Add a `description` column to the options table and document the previously-undocumented `catalog_name`, `user`, and `password` options.
   - Remove a duplicate `## Changelog` section (the section explaining Paimon changelog reading was previously mis-named `## Changelog` and collided with the file-footer changelog). Renamed to `## Reading Paimon Changelog`.
   
   **Paimon sink**
   - Add a `description` column to the options table and tighten descriptions for catalog options and the schema/data save modes.
   
   **StarRocks source**
   - Replace placeholder `password = ""` and unquoted `username = root` in the two examples with realistic values and consistent quoting.
   - Tighten the descriptions for `request_tablet_size`, `nodeUrls`, `username`, `password`, `database`, and `table`.
   
   **StarRocks sink**
   - Same `password`/`username` example fixes applied across all sample configs in both `docs/en` and `docs/zh`.
   
   **RabbitMQ source**
   - Add a `description` column to the options table; clarify `tables_configs` vs root-level `queue_name` and the `AUTOMATIC_RECOVERY_ENABLED` casing.
   
   **RabbitMQ sink**
   - Add a `description` column to the options table; clarify the `routing_key`/`exchange` pair, the `rabbitmq.config` extra-options map, and the queue declaration flags.
   
   ### Checklist
   
   - [x] Only documentation files are touched.
   - [x] No support-version metadata changed.
   - [x] Each touched connector (Paimon, StarRocks, RabbitMQ) has not been modified by another PR in the last 7 days.
   - [x] No source code, examples, or e2e test configs were touched.
   
   ### Notes
   
   - Connector identifiers and option names match the runtime options classes (`PaimonBaseOptions`, `PaimonSinkOptions`, `KafkaBaseOptions`, etc.).
   - The five connectors selected here have no PR touching their docs in the last 7 days, per the team's batching rule.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Docs][Connector-V2] Improve Paimon StarRocks and RabbitMQ connector docs [seatunnel]

Posted by "DanielLeens (via GitHub)" <gi...@apache.org>.
DanielLeens commented on PR #11705:
URL: https://github.com/apache/seatunnel/pull/11705#issuecomment-6473595439

   Thanks @davidzollo for the independent APPROVED review on this head. My existing technical clearance remains unchanged. Your approval record is separate from Daniel's review and from branch protection's effective approval decision; the current gate snapshot below records those separately. No new code revision is requested by this reply.
   
   Gate snapshot (2026-10-28T15:45:59+00:00), head `416e2d44f4c9b4c280681c71cef337efe938c585`: [Build](https://github.com/apache/seatunnel/runs/121485007242) is `SUCCESS`.
   
   CI was previously the only remaining technical gate in my conclusion; CI is now passing, so that CI objection is withdrawn and my technical conclusion is clear to proceed. Daniel currently has READ permission. I have not changed the effective GitHub review state to APPROVED; a write-capable maintainer must perform the final approve/dismiss action required by branch protection.
   
   Comparison recorded in this scan: base `dev`, `diverged`, ahead 3 / behind 48, no merge conflict. Branch drift is metadata here and is not an additional sync request.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Docs][Connector-V2] Improve Paimon StarRocks and RabbitMQ connector docs [seatunnel]

Posted by "davidzollo (via GitHub)" <gi...@apache.org>.
davidzollo commented on PR #11705:
URL: https://github.com/apache/seatunnel/pull/11705#issuecomment-6393747283

   Updated the original branch at `416e2d44f4c9`. The merge preserves current dev's RabbitMQ protobuf/TLS/URI/passive options and Paimon replica/privilege examples. Both entries of the reviewed table_list illustration now include database; the two requested Chinese description columns are mirrored. Scoped Spotless and the final documentation patch whitespace check passed. Current-head GitHub CI remains the runtime validation gate.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Docs][Connector-V2] Improve Paimon StarRocks and RabbitMQ connector docs [seatunnel]

Posted by "nzw921rx (via GitHub)" <gi...@apache.org>.
nzw921rx merged PR #11705:
URL: https://github.com/apache/seatunnel/pull/11705


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org