You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "Planeswalker23 (via GitHub)" <gi...@apache.org> on 2023/03/15 11:55:57 UTC
[GitHub] [dubbo] Planeswalker23 opened a new pull request, #11841: [ISSUE #10020] test efficiency of MemorySafeLinkedBlockingQueue
Planeswalker23 opened a new pull request, #11841:
URL: https://github.com/apache/dubbo/pull/11841
## What is the purpose of the change
[ISSUE #10020] test efficiency of MemorySafeLinkedBlockingQueue
## Brief changelog
## Verifying this change
<!-- Follow this checklist to help us incorporate your contribution quickly and easily: -->
## Checklist
- [x] Make sure there is a [GitHub_issue](https://github.com/apache/dubbo/issues) field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
- [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in [dubbo samples](https://github.com/apache/dubbo-samples) project.
- [ ] Add some description to [dubbo-website](https://github.com/apache/dubbo-website) project if you are requesting to add a feature.
- [ ] GitHub Actions works fine on your own branch.
- [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/dubbo/wiki/Software-donation-guide).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] sonarcloud[bot] commented on pull request #11841: [ISSUE #10020] test efficiency of MemorySafeLinkedBlockingQueue
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #11841:
URL: https://github.com/apache/dubbo/pull/11841#issuecomment-1478862139
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=11841)
[](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=11841&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=11841&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=11841&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=11841&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=11841&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=11841&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=11841&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=11841&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=11841&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=11841&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=11841&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=11841&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=11841&metric=coverage&view=list) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=11841&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=11841&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] AlbumenJ merged pull request #11841: [ISSUE #10020] test efficiency of MemorySafeLinkedBlockingQueue
Posted by "AlbumenJ (via GitHub)" <gi...@apache.org>.
AlbumenJ merged PR #11841:
URL: https://github.com/apache/dubbo/pull/11841
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] sonarcloud[bot] commented on pull request #11841: [ISSUE #10020] test efficiency of MemorySafeLinkedBlockingQueue
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #11841:
URL: https://github.com/apache/dubbo/pull/11841#issuecomment-1473174604
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=11841)
[](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=11841&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=11841&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=11841&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=11841&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=11841&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=11841&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=11841&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=11841&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=11841&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=11841&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=11841&resolved=false&types=CODE_SMELL) [3 Code Smells](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=11841&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=11841&metric=coverage&view=list) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=11841&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=11841&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] AlbumenJ commented on a diff in pull request #11841: [ISSUE #10020] test efficiency of MemorySafeLinkedBlockingQueue
Posted by "AlbumenJ (via GitHub)" <gi...@apache.org>.
AlbumenJ commented on code in PR #11841:
URL: https://github.com/apache/dubbo/pull/11841#discussion_r1139753798
##########
dubbo-common/src/test/java/org/apache/dubbo/common/threadpool/MemorySafeLinkedBlockingQueueTest.java:
##########
@@ -55,4 +56,59 @@ void testCustomReject() {
assertThrows(RejectException.class, () -> queue.offer(() -> {
}));
}
+
+ @Test
+ void testEfficiency() throws InterruptedException {
+ // if length is vert large(unit test may runs for a long time), so you may need to modify JVM param such as : -Xms=1024m -Xmx=2048m
+ // if you want to test efficiency of MemorySafeLinkedBlockingQueue, you may modify following param: length and times
+ int length = 1000, times = 1;
+
+ // LinkedBlockingQueue insert Integer: 500W * 20 times
+ long spent1 = spend(new LinkedBlockingQueue<>(), length, times);
+
+ // MemorySafeLinkedBlockingQueue insert Integer: 500W * 20 times
+ long spent2 = spend(newMemorySafeLinkedBlockingQueue(), length, times);
+ System.gc();
+ Thread.sleep(1000);
Review Comment:
Should prevent use `sleep` in unit test
##########
dubbo-common/src/test/java/org/apache/dubbo/common/threadpool/MemorySafeLinkedBlockingQueueTest.java:
##########
@@ -55,4 +56,59 @@ void testCustomReject() {
assertThrows(RejectException.class, () -> queue.offer(() -> {
}));
}
+
+ @Test
+ void testEfficiency() throws InterruptedException {
+ // if length is vert large(unit test may runs for a long time), so you may need to modify JVM param such as : -Xms=1024m -Xmx=2048m
+ // if you want to test efficiency of MemorySafeLinkedBlockingQueue, you may modify following param: length and times
+ int length = 1000, times = 1;
+
+ // LinkedBlockingQueue insert Integer: 500W * 20 times
+ long spent1 = spend(new LinkedBlockingQueue<>(), length, times);
+
+ // MemorySafeLinkedBlockingQueue insert Integer: 500W * 20 times
+ long spent2 = spend(newMemorySafeLinkedBlockingQueue(), length, times);
+ System.gc();
+ Thread.sleep(1000);
+
+ System.out.println(String.format("LinkedBlockingQueue spent %s millis, MemorySafeLinkedBlockingQueue spent %s millis", spent1, spent2));
Review Comment:
Std out here is useless
##########
dubbo-common/src/test/java/org/apache/dubbo/common/threadpool/MemorySafeLinkedBlockingQueueTest.java:
##########
@@ -55,4 +56,59 @@ void testCustomReject() {
assertThrows(RejectException.class, () -> queue.offer(() -> {
}));
}
+
+ @Test
+ void testEfficiency() throws InterruptedException {
+ // if length is vert large(unit test may runs for a long time), so you may need to modify JVM param such as : -Xms=1024m -Xmx=2048m
+ // if you want to test efficiency of MemorySafeLinkedBlockingQueue, you may modify following param: length and times
+ int length = 1000, times = 1;
+
+ // LinkedBlockingQueue insert Integer: 500W * 20 times
+ long spent1 = spend(new LinkedBlockingQueue<>(), length, times);
+
+ // MemorySafeLinkedBlockingQueue insert Integer: 500W * 20 times
+ long spent2 = spend(newMemorySafeLinkedBlockingQueue(), length, times);
+ System.gc();
+ Thread.sleep(1000);
+
+ System.out.println(String.format("LinkedBlockingQueue spent %s millis, MemorySafeLinkedBlockingQueue spent %s millis", spent1, spent2));
Review Comment:
Should have at least one assert
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] Planeswalker23 commented on a diff in pull request #11841: [ISSUE #10020] test efficiency of MemorySafeLinkedBlockingQueue
Posted by "Planeswalker23 (via GitHub)" <gi...@apache.org>.
Planeswalker23 commented on code in PR #11841:
URL: https://github.com/apache/dubbo/pull/11841#discussion_r1144167843
##########
dubbo-common/src/test/java/org/apache/dubbo/common/threadpool/MemorySafeLinkedBlockingQueueTest.java:
##########
@@ -55,4 +56,59 @@ void testCustomReject() {
assertThrows(RejectException.class, () -> queue.offer(() -> {
}));
}
+
+ @Test
+ void testEfficiency() throws InterruptedException {
+ // if length is vert large(unit test may runs for a long time), so you may need to modify JVM param such as : -Xms=1024m -Xmx=2048m
+ // if you want to test efficiency of MemorySafeLinkedBlockingQueue, you may modify following param: length and times
+ int length = 1000, times = 1;
+
+ // LinkedBlockingQueue insert Integer: 500W * 20 times
+ long spent1 = spend(new LinkedBlockingQueue<>(), length, times);
+
+ // MemorySafeLinkedBlockingQueue insert Integer: 500W * 20 times
+ long spent2 = spend(newMemorySafeLinkedBlockingQueue(), length, times);
+ System.gc();
+ Thread.sleep(1000);
Review Comment:
done, please re-check
##########
dubbo-common/src/test/java/org/apache/dubbo/common/threadpool/MemorySafeLinkedBlockingQueueTest.java:
##########
@@ -55,4 +56,59 @@ void testCustomReject() {
assertThrows(RejectException.class, () -> queue.offer(() -> {
}));
}
+
+ @Test
+ void testEfficiency() throws InterruptedException {
+ // if length is vert large(unit test may runs for a long time), so you may need to modify JVM param such as : -Xms=1024m -Xmx=2048m
+ // if you want to test efficiency of MemorySafeLinkedBlockingQueue, you may modify following param: length and times
+ int length = 1000, times = 1;
+
+ // LinkedBlockingQueue insert Integer: 500W * 20 times
+ long spent1 = spend(new LinkedBlockingQueue<>(), length, times);
+
+ // MemorySafeLinkedBlockingQueue insert Integer: 500W * 20 times
+ long spent2 = spend(newMemorySafeLinkedBlockingQueue(), length, times);
+ System.gc();
+ Thread.sleep(1000);
+
+ System.out.println(String.format("LinkedBlockingQueue spent %s millis, MemorySafeLinkedBlockingQueue spent %s millis", spent1, spent2));
Review Comment:
done, please re-check
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter commented on pull request #11841: [ISSUE #10020] test efficiency of MemorySafeLinkedBlockingQueue
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #11841:
URL: https://github.com/apache/dubbo/pull/11841#issuecomment-1478867029
## [Codecov](https://codecov.io/gh/apache/dubbo/pull/11841?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#11841](https://codecov.io/gh/apache/dubbo/pull/11841?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2a5cb86) into [3.2](https://codecov.io/gh/apache/dubbo/commit/ec9eecfc821e6f56c5b1d1150d3a98a8509d969b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ec9eecf) will **increase** coverage by `0.07%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## 3.2 #11841 +/- ##
============================================
+ Coverage 68.89% 68.97% +0.07%
Complexity 2 2
============================================
Files 1533 1542 +9
Lines 63548 63905 +357
Branches 9303 9335 +32
============================================
+ Hits 43784 44076 +292
- Misses 15517 15560 +43
- Partials 4247 4269 +22
```
[see 78 files with indirect coverage changes](https://codecov.io/gh/apache/dubbo/pull/11841/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org