[GitHub] [pulsar] hrsakai opened a new pull request #5446: [pulsar-client-cpp]Change state_ to closed when resultOk is returned

[GitBox <gi...@apache.org>]

hrsakai opened a new pull request #5446: [pulsar-client-cpp]Change state_ to closed when resultOk is returned
URL: https://github.com/apache/pulsar/pull/5446
 
 
   ### Motivation
   * Consumer retry the connection forever even though `Consumer::close()` is called in following case.
   ```
   1. Consumer connects to broker
   2. Revoke the consumer's permission to consume(e.g. pulsar-admin namespaces revoke-permission --role "consumer.role" public/global/n1)
   3. Execute Consumer.Close()
   ```
   * Closed seems to be better when ResultOk is returned in `{ProducerImpl,ConsumerImpl}::closeAsync()`.
   
   ### Modifications
   * Change `state_` to Closing at the start of closing process in `ConsumerImpl::closeAsync()`.
   * Change `state_` to Closed when ResultOk is returned in `{ProducerImpl,ConsumerImpl}::closeAsync()`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services