You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/03/23 07:04:20 UTC
[GitHub] [pulsar] freeznet opened a new pull request #14814: [fix][function] fix pulsar-managed runtimes cannot download from package management service
freeznet opened a new pull request #14814:
URL: https://github.com/apache/pulsar/pull/14814
### Motivation
Pulsar Functions contain two pulsar-managed runtimes, which is thread runtime and process runtime. When `FunctionActioner` start the function, it requires to download the function file if the file is not builtin. When user submit function with package URL from package management service, it will fail with following error:
```
2022-03-23T07:00:52,589+0000 [worker-scheduler-0] ERROR org.apache.pulsar.functions.worker.FunctionActioner - public/default/1ib0g63yjm6hw Error starting function
org.apache.distributedlog.exceptions.InvalidStreamNameException: Invalid stream name : 'Invalid log name "/function://public/default/function@0.1.0" caused by empty node name specified @11'
at org.apache.distributedlog.util.DLUtils.validatePathName(DLUtils.java:359) ~[org.apache.distributedlog-distributedlog-core-4.14.4.jar:4.14.4]
at org.apache.distributedlog.util.DLUtils.validateAndNormalizeName(DLUtils.java:296) ~[org.apache.distributedlog-distributedlog-core-4.14.4.jar:4.14.4]
at org.apache.distributedlog.BKDistributedLogNamespace.openLog(BKDistributedLogNamespace.java:185) ~[org.apache.distributedlog-distributedlog-core-4.14.4.jar:4.14.4]
at org.apache.distributedlog.BKDistributedLogNamespace.openLog(BKDistributedLogNamespace.java:172) ~[org.apache.distributedlog-distributedlog-core-4.14.4.jar:4.14.4]
at org.apache.pulsar.functions.worker.WorkerUtils.downloadFromBookkeeper(WorkerUtils.java:118)
```
### Modifications
- add packageURL support in `FunctionActioner`
- add tests
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
*(Please pick either of the following options)*
This change is a trivial rework / code cleanup without any test coverage.
*(or)*
This change is already covered by existing tests, such as *(please describe tests)*.
*(or)*
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (10MB)*
- *Extended integration test for recovery after broker failure*
### Does this pull request potentially affect one of the following parts:
*If `yes` was chosen, please highlight the changes*
- Dependencies (does it add or upgrade a dependency): (yes / no)
- The public API: (yes / no)
- The schema: (yes / no / don't know)
- The default values of configurations: (yes / no)
- The wire protocol: (yes / no)
- The rest endpoints: (yes / no)
- The admin cli options: (yes / no)
- Anything that affects deployment: (yes / no / don't know)
### Documentation
Check the box below or label this PR directly (if you have committer privilege).
Need to update docs?
- [ ] `doc-required`
(If you need help on updating docs, create a doc issue)
- [ ] `no-need-doc`
(Please explain why)
- [ ] `doc`
(If this PR contains doc changes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] freeznet commented on pull request #14814: [fix][function] fix pulsar-managed runtimes failed start function with package URL from package management service
Posted by GitBox <gi...@apache.org>.
freeznet commented on pull request #14814:
URL: https://github.com/apache/pulsar/pull/14814#issuecomment-1085356846
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #14814: [fix][function] fix pulsar-managed runtimes failed start function with package URL from package management service
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14814:
URL: https://github.com/apache/pulsar/pull/14814#issuecomment-1076011790
@freeznet:Thanks for providing doc info!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #14814: [fix][function] fix pulsar-managed runtimes failed start function with package URL from package management service
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14814:
URL: https://github.com/apache/pulsar/pull/14814#issuecomment-1076476505
@freeznet:Thanks for providing doc info!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #14814: [fix][function] fix pulsar-managed runtimes failed start function with package URL from package management service
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14814:
URL: https://github.com/apache/pulsar/pull/14814#issuecomment-1076453203
@freeznet:Thanks for your contribution. For this PR, do we need to update docs?
(The [PR template contains info about doc](https://github.com/apache/pulsar/blob/master/.github/PULL_REQUEST_TEMPLATE.md#documentation), which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #14814: [fix][function] fix pulsar-managed runtimes cannot download from package management service
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14814:
URL: https://github.com/apache/pulsar/pull/14814#issuecomment-1075996063
@freeznet:Thanks for your contribution. For this PR, do we need to update docs?
(The [PR template contains info about doc](https://github.com/apache/pulsar/blob/master/.github/PULL_REQUEST_TEMPLATE.md#documentation), which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org