[GitHub] [lucene] nknize commented on pull request #11753: Added interface to relate a LatLonShape with another shape represented as Component2D

[GitBox <gi...@apache.org>]

nknize commented on PR #11753:
URL: https://github.com/apache/lucene/pull/11753#issuecomment-1242048944

   > Maybe we should make the ctor that takes a `BytesRef` public for such use-cases?
   
   We can either make the `LatLonShapeDocValues` and `XYShapeDocValues` ctor public, or add new factory methods to `LatLonShape` and `XYShape` for creating the DocValues instances like we do the fields? I like the latter for consistency. 
   
   I also think it might be a good idea to add a new `public void resetBinaryValue(BytesRef binaryValue)` method to `ShapeDocValues`? This would enable us to reuse the same ShapeDocValue instance inside of a query by just resetting the backing data from the iterator values. 
   
   I'm happy to do this but I think these would be a great contribution to help build your merit. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org