You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "andygrove (via GitHub)" <gi...@apache.org> on 2023/04/10 21:42:02 UTC
[GitHub] [arrow-datafusion-python] andygrove opened a new pull request, #320: Prepare for 22.0.0 release
andygrove opened a new pull request, #320:
URL: https://github.com/apache/arrow-datafusion-python/pull/320
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #.
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion-python] andygrove commented on pull request #320: Prepare for 22.0.0 release
Posted by "andygrove (via GitHub)" <gi...@apache.org>.
andygrove commented on PR #320:
URL: https://github.com/apache/arrow-datafusion-python/pull/320#issuecomment-1502472371
> Thanks for the heads up @andygrove anything you need me to help with? I'll keep an eye on any CI test failures. Still all running as of writing
No, all good. Just wanted to make you aware this was happening. I will cut an RC today.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion-python] jdye64 commented on pull request #320: Prepare for 22.0.0 release
Posted by "jdye64 (via GitHub)" <gi...@apache.org>.
jdye64 commented on PR #320:
URL: https://github.com/apache/arrow-datafusion-python/pull/320#issuecomment-1502436109
Thanks for the heads up @andygrove anything you need me to help with? I'll keep an eye on any CI test failures. Still all running as of writing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion-python] andygrove commented on pull request #320: Prepare for 22.0.0 release
Posted by "andygrove (via GitHub)" <gi...@apache.org>.
andygrove commented on PR #320:
URL: https://github.com/apache/arrow-datafusion-python/pull/320#issuecomment-1502430329
@jdye64 fyi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion-python] andygrove merged pull request #320: Prepare for 22.0.0 release
Posted by "andygrove (via GitHub)" <gi...@apache.org>.
andygrove merged PR #320:
URL: https://github.com/apache/arrow-datafusion-python/pull/320
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion-python] andygrove commented on a diff in pull request #320: Prepare for 22.0.0 release
Posted by "andygrove (via GitHub)" <gi...@apache.org>.
andygrove commented on code in PR #320:
URL: https://github.com/apache/arrow-datafusion-python/pull/320#discussion_r1162146260
##########
datafusion/tests/test_context.py:
##########
@@ -282,10 +282,11 @@ def test_dataset_filter_nested_data(ctx):
# This filter will not be pushed down to DatasetExec since it
# isn't supported
- df = df.select(
+ df = df.filter(column("nested_data")["b"] > literal(5))\
Review Comment:
Move the filter before the select due to https://github.com/apache/arrow-datafusion/issues/5949
##########
datafusion/tests/test_dataframe.py:
##########
@@ -84,10 +84,11 @@ def test_select_columns(df):
def test_filter(df):
- df = df.select(
+ df = df.filter(column("a") > literal(2))\
Review Comment:
Move the filter before the select due to https://github.com/apache/arrow-datafusion/issues/5949
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion-python] andygrove commented on pull request #320: Prepare for 22.0.0 release
Posted by "andygrove (via GitHub)" <gi...@apache.org>.
andygrove commented on PR #320:
URL: https://github.com/apache/arrow-datafusion-python/pull/320#issuecomment-1502378871
This is currently blocked on https://github.com/apache/arrow-datafusion/issues/5949
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org