You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/08/16 10:32:17 UTC
[GitHub] [apisix] Yangxiamao opened a new pull request #4833: feat: add question issue template
Yangxiamao opened a new pull request #4833:
URL: https://github.com/apache/apisix/pull/4833
### What this PR does / why we need it:
I add question issue template, so we can jump to the APISIX discussion forum from the Issues.
### Pre-submission checklist:
* [x] Did you explain what problem does this PR solve? Or what new features have been added?
* [ ] Have you added corresponding test cases?
* [ ] Have you modified the corresponding document?
* [x] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] Yangxiamao commented on a change in pull request #4833: feat: add question issue template
Posted by GitBox <gi...@apache.org>.
Yangxiamao commented on a change in pull request #4833:
URL: https://github.com/apache/apisix/pull/4833#discussion_r690085803
##########
File path: .github/ISSUE_TEMPLATE/config.yml
##########
@@ -0,0 +1,5 @@
+blank_issues_enabled: true
Review comment:
We can encourage contributors to use issue templates by setting blank_issues_enabled to false. If we set blank_issues_enabled to true, people will have the option to open a blank issue.
Do you think it is necessary?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] Yangxiamao commented on a change in pull request #4833: feat: add question issue template
Posted by GitBox <gi...@apache.org>.
Yangxiamao commented on a change in pull request #4833:
URL: https://github.com/apache/apisix/pull/4833#discussion_r689973032
##########
File path: .github/ISSUE_TEMPLATE/config.yml
##########
@@ -0,0 +1,5 @@
+blank_issues_enabled: true
Review comment:
I misunderstood the meaning of this option, my false. We can change this setting to "false"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander merged pull request #4833: feat: add question issue template
Posted by GitBox <gi...@apache.org>.
spacewander merged pull request #4833:
URL: https://github.com/apache/apisix/pull/4833
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #4833: feat: add question issue template
Posted by GitBox <gi...@apache.org>.
spacewander commented on a change in pull request #4833:
URL: https://github.com/apache/apisix/pull/4833#discussion_r690163014
##########
File path: .github/ISSUE_TEMPLATE/config.yml
##########
@@ -0,0 +1,5 @@
+blank_issues_enabled: true
Review comment:
Agree
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #4833: feat: add question issue template
Posted by GitBox <gi...@apache.org>.
spacewander commented on a change in pull request #4833:
URL: https://github.com/apache/apisix/pull/4833#discussion_r690078756
##########
File path: .github/ISSUE_TEMPLATE/config.yml
##########
@@ -0,0 +1,5 @@
+blank_issues_enabled: true
Review comment:
Actually, I mean whether "blank_issues_enabled" is required for the APISIX discussion forum. Allow blank issues or not seems to be irrelative to the discussion forum.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #4833: feat: add question issue template
Posted by GitBox <gi...@apache.org>.
spacewander commented on a change in pull request #4833:
URL: https://github.com/apache/apisix/pull/4833#discussion_r689439681
##########
File path: .github/ISSUE_TEMPLATE/config.yml
##########
@@ -0,0 +1,5 @@
+blank_issues_enabled: true
Review comment:
Why allow the blank issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] Yangxiamao commented on a change in pull request #4833: feat: add question issue template
Posted by GitBox <gi...@apache.org>.
Yangxiamao commented on a change in pull request #4833:
URL: https://github.com/apache/apisix/pull/4833#discussion_r690074766
##########
File path: .github/ISSUE_TEMPLATE/config.yml
##########
@@ -0,0 +1,5 @@
+blank_issues_enabled: true
Review comment:
Yes. We want all support questions to go to Discussions. But people are used to create issues. It will take long time until everyone learns the new feature. Having a big green button in the issue creation seems like a good idea.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #4833: feat: add question issue template
Posted by GitBox <gi...@apache.org>.
spacewander commented on a change in pull request #4833:
URL: https://github.com/apache/apisix/pull/4833#discussion_r689989611
##########
File path: .github/ISSUE_TEMPLATE/config.yml
##########
@@ -0,0 +1,5 @@
+blank_issues_enabled: true
Review comment:
Is it required for the APISIX discussion forum?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org