You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@doris.apache.org by "airborne12 (via GitHub)" <gi...@apache.org> on 2024/01/02 10:42:54 UTC

Re: [PR] [opt](position) add position iterator interface [doris-thirdparty]

airborne12 commented on code in PR #169:
URL: https://github.com/apache/doris-thirdparty/pull/169#discussion_r1439332015


##########
src/core/CLucene/search/query/DcoIdSetIterator.h:
##########
@@ -2,15 +2,11 @@
 
 #include "CLucene/index/DocRange.h"
 
+#include <string>
+
 class DocIdSetIterator {

Review Comment:
   why delete all virtual functions for DocIdSetIterator, if so, what is the need of this class?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@doris.apache.org
For additional commands, e-mail: dev-help@doris.apache.org