You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Eugene Koontz (JIRA)" <ji...@apache.org> on 2011/04/26 23:10:03 UTC
[jira] [Created] (ZOOKEEPER-1055) check for duplicate ACLs in
addACL() and create()
check for duplicate ACLs in addACL() and create()
-------------------------------------------------
Key: ZOOKEEPER-1055
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1055
Project: ZooKeeper
Issue Type: Bug
Reporter: Eugene Koontz
actual result:
[zk: (CONNECTED) 0] create /test2 'test2' digest:test:test:cdrwa,digest:test:test:cdrwa
Created /test2
[zk: (CONNECTED) 1] getAcl /test2
'digest,'test:test
: cdrwa
'digest,'test:test
: cdrwa
[zk: (CONNECTED) 2]
but getAcl should only have a single entry.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1055) check for duplicate ACLs in
addACL() and create()
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13055319#comment-13055319 ]
Mahadev konar commented on ZOOKEEPER-1055:
------------------------------------------
eugene,
The patch looks good.
One minor nit:
{code}
if (authInfo.contains(id) == false) {
authInfo.add(id);
}
{code}
can be replaced by:
{code}
if (!authInfo.contains(id)) {
authInfo.add(id);
}
{code}
I can make the minor change and check it in. Let me know.
> check for duplicate ACLs in addACL() and create()
> -------------------------------------------------
>
> Key: ZOOKEEPER-1055
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1055
> Project: ZooKeeper
> Issue Type: Bug
> Affects Versions: 3.4.0
> Reporter: Eugene Koontz
> Assignee: Eugene Koontz
> Fix For: 3.4.0
>
> Attachments: ZOOKEEPER-1055.patch, ZOOKEEPER-1055.patch, ZOOKEEPER-1055.patch, ZOOKEEPER-1055.patch
>
>
> actual result:
> [zk: (CONNECTED) 0] create /test2 'test2' digest:test:test:cdrwa,digest:test:test:cdrwa
> Created /test2
> [zk: (CONNECTED) 1] getAcl /test2
> 'digest,'test:test
> : cdrwa
> 'digest,'test:test
> : cdrwa
> [zk: (CONNECTED) 2]
> but getAcl should only have a single entry.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (ZOOKEEPER-1055) check for duplicate ACLs in
addACL() and create()
Posted by "Eugene Koontz (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1055?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eugene Koontz reassigned ZOOKEEPER-1055:
----------------------------------------
Assignee: Eugene Koontz
> check for duplicate ACLs in addACL() and create()
> -------------------------------------------------
>
> Key: ZOOKEEPER-1055
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1055
> Project: ZooKeeper
> Issue Type: Bug
> Reporter: Eugene Koontz
> Assignee: Eugene Koontz
>
> actual result:
> [zk: (CONNECTED) 0] create /test2 'test2' digest:test:test:cdrwa,digest:test:test:cdrwa
> Created /test2
> [zk: (CONNECTED) 1] getAcl /test2
> 'digest,'test:test
> : cdrwa
> 'digest,'test:test
> : cdrwa
> [zk: (CONNECTED) 2]
> but getAcl should only have a single entry.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1055) check for duplicate ACLs in
addACL() and create()
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1055?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mahadev konar updated ZOOKEEPER-1055:
-------------------------------------
Attachment: ZOOKEEPER-1055.patch
Eugene, I just copied your code over. Multi Update had changed most of the codebase. Can you please review and see if I missed something or not?
> check for duplicate ACLs in addACL() and create()
> -------------------------------------------------
>
> Key: ZOOKEEPER-1055
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1055
> Project: ZooKeeper
> Issue Type: Bug
> Affects Versions: 3.4.0
> Reporter: Eugene Koontz
> Assignee: Eugene Koontz
> Fix For: 3.4.0
>
> Attachments: ZOOKEEPER-1055.patch, ZOOKEEPER-1055.patch, ZOOKEEPER-1055.patch, ZOOKEEPER-1055.patch, ZOOKEEPER-1055.patch
>
>
> actual result:
> [zk: (CONNECTED) 0] create /test2 'test2' digest:test:test:cdrwa,digest:test:test:cdrwa
> Created /test2
> [zk: (CONNECTED) 1] getAcl /test2
> 'digest,'test:test
> : cdrwa
> 'digest,'test:test
> : cdrwa
> [zk: (CONNECTED) 2]
> but getAcl should only have a single entry.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1055) check for duplicate ACLs in
addACL() and create()
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13085023#comment-13085023 ]
Hudson commented on ZOOKEEPER-1055:
-----------------------------------
Integrated in ZooKeeper-trunk #1266 (See [https://builds.apache.org/job/ZooKeeper-trunk/1266/])
ZOOKEEPER-1055. check for duplicate ACLs in addACL() and create(). (Eugene Koontz via mahadev)
mahadev : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1157685
Files :
* /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/ServerCnxn.java
* /zookeeper/trunk/CHANGES.txt
* /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java
* /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/ACLCountTest.java
> check for duplicate ACLs in addACL() and create()
> -------------------------------------------------
>
> Key: ZOOKEEPER-1055
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1055
> Project: ZooKeeper
> Issue Type: Bug
> Affects Versions: 3.4.0
> Reporter: Eugene Koontz
> Assignee: Eugene Koontz
> Fix For: 3.4.0
>
> Attachments: ZOOKEEPER-1055.patch, ZOOKEEPER-1055.patch, ZOOKEEPER-1055.patch, ZOOKEEPER-1055.patch, ZOOKEEPER-1055.patch, ZOOKEEPER-1055.patch
>
>
> actual result:
> [zk: (CONNECTED) 0] create /test2 'test2' digest:test:test:cdrwa,digest:test:test:cdrwa
> Created /test2
> [zk: (CONNECTED) 1] getAcl /test2
> 'digest,'test:test
> : cdrwa
> 'digest,'test:test
> : cdrwa
> [zk: (CONNECTED) 2]
> but getAcl should only have a single entry.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1055) check for duplicate ACLs in
addACL() and create()
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13032839#comment-13032839 ]
Hadoop QA commented on ZOOKEEPER-1055:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12479042/ZOOKEEPER-1055.patch
against trunk revision 1099329.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 2 new or modified tests.
-1 patch. The patch command could not apply the patch.
Console output: https://builds.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/258//console
This message is automatically generated.
> check for duplicate ACLs in addACL() and create()
> -------------------------------------------------
>
> Key: ZOOKEEPER-1055
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1055
> Project: ZooKeeper
> Issue Type: Bug
> Affects Versions: 3.4.0
> Reporter: Eugene Koontz
> Assignee: Eugene Koontz
> Fix For: 3.4.0
>
> Attachments: ZOOKEEPER-1055.patch, ZOOKEEPER-1055.patch
>
>
> actual result:
> [zk: (CONNECTED) 0] create /test2 'test2' digest:test:test:cdrwa,digest:test:test:cdrwa
> Created /test2
> [zk: (CONNECTED) 1] getAcl /test2
> 'digest,'test:test
> : cdrwa
> 'digest,'test:test
> : cdrwa
> [zk: (CONNECTED) 2]
> but getAcl should only have a single entry.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1055) check for duplicate ACLs in
addACL() and create()
Posted by "Eugene Koontz (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1055?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eugene Koontz updated ZOOKEEPER-1055:
-------------------------------------
Attachment: ZOOKEEPER-1055.patch
> check for duplicate ACLs in addACL() and create()
> -------------------------------------------------
>
> Key: ZOOKEEPER-1055
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1055
> Project: ZooKeeper
> Issue Type: Bug
> Affects Versions: 3.4.0
> Reporter: Eugene Koontz
> Assignee: Eugene Koontz
> Fix For: 3.4.0
>
> Attachments: ZOOKEEPER-1055.patch, ZOOKEEPER-1055.patch, ZOOKEEPER-1055.patch, ZOOKEEPER-1055.patch, ZOOKEEPER-1055.patch, ZOOKEEPER-1055.patch
>
>
> actual result:
> [zk: (CONNECTED) 0] create /test2 'test2' digest:test:test:cdrwa,digest:test:test:cdrwa
> Created /test2
> [zk: (CONNECTED) 1] getAcl /test2
> 'digest,'test:test
> : cdrwa
> 'digest,'test:test
> : cdrwa
> [zk: (CONNECTED) 2]
> but getAcl should only have a single entry.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1055) check for duplicate ACLs in
addACL() and create()
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13061087#comment-13061087 ]
Hadoop QA commented on ZOOKEEPER-1055:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12485535/ZOOKEEPER-1055.patch
against trunk revision 1142377.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 2 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/371//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/371//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/371//console
This message is automatically generated.
> check for duplicate ACLs in addACL() and create()
> -------------------------------------------------
>
> Key: ZOOKEEPER-1055
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1055
> Project: ZooKeeper
> Issue Type: Bug
> Affects Versions: 3.4.0
> Reporter: Eugene Koontz
> Assignee: Eugene Koontz
> Fix For: 3.4.0
>
> Attachments: ZOOKEEPER-1055.patch, ZOOKEEPER-1055.patch, ZOOKEEPER-1055.patch, ZOOKEEPER-1055.patch, ZOOKEEPER-1055.patch
>
>
> actual result:
> [zk: (CONNECTED) 0] create /test2 'test2' digest:test:test:cdrwa,digest:test:test:cdrwa
> Created /test2
> [zk: (CONNECTED) 1] getAcl /test2
> 'digest,'test:test
> : cdrwa
> 'digest,'test:test
> : cdrwa
> [zk: (CONNECTED) 2]
> but getAcl should only have a single entry.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1055) check for duplicate ACLs in
addACL() and create()
Posted by "Eugene Koontz (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1055?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eugene Koontz updated ZOOKEEPER-1055:
-------------------------------------
Attachment: ZOOKEEPER-1055.patch
--no-prefix
> check for duplicate ACLs in addACL() and create()
> -------------------------------------------------
>
> Key: ZOOKEEPER-1055
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1055
> Project: ZooKeeper
> Issue Type: Bug
> Affects Versions: 3.4.0
> Reporter: Eugene Koontz
> Assignee: Eugene Koontz
> Fix For: 3.4.0
>
> Attachments: ZOOKEEPER-1055.patch, ZOOKEEPER-1055.patch, ZOOKEEPER-1055.patch
>
>
> actual result:
> [zk: (CONNECTED) 0] create /test2 'test2' digest:test:test:cdrwa,digest:test:test:cdrwa
> Created /test2
> [zk: (CONNECTED) 1] getAcl /test2
> 'digest,'test:test
> : cdrwa
> 'digest,'test:test
> : cdrwa
> [zk: (CONNECTED) 2]
> but getAcl should only have a single entry.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1055) check for duplicate ACLs in
addACL() and create()
Posted by "Eugene Koontz (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1055?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eugene Koontz updated ZOOKEEPER-1055:
-------------------------------------
Attachment: ZOOKEEPER-1055.patch
This is not a fix yet; but is simply a unit test that shows the bug (this test fails on trunk).
(removed irrelevant logging change from patch)
> check for duplicate ACLs in addACL() and create()
> -------------------------------------------------
>
> Key: ZOOKEEPER-1055
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1055
> Project: ZooKeeper
> Issue Type: Bug
> Reporter: Eugene Koontz
> Assignee: Eugene Koontz
> Attachments: ZOOKEEPER-1055.patch
>
>
> actual result:
> [zk: (CONNECTED) 0] create /test2 'test2' digest:test:test:cdrwa,digest:test:test:cdrwa
> Created /test2
> [zk: (CONNECTED) 1] getAcl /test2
> 'digest,'test:test
> : cdrwa
> 'digest,'test:test
> : cdrwa
> [zk: (CONNECTED) 2]
> but getAcl should only have a single entry.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1055) check for duplicate ACLs in
addACL() and create()
Posted by "Eugene Koontz (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1055?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eugene Koontz updated ZOOKEEPER-1055:
-------------------------------------
Attachment: ZOOKEEPER-1055.patch
> check for duplicate ACLs in addACL() and create()
> -------------------------------------------------
>
> Key: ZOOKEEPER-1055
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1055
> Project: ZooKeeper
> Issue Type: Bug
> Affects Versions: 3.4.0
> Reporter: Eugene Koontz
> Assignee: Eugene Koontz
> Fix For: 3.4.0
>
> Attachments: ZOOKEEPER-1055.patch, ZOOKEEPER-1055.patch
>
>
> actual result:
> [zk: (CONNECTED) 0] create /test2 'test2' digest:test:test:cdrwa,digest:test:test:cdrwa
> Created /test2
> [zk: (CONNECTED) 1] getAcl /test2
> 'digest,'test:test
> : cdrwa
> 'digest,'test:test
> : cdrwa
> [zk: (CONNECTED) 2]
> but getAcl should only have a single entry.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1055) check for duplicate ACLs in
addACL() and create()
Posted by "Eugene Koontz (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13032778#comment-13032778 ]
Eugene Koontz commented on ZOOKEEPER-1055:
------------------------------------------
With patch, unit test passes consistently.
> check for duplicate ACLs in addACL() and create()
> -------------------------------------------------
>
> Key: ZOOKEEPER-1055
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1055
> Project: ZooKeeper
> Issue Type: Bug
> Affects Versions: 3.4.0
> Reporter: Eugene Koontz
> Assignee: Eugene Koontz
> Fix For: 3.4.0
>
> Attachments: ZOOKEEPER-1055.patch, ZOOKEEPER-1055.patch
>
>
> actual result:
> [zk: (CONNECTED) 0] create /test2 'test2' digest:test:test:cdrwa,digest:test:test:cdrwa
> Created /test2
> [zk: (CONNECTED) 1] getAcl /test2
> 'digest,'test:test
> : cdrwa
> 'digest,'test:test
> : cdrwa
> [zk: (CONNECTED) 2]
> but getAcl should only have a single entry.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1055) check for duplicate ACLs in
addACL() and create()
Posted by "Eugene Koontz (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1055?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eugene Koontz updated ZOOKEEPER-1055:
-------------------------------------
Attachment: ZOOKEEPER-1055.patch
add removeDuplicates() function to remove duplicate ACLs from client create()s and setACL()s before the ACLs are added to the node by the server.
> check for duplicate ACLs in addACL() and create()
> -------------------------------------------------
>
> Key: ZOOKEEPER-1055
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1055
> Project: ZooKeeper
> Issue Type: Bug
> Affects Versions: 3.4.0
> Reporter: Eugene Koontz
> Assignee: Eugene Koontz
> Fix For: 3.4.0
>
> Attachments: ZOOKEEPER-1055.patch, ZOOKEEPER-1055.patch, ZOOKEEPER-1055.patch, ZOOKEEPER-1055.patch
>
>
> actual result:
> [zk: (CONNECTED) 0] create /test2 'test2' digest:test:test:cdrwa,digest:test:test:cdrwa
> Created /test2
> [zk: (CONNECTED) 1] getAcl /test2
> 'digest,'test:test
> : cdrwa
> 'digest,'test:test
> : cdrwa
> [zk: (CONNECTED) 2]
> but getAcl should only have a single entry.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1055) check for duplicate ACLs in
addACL() and create()
Posted by "Eugene Koontz (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13061345#comment-13061345 ]
Eugene Koontz commented on ZOOKEEPER-1055:
------------------------------------------
Hi Mahadev,
The patch looks good to me. Thanks for updating it.
-Eugene
> check for duplicate ACLs in addACL() and create()
> -------------------------------------------------
>
> Key: ZOOKEEPER-1055
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1055
> Project: ZooKeeper
> Issue Type: Bug
> Affects Versions: 3.4.0
> Reporter: Eugene Koontz
> Assignee: Eugene Koontz
> Fix For: 3.4.0
>
> Attachments: ZOOKEEPER-1055.patch, ZOOKEEPER-1055.patch, ZOOKEEPER-1055.patch, ZOOKEEPER-1055.patch, ZOOKEEPER-1055.patch
>
>
> actual result:
> [zk: (CONNECTED) 0] create /test2 'test2' digest:test:test:cdrwa,digest:test:test:cdrwa
> Created /test2
> [zk: (CONNECTED) 1] getAcl /test2
> 'digest,'test:test
> : cdrwa
> 'digest,'test:test
> : cdrwa
> [zk: (CONNECTED) 2]
> but getAcl should only have a single entry.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1055) check for duplicate ACLs in
addACL() and create()
Posted by "Eugene Koontz (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1055?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eugene Koontz updated ZOOKEEPER-1055:
-------------------------------------
Attachment: ZOOKEEPER-1055.patch
This is not a fix yet; but is simply a unit test that shows the bug (this test fails on trunk).
> check for duplicate ACLs in addACL() and create()
> -------------------------------------------------
>
> Key: ZOOKEEPER-1055
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1055
> Project: ZooKeeper
> Issue Type: Bug
> Reporter: Eugene Koontz
> Assignee: Eugene Koontz
> Attachments: ZOOKEEPER-1055.patch
>
>
> actual result:
> [zk: (CONNECTED) 0] create /test2 'test2' digest:test:test:cdrwa,digest:test:test:cdrwa
> Created /test2
> [zk: (CONNECTED) 1] getAcl /test2
> 'digest,'test:test
> : cdrwa
> 'digest,'test:test
> : cdrwa
> [zk: (CONNECTED) 2]
> but getAcl should only have a single entry.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1055) check for duplicate ACLs in
addACL() and create()
Posted by "Eugene Koontz (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13032779#comment-13032779 ]
Eugene Koontz commented on ZOOKEEPER-1055:
------------------------------------------
I noticed that we use SelectionKey.attach() to attach authInfo information to ClientCnxns. A bit of googling led me to this blog post: "http://jfarcand.wordpress.com/2006/07/06/tricks-and-tips-with-nio-part-ii-why-selectionkey-attach-is-evil/"
I'm not sure if this blog post is relevant, but thought I'd mention it.
> check for duplicate ACLs in addACL() and create()
> -------------------------------------------------
>
> Key: ZOOKEEPER-1055
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1055
> Project: ZooKeeper
> Issue Type: Bug
> Affects Versions: 3.4.0
> Reporter: Eugene Koontz
> Assignee: Eugene Koontz
> Fix For: 3.4.0
>
> Attachments: ZOOKEEPER-1055.patch, ZOOKEEPER-1055.patch
>
>
> actual result:
> [zk: (CONNECTED) 0] create /test2 'test2' digest:test:test:cdrwa,digest:test:test:cdrwa
> Created /test2
> [zk: (CONNECTED) 1] getAcl /test2
> 'digest,'test:test
> : cdrwa
> 'digest,'test:test
> : cdrwa
> [zk: (CONNECTED) 2]
> but getAcl should only have a single entry.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1055) check for duplicate ACLs in
addACL() and create()
Posted by "Eugene Koontz (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13055379#comment-13055379 ]
Eugene Koontz commented on ZOOKEEPER-1055:
------------------------------------------
Hi Mahadev,
Looks good to me! Thanks a lot for your review!
-Eugene
> check for duplicate ACLs in addACL() and create()
> -------------------------------------------------
>
> Key: ZOOKEEPER-1055
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1055
> Project: ZooKeeper
> Issue Type: Bug
> Affects Versions: 3.4.0
> Reporter: Eugene Koontz
> Assignee: Eugene Koontz
> Fix For: 3.4.0
>
> Attachments: ZOOKEEPER-1055.patch, ZOOKEEPER-1055.patch, ZOOKEEPER-1055.patch, ZOOKEEPER-1055.patch
>
>
> actual result:
> [zk: (CONNECTED) 0] create /test2 'test2' digest:test:test:cdrwa,digest:test:test:cdrwa
> Created /test2
> [zk: (CONNECTED) 1] getAcl /test2
> 'digest,'test:test
> : cdrwa
> 'digest,'test:test
> : cdrwa
> [zk: (CONNECTED) 2]
> but getAcl should only have a single entry.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1055) check for duplicate ACLs in
addACL() and create()
Posted by "Eugene Koontz (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13032688#comment-13032688 ]
Eugene Koontz commented on ZOOKEEPER-1055:
------------------------------------------
Correction: sometimes fails on trunk, sometimes succeeds.
> check for duplicate ACLs in addACL() and create()
> -------------------------------------------------
>
> Key: ZOOKEEPER-1055
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1055
> Project: ZooKeeper
> Issue Type: Bug
> Reporter: Eugene Koontz
> Assignee: Eugene Koontz
> Attachments: ZOOKEEPER-1055.patch
>
>
> actual result:
> [zk: (CONNECTED) 0] create /test2 'test2' digest:test:test:cdrwa,digest:test:test:cdrwa
> Created /test2
> [zk: (CONNECTED) 1] getAcl /test2
> 'digest,'test:test
> : cdrwa
> 'digest,'test:test
> : cdrwa
> [zk: (CONNECTED) 2]
> but getAcl should only have a single entry.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1055) check for duplicate ACLs in
addACL() and create()
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13082912#comment-13082912 ]
Hadoop QA commented on ZOOKEEPER-1055:
--------------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12489131/ZOOKEEPER-1055.patch
against trunk revision 1152141.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 2 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/444//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/444//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/444//console
This message is automatically generated.
> check for duplicate ACLs in addACL() and create()
> -------------------------------------------------
>
> Key: ZOOKEEPER-1055
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1055
> Project: ZooKeeper
> Issue Type: Bug
> Affects Versions: 3.4.0
> Reporter: Eugene Koontz
> Assignee: Eugene Koontz
> Fix For: 3.4.0
>
> Attachments: ZOOKEEPER-1055.patch, ZOOKEEPER-1055.patch, ZOOKEEPER-1055.patch, ZOOKEEPER-1055.patch, ZOOKEEPER-1055.patch, ZOOKEEPER-1055.patch
>
>
> actual result:
> [zk: (CONNECTED) 0] create /test2 'test2' digest:test:test:cdrwa,digest:test:test:cdrwa
> Created /test2
> [zk: (CONNECTED) 1] getAcl /test2
> 'digest,'test:test
> : cdrwa
> 'digest,'test:test
> : cdrwa
> [zk: (CONNECTED) 2]
> but getAcl should only have a single entry.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1055) check for duplicate ACLs in
addACL() and create()
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13032963#comment-13032963 ]
Hadoop QA commented on ZOOKEEPER-1055:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12479064/ZOOKEEPER-1055.patch
against trunk revision 1099329.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 2 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/260//testReport/
Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/260//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/260//console
This message is automatically generated.
> check for duplicate ACLs in addACL() and create()
> -------------------------------------------------
>
> Key: ZOOKEEPER-1055
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1055
> Project: ZooKeeper
> Issue Type: Bug
> Affects Versions: 3.4.0
> Reporter: Eugene Koontz
> Assignee: Eugene Koontz
> Fix For: 3.4.0
>
> Attachments: ZOOKEEPER-1055.patch, ZOOKEEPER-1055.patch, ZOOKEEPER-1055.patch
>
>
> actual result:
> [zk: (CONNECTED) 0] create /test2 'test2' digest:test:test:cdrwa,digest:test:test:cdrwa
> Created /test2
> [zk: (CONNECTED) 1] getAcl /test2
> 'digest,'test:test
> : cdrwa
> 'digest,'test:test
> : cdrwa
> [zk: (CONNECTED) 2]
> but getAcl should only have a single entry.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1055) check for duplicate ACLs in
addACL() and create()
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13034487#comment-13034487 ]
Hadoop QA commented on ZOOKEEPER-1055:
--------------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12479195/ZOOKEEPER-1055.patch
against trunk revision 1103811.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 2 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/264//testReport/
Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/264//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/264//console
This message is automatically generated.
> check for duplicate ACLs in addACL() and create()
> -------------------------------------------------
>
> Key: ZOOKEEPER-1055
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1055
> Project: ZooKeeper
> Issue Type: Bug
> Affects Versions: 3.4.0
> Reporter: Eugene Koontz
> Assignee: Eugene Koontz
> Fix For: 3.4.0
>
> Attachments: ZOOKEEPER-1055.patch, ZOOKEEPER-1055.patch, ZOOKEEPER-1055.patch, ZOOKEEPER-1055.patch
>
>
> actual result:
> [zk: (CONNECTED) 0] create /test2 'test2' digest:test:test:cdrwa,digest:test:test:cdrwa
> Created /test2
> [zk: (CONNECTED) 1] getAcl /test2
> 'digest,'test:test
> : cdrwa
> 'digest,'test:test
> : cdrwa
> [zk: (CONNECTED) 2]
> but getAcl should only have a single entry.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1055) check for duplicate ACLs in
addACL() and create()
Posted by "Eugene Koontz (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1055?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eugene Koontz updated ZOOKEEPER-1055:
-------------------------------------
Attachment: (was: ZOOKEEPER-1055.patch)
> check for duplicate ACLs in addACL() and create()
> -------------------------------------------------
>
> Key: ZOOKEEPER-1055
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1055
> Project: ZooKeeper
> Issue Type: Bug
> Reporter: Eugene Koontz
> Assignee: Eugene Koontz
> Attachments: ZOOKEEPER-1055.patch
>
>
> actual result:
> [zk: (CONNECTED) 0] create /test2 'test2' digest:test:test:cdrwa,digest:test:test:cdrwa
> Created /test2
> [zk: (CONNECTED) 1] getAcl /test2
> 'digest,'test:test
> : cdrwa
> 'digest,'test:test
> : cdrwa
> [zk: (CONNECTED) 2]
> but getAcl should only have a single entry.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira