You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@jmeter.apache.org by bu...@apache.org on 2018/09/05 19:45:35 UTC
[Bug 62683] New: No error text shown in dialog when invalid jmx file
gets opened
https://bz.apache.org/bugzilla/show_bug.cgi?id=62683
Bug ID: 62683
Summary: No error text shown in dialog when invalid jmx file
gets opened
Product: JMeter
Version: 4.0
Hardware: All
OS: All
Status: NEW
Severity: minor
Priority: P2
Component: Main
Assignee: issues@jmeter.apache.org
Reporter: felix.schumacher@internetallee.de
Target Milestone: ---
Created attachment 36133
--> https://bz.apache.org/bugzilla/attachment.cgi?id=36133&action=edit
Use the inner exception of a StreamException to display some error text at
least
When a user tries to open an invalid jmx file (for example a jmeter.log file),
the shown error dialog contains no text.
This happens as the getMessage method of the caught exception gets displayed,
but the StreamException has no descriptive message.
The attached patch will use the inner exception for the error message as that
is (in my tests) not empty and rather descriptive.
In addition to this change I think the error dialog should be changed to show a
general error message (instead of simply displaying "Error") together with the
name of the file that was tried to be opened.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 62683] No error text shown in dialog when invalid jmx file gets
opened
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=62683
--- Comment #1 from UbikLoadPack support <su...@ubikloadpack.com> ---
LGTM.
Thanks
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 62683] No error text shown in dialog when invalid jmx file gets
opened
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=62683
UbikLoadPack support <su...@ubikloadpack.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|--- |JMETER_5.0
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 62683] No error text shown in dialog when invalid jmx file gets
opened
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=62683
Felix Schumacher <fe...@internetallee.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|NEW |RESOLVED
--- Comment #2 from Felix Schumacher <fe...@internetallee.de> ---
Date: Thu Sep 6 17:07:59 2018
New Revision: 1840238
URL: http://svn.apache.org/viewvc?rev=1840238&view=rev
Log:
Use the wrapped exception for error message on file load for StreamException
When a user opens a test plan that is no xml at all, a StreamException
gets thrown. This exception can have an empty message. That will lead
to an error dialog that has no text at all. In that case we try to work
around this by using the wrapped exception as the source for the error
message.
Bugzilla Id: 62683
Modified:
jmeter/trunk/src/core/org/apache/jmeter/gui/action/Load.java
jmeter/trunk/xdocs/changes.xml
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 62683] No error text shown in dialog when invalid jmx file gets
opened
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=62683
moh.riza <mo...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Ever confirmed|1 |0
Status|RESOLVED |UNCONFIRMED
Resolution|FIXED |---
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 62683] No error text shown in dialog when invalid jmx file gets
opened
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=62683
Felix Schumacher <fe...@internetallee.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|UNCONFIRMED |RESOLVED
--
You are receiving this mail because:
You are the assignee for the bug.