[GitHub] [netbeans] matthiasblaesing commented on a diff in pull request #5830: add user-select css property

["matthiasblaesing (via GitHub)" <gi...@apache.org>]

matthiasblaesing commented on code in PR #5830:
URL: https://github.com/apache/netbeans/pull/5830#discussion_r1167897064


##########
ide/css.editor/src/org/netbeans/modules/css/editor/module/main/properties/text.properties:
##########
@@ -101,6 +101,8 @@ overflow-wrap=normal | break-word | <var-fn>
         ]\
          | <var-fn>
 
+user-select=auto | none | text | all

Review Comment:
   1. Please add ` | <var-fn>`, so that a variable based setting is supported
   2. I have mixed feelings about `contain`. The whole CSS4 standard is a draft, I see that the reality is already here, but why not then use the draft standard as basis? Users will anyway have to decide how much they trust into the CSS enging.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists