You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2021/06/02 14:52:26 UTC

[GitHub] [accumulo] foster33 edited a comment on pull request #2122: Change getProperties in TableOperations and NamespaceOperations to return Map instead of Iterable

foster33 edited a comment on pull request #2122:
URL: https://github.com/apache/accumulo/pull/2122#issuecomment-853094692


   In my commit [f16dbf6](https://github.com/apache/accumulo/pull/2122/commits/f16dbf62c9791252254a4432b205fba991dbc34f), I have:
   
   - Re-added the `@since` tag to the deprecated `@getProperties` function
   - Changed the name of the new function to `@getConfiguration`
   - Removed the duplicated logic in `@getProperties` and made it call `@getConfiguration` and return with .entrySet()
   - Cleaned up 'clunky' code by implementing Map.forEach() or streams
   - Made small changes to some variable types that were previously Iterables
   
   In [ed2ce01](https://github.com/apache/accumulo/pull/2122/commits/ed2ce0156bf75a280d43f36592be82e1ca52ed6d) I added some parts to the deprecated tags that I had overlooked.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org